From: Lee Jones <lee.jones@linaro.org> To: davem@davemloft.net, kuba@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones <lee.jones@linaro.org>, Boris Ostrovsky <boris.ostrovsky@oracle.com>, Juergen Gross <jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>, Alexei Starovoitov <ast@kernel.org>, Daniel Borkmann <daniel@iogearbox.net>, Jesper Dangaard Brouer <hawk@kernel.org>, John Fastabend <john.fastabend@gmail.com>, Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>, Andrii Nakryiko <andrii@kernel.org>, KP Singh <kpsingh@chromium.org>, xen-devel@lists.xenproject.org, netdev@vger.kernel.org, bpf@vger.kernel.org Subject: [PATCH 08/12] net: xen-netfront: Demote non-kernel-doc headers to standard comment blocks Date: Wed, 4 Nov 2020 09:06:06 +0000 [thread overview] Message-ID: <20201104090610.1446616-9-lee.jones@linaro.org> (raw) In-Reply-To: <20201104090610.1446616-1-lee.jones@linaro.org> Fixes the following W=1 kernel build warning(s): drivers/net/xen-netfront.c: In function ‘store_rxbuf’: drivers/net/xen-netfront.c:2416:16: warning: variable ‘target’ set but not used [-Wunused-but-set-variable] drivers/net/xen-netfront.c:1592: warning: Function parameter or member 'dev' not described in 'netfront_probe' drivers/net/xen-netfront.c:1592: warning: Function parameter or member 'id' not described in 'netfront_probe' drivers/net/xen-netfront.c:1669: warning: Function parameter or member 'dev' not described in 'netfront_resume' drivers/net/xen-netfront.c:2313: warning: Function parameter or member 'dev' not described in 'netback_changed' drivers/net/xen-netfront.c:2313: warning: Function parameter or member 'backend_state' not described in 'netback_changed' Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com> Cc: Juergen Gross <jgross@suse.com> Cc: Stefano Stabellini <sstabellini@kernel.org> Cc: "David S. Miller" <davem@davemloft.net> Cc: Jakub Kicinski <kuba@kernel.org> Cc: Alexei Starovoitov <ast@kernel.org> Cc: Daniel Borkmann <daniel@iogearbox.net> Cc: Jesper Dangaard Brouer <hawk@kernel.org> Cc: John Fastabend <john.fastabend@gmail.com> Cc: Martin KaFai Lau <kafai@fb.com> Cc: Song Liu <songliubraving@fb.com> Cc: Yonghong Song <yhs@fb.com> Cc: Andrii Nakryiko <andrii@kernel.org> Cc: KP Singh <kpsingh@chromium.org> Cc: xen-devel@lists.xenproject.org Cc: netdev@vger.kernel.org Cc: bpf@vger.kernel.org Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/net/xen-netfront.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c index 920cac4385bf7..93740ef4cf1b4 100644 --- a/drivers/net/xen-netfront.c +++ b/drivers/net/xen-netfront.c @@ -1582,7 +1582,7 @@ static struct net_device *xennet_create_dev(struct xenbus_device *dev) return ERR_PTR(err); } -/** +/* * Entry point to this code when a new device is created. Allocate the basic * structures and the ring buffers for communication with the backend, and * inform the backend of the appropriate details for those. @@ -1659,7 +1659,7 @@ static void xennet_disconnect_backend(struct netfront_info *info) } } -/** +/* * We are reconnecting to the backend, due to a suspend/resume, or a backend * driver restart. We tear down our netif structure and recreate it, but * leave the device-layer structures intact so that this is transparent to the @@ -2305,7 +2305,7 @@ static int xennet_connect(struct net_device *dev) return 0; } -/** +/* * Callback received when the backend's state changes. */ static void netback_changed(struct xenbus_device *dev, -- 2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org> To: davem@davemloft.net, kuba@kernel.org Cc: Juergen Gross <jgross@suse.com>, Song Liu <songliubraving@fb.com>, Stefano Stabellini <sstabellini@kernel.org>, Jesper Dangaard Brouer <hawk@kernel.org>, Daniel Borkmann <daniel@iogearbox.net>, netdev@vger.kernel.org, bpf@vger.kernel.org, John Fastabend <john.fastabend@gmail.com>, linux-kernel@vger.kernel.org, Alexei Starovoitov <ast@kernel.org>, Andrii Nakryiko <andrii@kernel.org>, xen-devel@lists.xenproject.org, KP Singh <kpsingh@chromium.org>, Yonghong Song <yhs@fb.com>, Boris Ostrovsky <boris.ostrovsky@oracle.com>, Lee Jones <lee.jones@linaro.org>, Martin KaFai Lau <kafai@fb.com>, linux-arm-kernel@lists.infradead.org Subject: [PATCH 08/12] net: xen-netfront: Demote non-kernel-doc headers to standard comment blocks Date: Wed, 4 Nov 2020 09:06:06 +0000 [thread overview] Message-ID: <20201104090610.1446616-9-lee.jones@linaro.org> (raw) In-Reply-To: <20201104090610.1446616-1-lee.jones@linaro.org> Fixes the following W=1 kernel build warning(s): drivers/net/xen-netfront.c: In function ‘store_rxbuf’: drivers/net/xen-netfront.c:2416:16: warning: variable ‘target’ set but not used [-Wunused-but-set-variable] drivers/net/xen-netfront.c:1592: warning: Function parameter or member 'dev' not described in 'netfront_probe' drivers/net/xen-netfront.c:1592: warning: Function parameter or member 'id' not described in 'netfront_probe' drivers/net/xen-netfront.c:1669: warning: Function parameter or member 'dev' not described in 'netfront_resume' drivers/net/xen-netfront.c:2313: warning: Function parameter or member 'dev' not described in 'netback_changed' drivers/net/xen-netfront.c:2313: warning: Function parameter or member 'backend_state' not described in 'netback_changed' Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com> Cc: Juergen Gross <jgross@suse.com> Cc: Stefano Stabellini <sstabellini@kernel.org> Cc: "David S. Miller" <davem@davemloft.net> Cc: Jakub Kicinski <kuba@kernel.org> Cc: Alexei Starovoitov <ast@kernel.org> Cc: Daniel Borkmann <daniel@iogearbox.net> Cc: Jesper Dangaard Brouer <hawk@kernel.org> Cc: John Fastabend <john.fastabend@gmail.com> Cc: Martin KaFai Lau <kafai@fb.com> Cc: Song Liu <songliubraving@fb.com> Cc: Yonghong Song <yhs@fb.com> Cc: Andrii Nakryiko <andrii@kernel.org> Cc: KP Singh <kpsingh@chromium.org> Cc: xen-devel@lists.xenproject.org Cc: netdev@vger.kernel.org Cc: bpf@vger.kernel.org Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/net/xen-netfront.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c index 920cac4385bf7..93740ef4cf1b4 100644 --- a/drivers/net/xen-netfront.c +++ b/drivers/net/xen-netfront.c @@ -1582,7 +1582,7 @@ static struct net_device *xennet_create_dev(struct xenbus_device *dev) return ERR_PTR(err); } -/** +/* * Entry point to this code when a new device is created. Allocate the basic * structures and the ring buffers for communication with the backend, and * inform the backend of the appropriate details for those. @@ -1659,7 +1659,7 @@ static void xennet_disconnect_backend(struct netfront_info *info) } } -/** +/* * We are reconnecting to the backend, due to a suspend/resume, or a backend * driver restart. We tear down our netif structure and recreate it, but * leave the device-layer structures intact so that this is transparent to the @@ -2305,7 +2305,7 @@ static int xennet_connect(struct net_device *dev) return 0; } -/** +/* * Callback received when the backend's state changes. */ static void netback_changed(struct xenbus_device *dev, -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-11-04 9:06 UTC|newest] Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-04 9:05 [PATCH 00/12] [Set 2] Rid W=1 warnings in Net Lee Jones 2020-11-04 9:05 ` Lee Jones 2020-11-04 9:05 ` [PATCH 01/12] net: usb: lan78xx: Remove lots of set but unused 'ret' variables Lee Jones 2020-11-04 9:05 ` Lee Jones 2020-11-04 13:23 ` Andrew Lunn 2020-11-04 13:23 ` Andrew Lunn 2020-11-04 9:06 ` [PATCH 02/12] net: ethernet: smsc: smc911x: Mark 'status' as __maybe_unused Lee Jones 2020-11-04 9:06 ` Lee Jones 2020-11-04 13:22 ` Andrew Lunn 2020-11-04 13:22 ` Andrew Lunn 2020-11-04 14:31 ` Lee Jones 2020-11-04 14:31 ` Lee Jones 2020-11-04 14:38 ` Lee Jones 2020-11-04 14:38 ` Lee Jones 2020-11-04 14:47 ` Andrew Lunn 2020-11-04 14:47 ` Andrew Lunn 2020-11-04 14:45 ` Andrew Lunn 2020-11-04 14:45 ` Andrew Lunn 2020-11-04 14:56 ` Lee Jones 2020-11-04 14:56 ` Lee Jones 2020-11-04 9:06 ` [PATCH 03/12] net: ethernet: xilinx: xilinx_emaclite: Document 'txqueue' even if it is unused Lee Jones 2020-11-04 9:06 ` Lee Jones 2020-11-04 13:24 ` Andrew Lunn 2020-11-04 13:24 ` Andrew Lunn 2020-11-04 9:06 ` [PATCH 04/12] net: ethernet: smsc: smc91x: Demote non-conformant kernel function header Lee Jones 2020-11-04 9:06 ` Lee Jones 2020-11-04 9:06 ` [PATCH 05/12] net: xen-netback: xenbus: Demote nonconformant kernel-doc headers Lee Jones 2020-11-04 9:06 ` Lee Jones 2020-11-04 12:00 ` Wei Liu 2020-11-04 12:00 ` Wei Liu 2020-11-04 13:27 ` Andrew Lunn 2020-11-04 13:27 ` Andrew Lunn 2020-11-04 9:06 ` [PATCH 06/12] net: ethernet: ti: am65-cpsw-qos: Demote non-conformant function header Lee Jones 2020-11-04 9:06 ` Lee Jones 2020-11-04 13:33 ` Andrew Lunn 2020-11-04 13:33 ` Andrew Lunn 2020-11-04 14:28 ` Lee Jones 2020-11-04 14:28 ` Lee Jones 2020-11-04 14:38 ` Andrew Lunn 2020-11-04 14:38 ` Andrew Lunn 2020-11-04 15:02 ` Lee Jones 2020-11-04 15:02 ` Lee Jones 2020-11-04 9:06 ` [PATCH 07/12] net: ethernet: ti: am65-cpts: Document am65_cpts_rx_enable()'s 'en' parameter Lee Jones 2020-11-04 9:06 ` Lee Jones 2020-11-04 11:37 ` Grygorii Strashko 2020-11-04 11:37 ` Grygorii Strashko 2020-11-04 9:06 ` Lee Jones [this message] 2020-11-04 9:06 ` [PATCH 08/12] net: xen-netfront: Demote non-kernel-doc headers to standard comment blocks Lee Jones 2020-11-04 9:31 ` Jürgen Groß 2020-11-04 9:31 ` Jürgen Groß 2020-11-04 13:36 ` Andrew Lunn 2020-11-04 13:36 ` Andrew Lunn 2020-11-04 9:06 ` [PATCH 09/12] net: ethernet: ibm: ibmvnic: Fix some kernel-doc misdemeanours Lee Jones 2020-11-04 9:06 ` Lee Jones 2020-11-04 9:06 ` Lee Jones 2020-11-04 13:38 ` Andrew Lunn 2020-11-04 13:38 ` Andrew Lunn 2020-11-04 13:38 ` Andrew Lunn 2020-11-04 17:54 ` drt 2020-11-04 17:54 ` drt 2020-11-04 17:54 ` drt 2020-11-04 9:06 ` [PATCH 10/12] net: ethernet: toshiba: ps3_gelic_net: " Lee Jones 2020-11-04 9:06 ` Lee Jones 2020-11-04 9:06 ` Lee Jones 2020-11-04 13:41 ` Andrew Lunn 2020-11-04 13:41 ` Andrew Lunn 2020-11-04 13:41 ` Andrew Lunn 2020-11-04 9:06 ` [PATCH 11/12] net: ethernet: toshiba: spider_net: Document a whole bunch of function parameters Lee Jones 2020-11-04 9:06 ` Lee Jones 2020-11-04 13:43 ` Andrew Lunn 2020-11-04 13:43 ` Andrew Lunn 2020-11-04 9:06 ` [PATCH 12/12] net: ethernet: ibm: ibmvnic: Fix some kernel-doc issues Lee Jones 2020-11-04 9:06 ` Lee Jones 2020-11-04 9:06 ` Lee Jones 2020-11-04 17:59 ` drt 2020-11-04 17:59 ` drt 2020-11-04 17:59 ` drt
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201104090610.1446616-9-lee.jones@linaro.org \ --to=lee.jones@linaro.org \ --cc=andrii@kernel.org \ --cc=ast@kernel.org \ --cc=boris.ostrovsky@oracle.com \ --cc=bpf@vger.kernel.org \ --cc=daniel@iogearbox.net \ --cc=davem@davemloft.net \ --cc=hawk@kernel.org \ --cc=jgross@suse.com \ --cc=john.fastabend@gmail.com \ --cc=kafai@fb.com \ --cc=kpsingh@chromium.org \ --cc=kuba@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=netdev@vger.kernel.org \ --cc=songliubraving@fb.com \ --cc=sstabellini@kernel.org \ --cc=xen-devel@lists.xenproject.org \ --cc=yhs@fb.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.