From: "Philippe Mathieu-Daudé" <philmd@redhat.com> To: qemu-devel@nongnu.org Cc: "Fam Zheng" <fam@euphon.net>, "Thomas Huth" <thuth@redhat.com>, "Stefano Stabellini" <sstabellini@kernel.org>, "Daniel P . Berrange" <berrange@redhat.com>, "Matthew Rosato" <mjrosato@linux.ibm.com>, "David Hildenbrand" <david@redhat.com>, "Alex Bennée" <alex.bennee@linaro.org>, "Cornelia Huck" <cohuck@redhat.com>, "Christian Schoenebeck" <qemu_oss@crudebyte.com>, "Greg Kurz" <groug@kaod.org>, "Wainer dos Santos Moschetta" <wainersm@redhat.com>, "Halil Pasic" <pasic@linux.ibm.com>, "Christian Borntraeger" <borntraeger@de.ibm.com>, qemu-s390x@nongnu.org, xen-devel@lists.xenproject.org, "Anthony Perard" <anthony.perard@citrix.com>, "Paolo Bonzini" <pbonzini@redhat.com>, "Philippe Mathieu-Daudé" <philmd@redhat.com>, "Paul Durrant" <paul@xen.org>, "Richard Henderson" <rth@twiddle.net> Subject: [PATCH-for-5.2 v3 2/4] hw/9pfs: Fix Kconfig dependency problem between 9pfs and Xen Date: Wed, 4 Nov 2020 12:57:04 +0100 [thread overview] Message-ID: <20201104115706.3101190-3-philmd@redhat.com> (raw) In-Reply-To: <20201104115706.3101190-1-philmd@redhat.com> Commit b2c00bce54c ("meson: convert hw/9pfs, cleanup") introduced CONFIG_9PFS (probably a wrong conflict resolution). This config is not used anywhere. Backends depend on CONFIG_FSDEV_9P which itself depends on CONFIG_VIRTFS. Remove the invalid CONFIG_9PFS and use CONFIG_FSDEV_9P instead, to fix the './configure --without-default-devices --enable-xen' build: /usr/bin/ld: libcommon.fa.p/hw_xen_xen-legacy-backend.c.o: in function `xen_be_register_common': hw/xen/xen-legacy-backend.c:754: undefined reference to `xen_9pfs_ops' /usr/bin/ld: libcommon.fa.p/fsdev_qemu-fsdev.c.o:(.data.rel+0x8): undefined reference to `local_ops' /usr/bin/ld: libcommon.fa.p/fsdev_qemu-fsdev.c.o:(.data.rel+0x20): undefined reference to `synth_ops' /usr/bin/ld: libcommon.fa.p/fsdev_qemu-fsdev.c.o:(.data.rel+0x38): undefined reference to `proxy_ops' collect2: error: ld returned 1 exit status Fixes: b2c00bce54c ("meson: convert hw/9pfs, cleanup") Suggested-by: Paolo Bonzini <pbonzini@redhat.com> Acked-by: Greg Kurz <groug@kaod.org> Tested-by: Greg Kurz <groug@kaod.org> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- v2: Reworded description (Greg) Cc: Stefano Stabellini <sstabellini@kernel.org> Cc: Anthony Perard <anthony.perard@citrix.com> Cc: Paul Durrant <paul@xen.org> Cc: xen-devel@lists.xenproject.org Cc: Greg Kurz <groug@kaod.org> Cc: Christian Schoenebeck <qemu_oss@crudebyte.com> --- hw/9pfs/Kconfig | 4 ---- hw/9pfs/meson.build | 2 +- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/hw/9pfs/Kconfig b/hw/9pfs/Kconfig index d3ebd737301..3ae57496613 100644 --- a/hw/9pfs/Kconfig +++ b/hw/9pfs/Kconfig @@ -2,12 +2,8 @@ config FSDEV_9P bool depends on VIRTFS -config 9PFS - bool - config VIRTIO_9P bool default y depends on VIRTFS && VIRTIO select FSDEV_9P - select 9PFS diff --git a/hw/9pfs/meson.build b/hw/9pfs/meson.build index cc094262122..99be5d91196 100644 --- a/hw/9pfs/meson.build +++ b/hw/9pfs/meson.build @@ -15,6 +15,6 @@ 'coxattr.c', )) fs_ss.add(when: 'CONFIG_XEN', if_true: files('xen-9p-backend.c')) -softmmu_ss.add_all(when: 'CONFIG_9PFS', if_true: fs_ss) +softmmu_ss.add_all(when: 'CONFIG_FSDEV_9P', if_true: fs_ss) specific_ss.add(when: 'CONFIG_VIRTIO_9P', if_true: files('virtio-9p-device.c')) -- 2.26.2
WARNING: multiple messages have this Message-ID (diff)
From: "Philippe Mathieu-Daudé" <philmd@redhat.com> To: qemu-devel@nongnu.org Cc: qemu-s390x@nongnu.org, "Christian Schoenebeck" <qemu_oss@crudebyte.com>, "Thomas Huth" <thuth@redhat.com>, "Cornelia Huck" <cohuck@redhat.com>, "Matthew Rosato" <mjrosato@linux.ibm.com>, "Philippe Mathieu-Daudé" <philmd@redhat.com>, "Daniel P . Berrange" <berrange@redhat.com>, "Paolo Bonzini" <pbonzini@redhat.com>, "Richard Henderson" <rth@twiddle.net>, "Fam Zheng" <fam@euphon.net>, "Christian Borntraeger" <borntraeger@de.ibm.com>, "Halil Pasic" <pasic@linux.ibm.com>, "Greg Kurz" <groug@kaod.org>, "Alex Bennée" <alex.bennee@linaro.org>, "Wainer dos Santos Moschetta" <wainersm@redhat.com>, "David Hildenbrand" <david@redhat.com>, "Stefano Stabellini" <sstabellini@kernel.org>, "Anthony Perard" <anthony.perard@citrix.com>, "Paul Durrant" <paul@xen.org>, xen-devel@lists.xenproject.org Subject: [PATCH-for-5.2 v3 2/4] hw/9pfs: Fix Kconfig dependency problem between 9pfs and Xen Date: Wed, 4 Nov 2020 12:57:04 +0100 [thread overview] Message-ID: <20201104115706.3101190-3-philmd@redhat.com> (raw) In-Reply-To: <20201104115706.3101190-1-philmd@redhat.com> Commit b2c00bce54c ("meson: convert hw/9pfs, cleanup") introduced CONFIG_9PFS (probably a wrong conflict resolution). This config is not used anywhere. Backends depend on CONFIG_FSDEV_9P which itself depends on CONFIG_VIRTFS. Remove the invalid CONFIG_9PFS and use CONFIG_FSDEV_9P instead, to fix the './configure --without-default-devices --enable-xen' build: /usr/bin/ld: libcommon.fa.p/hw_xen_xen-legacy-backend.c.o: in function `xen_be_register_common': hw/xen/xen-legacy-backend.c:754: undefined reference to `xen_9pfs_ops' /usr/bin/ld: libcommon.fa.p/fsdev_qemu-fsdev.c.o:(.data.rel+0x8): undefined reference to `local_ops' /usr/bin/ld: libcommon.fa.p/fsdev_qemu-fsdev.c.o:(.data.rel+0x20): undefined reference to `synth_ops' /usr/bin/ld: libcommon.fa.p/fsdev_qemu-fsdev.c.o:(.data.rel+0x38): undefined reference to `proxy_ops' collect2: error: ld returned 1 exit status Fixes: b2c00bce54c ("meson: convert hw/9pfs, cleanup") Suggested-by: Paolo Bonzini <pbonzini@redhat.com> Acked-by: Greg Kurz <groug@kaod.org> Tested-by: Greg Kurz <groug@kaod.org> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- v2: Reworded description (Greg) Cc: Stefano Stabellini <sstabellini@kernel.org> Cc: Anthony Perard <anthony.perard@citrix.com> Cc: Paul Durrant <paul@xen.org> Cc: xen-devel@lists.xenproject.org Cc: Greg Kurz <groug@kaod.org> Cc: Christian Schoenebeck <qemu_oss@crudebyte.com> --- hw/9pfs/Kconfig | 4 ---- hw/9pfs/meson.build | 2 +- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/hw/9pfs/Kconfig b/hw/9pfs/Kconfig index d3ebd737301..3ae57496613 100644 --- a/hw/9pfs/Kconfig +++ b/hw/9pfs/Kconfig @@ -2,12 +2,8 @@ config FSDEV_9P bool depends on VIRTFS -config 9PFS - bool - config VIRTIO_9P bool default y depends on VIRTFS && VIRTIO select FSDEV_9P - select 9PFS diff --git a/hw/9pfs/meson.build b/hw/9pfs/meson.build index cc094262122..99be5d91196 100644 --- a/hw/9pfs/meson.build +++ b/hw/9pfs/meson.build @@ -15,6 +15,6 @@ 'coxattr.c', )) fs_ss.add(when: 'CONFIG_XEN', if_true: files('xen-9p-backend.c')) -softmmu_ss.add_all(when: 'CONFIG_9PFS', if_true: fs_ss) +softmmu_ss.add_all(when: 'CONFIG_FSDEV_9P', if_true: fs_ss) specific_ss.add(when: 'CONFIG_VIRTIO_9P', if_true: files('virtio-9p-device.c')) -- 2.26.2
next prev parent reply other threads:[~2020-11-04 11:59 UTC|newest] Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-04 11:57 [PATCH-for-5.2 v3 0/4] ci: Move --without-default-devices job from Travis to GitLab Philippe Mathieu-Daudé 2020-11-04 11:57 ` [PATCH-for-5.2 v3 1/4] s390x: fix build for --without-default-devices Philippe Mathieu-Daudé 2020-11-04 17:25 ` Cornelia Huck 2020-11-05 11:58 ` Philippe Mathieu-Daudé 2020-11-05 12:01 ` Cornelia Huck 2020-11-05 14:43 ` Cornelia Huck 2020-11-04 11:57 ` Philippe Mathieu-Daudé [this message] 2020-11-04 11:57 ` [PATCH-for-5.2 v3 2/4] hw/9pfs: Fix Kconfig dependency problem between 9pfs and Xen Philippe Mathieu-Daudé 2020-11-04 12:18 ` Christian Schoenebeck 2020-11-04 17:54 ` Greg Kurz 2020-11-04 17:54 ` Greg Kurz 2020-11-05 12:15 ` Philippe Mathieu-Daudé 2020-11-05 12:15 ` Philippe Mathieu-Daudé 2020-11-05 12:23 ` Greg Kurz 2020-11-05 12:23 ` Greg Kurz 2020-11-05 12:28 ` Christian Schoenebeck 2020-11-05 15:06 ` Christian Schoenebeck 2020-11-04 11:57 ` [PATCH-for-5.2 v3 3/4] gitlab-ci: Add a job to cover the --without-default-devices config Philippe Mathieu-Daudé 2020-11-04 12:12 ` Wainer dos Santos Moschetta 2020-11-04 11:57 ` [PATCH-for-5.2 v3 4/4] travis-ci: Remove the --without-default-devices job Philippe Mathieu-Daudé 2020-11-04 12:16 ` Wainer dos Santos Moschetta
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201104115706.3101190-3-philmd@redhat.com \ --to=philmd@redhat.com \ --cc=alex.bennee@linaro.org \ --cc=anthony.perard@citrix.com \ --cc=berrange@redhat.com \ --cc=borntraeger@de.ibm.com \ --cc=cohuck@redhat.com \ --cc=david@redhat.com \ --cc=fam@euphon.net \ --cc=groug@kaod.org \ --cc=mjrosato@linux.ibm.com \ --cc=pasic@linux.ibm.com \ --cc=paul@xen.org \ --cc=pbonzini@redhat.com \ --cc=qemu-devel@nongnu.org \ --cc=qemu-s390x@nongnu.org \ --cc=qemu_oss@crudebyte.com \ --cc=rth@twiddle.net \ --cc=sstabellini@kernel.org \ --cc=thuth@redhat.com \ --cc=wainersm@redhat.com \ --cc=xen-devel@lists.xenproject.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.