From: Chengguang Xu <cgxu519@mykernel.net>
To: miklos@szeredi.hu, jack@suse.cz, amir73il@gmail.com
Cc: linux-unionfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Chengguang Xu <cgxu519@mykernel.net>
Subject: [RFC PATCH v3 06/10] ovl: mark overlayfs' inode dirty on shared mmap
Date: Sun, 8 Nov 2020 22:03:03 +0800 [thread overview]
Message-ID: <20201108140307.1385745-7-cgxu519@mykernel.net> (raw)
In-Reply-To: <20201108140307.1385745-1-cgxu519@mykernel.net>
Overlayfs cannot be notified when mmapped area gets dirty,
so we need to proactively mark inode dirty in ->mmap operation.
Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>
---
fs/overlayfs/file.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/overlayfs/file.c b/fs/overlayfs/file.c
index efccb7c1f9bc..662252047fff 100644
--- a/fs/overlayfs/file.c
+++ b/fs/overlayfs/file.c
@@ -486,6 +486,8 @@ static int ovl_mmap(struct file *file, struct vm_area_struct *vma)
/* Drop reference count from new vm_file value */
fput(realfile);
} else {
+ if (vma->vm_flags & (VM_SHARED|VM_MAYSHARE))
+ ovl_mark_inode_dirty(file_inode(file));
/* Drop reference count from previous vm_file value */
fput(file);
}
--
2.26.2
next prev parent reply other threads:[~2020-11-08 14:04 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-08 14:02 [RFC PATCH v3 00/10] implement containerized syncfs for overlayfs Chengguang Xu
2020-11-08 14:02 ` [RFC PATCH v3 01/10] ovl: setup overlayfs' private bdi Chengguang Xu
2020-11-08 14:02 ` [RFC PATCH v3 02/10] ovl: introduce waiting list for syncfs Chengguang Xu
2020-11-08 14:03 ` [RFC PATCH v3 03/10] ovl: implement ->writepages operation Chengguang Xu
2020-11-08 14:03 ` [RFC PATCH v3 04/10] ovl: implement overlayfs' ->evict_inode operation Chengguang Xu
2020-11-08 14:03 ` [RFC PATCH v3 05/10] ovl: mark overlayfs' inode dirty on modification Chengguang Xu
2020-11-08 14:03 ` Chengguang Xu [this message]
2020-11-11 13:05 ` 回复:[RFC PATCH v3 06/10] ovl: mark overlayfs' inode dirty on shared mmap Chengguang Xu
2020-11-11 15:20 ` [RFC " Amir Goldstein
2020-11-11 16:09 ` Chengguang Xu
2020-11-08 14:03 ` [RFC PATCH v3 07/10] ovl: implement overlayfs' ->write_inode operation Chengguang Xu
2020-11-10 13:45 ` Jan Kara
2020-11-10 15:12 ` Chengguang Xu
2020-11-11 10:54 ` Jan Kara
2020-11-10 16:18 ` Amir Goldstein
2020-11-08 14:03 ` [RFC PATCH v3 08/10] ovl: cache dirty overlayfs' inode Chengguang Xu
2020-11-08 14:03 ` [RFC PATCH v3 09/10] ovl: introduce helper of syncfs writeback inode waiting Chengguang Xu
2020-11-09 3:33 ` 回复:[RFC " Chengguang Xu
2020-11-09 7:07 ` [RFC " Amir Goldstein
2020-11-09 8:34 ` Chengguang Xu
2020-11-09 10:07 ` Amir Goldstein
2020-11-09 12:06 ` Chengguang Xu
2020-11-09 9:03 ` kernel test robot
2020-11-09 14:23 ` kernel test robot
2020-11-08 14:03 ` [RFC PATCH v3 10/10] ovl: implement containerized syncfs for overlayfs Chengguang Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201108140307.1385745-7-cgxu519@mykernel.net \
--to=cgxu519@mykernel.net \
--cc=amir73il@gmail.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.