All of lore.kernel.org
 help / color / mirror / Atom feed
From: Frank Lee <frank@allwinnertech.com>
To: vkoul@kernel.org, robh+dt@kernel.org, mripard@kernel.org,
	wens@csie.org, ulf.hansson@linaro.org, kishon@ti.com,
	wim@linux-watchdog.org, linux@roeck-us.net,
	dan.j.williams@intel.com, linus.walleij@linaro.org,
	wsa+renesas@sang-engineering.com, dianders@chromium.org,
	marex@denx.de, colin.king@canonical.com, rdunlap@infradead.org,
	krzk@kernel.org, gregkh@linuxfoundation.org, megous@megous.com,
	rikard.falkeborn@gmail.com, dmaengine@vger.kernel.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org,
	linux-watchdog@vger.kernel.org, linux-gpio@vger.kernel.org,
	tiny.windzz@gmail.com
Cc: Yangtao Li <frank@allwinnertech.com>
Subject: [PATCH 02/19] pinctrl: sunxi: Mark the irq bank not found in sunxi_pinctrl_irq_handler() with WARN_ON
Date: Tue, 10 Nov 2020 12:05:36 +0800	[thread overview]
Message-ID: <20201110040553.1381-3-frank@allwinnertech.com> (raw)
In-Reply-To: <20201110040553.1381-1-frank@allwinnertech.com>

From: Yangtao Li <frank@allwinnertech.com>

The interrupt descriptor cannot be found in the interrupt processing
function, and this situation cannot happen when the system is running
normally. It doesn't seem right to return directly to the status of not
handling gic. In this case, it must be a bug, let's mark it with
BUG_ON.

Signed-off-by: Yangtao Li <frank@allwinnertech.com>
---
 drivers/pinctrl/sunxi/pinctrl-sunxi.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/pinctrl/sunxi/pinctrl-sunxi.c b/drivers/pinctrl/sunxi/pinctrl-sunxi.c
index 8e792f8e2dc9..9d8b59dafa4b 100644
--- a/drivers/pinctrl/sunxi/pinctrl-sunxi.c
+++ b/drivers/pinctrl/sunxi/pinctrl-sunxi.c
@@ -1139,8 +1139,7 @@ static void sunxi_pinctrl_irq_handler(struct irq_desc *desc)
 		if (irq == pctl->irq[bank])
 			break;
 
-	if (bank == pctl->desc->irq_banks)
-		return;
+	WARN_ON(bank == pctl->desc->irq_banks);
 
 	reg = sunxi_irq_status_reg_from_bank(pctl->desc, bank);
 	val = readl(pctl->membase + reg);
-- 
2.28.0


WARNING: multiple messages have this Message-ID (diff)
From: Frank Lee <frank@allwinnertech.com>
To: vkoul@kernel.org, robh+dt@kernel.org, mripard@kernel.org,
	wens@csie.org, ulf.hansson@linaro.org, kishon@ti.com,
	wim@linux-watchdog.org, linux@roeck-us.net,
	dan.j.williams@intel.com, linus.walleij@linaro.org,
	wsa+renesas@sang-engineering.com, dianders@chromium.org,
	marex@denx.de, colin.king@canonical.com, rdunlap@infradead.org,
	krzk@kernel.org, gregkh@linuxfoundation.org, megous@megous.com,
	rikard.falkeborn@gmail.com, dmaengine@vger.kernel.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org,
	linux-watchdog@vger.kernel.org, linux-gpio@vger.kernel.org,
	tiny.windzz@gmail.com
Cc: Yangtao Li <frank@allwinnertech.com>
Subject: [PATCH 02/19] pinctrl: sunxi: Mark the irq bank not found in sunxi_pinctrl_irq_handler() with WARN_ON
Date: Tue, 10 Nov 2020 12:05:36 +0800	[thread overview]
Message-ID: <20201110040553.1381-3-frank@allwinnertech.com> (raw)
In-Reply-To: <20201110040553.1381-1-frank@allwinnertech.com>

From: Yangtao Li <frank@allwinnertech.com>

The interrupt descriptor cannot be found in the interrupt processing
function, and this situation cannot happen when the system is running
normally. It doesn't seem right to return directly to the status of not
handling gic. In this case, it must be a bug, let's mark it with
BUG_ON.

Signed-off-by: Yangtao Li <frank@allwinnertech.com>
---
 drivers/pinctrl/sunxi/pinctrl-sunxi.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/pinctrl/sunxi/pinctrl-sunxi.c b/drivers/pinctrl/sunxi/pinctrl-sunxi.c
index 8e792f8e2dc9..9d8b59dafa4b 100644
--- a/drivers/pinctrl/sunxi/pinctrl-sunxi.c
+++ b/drivers/pinctrl/sunxi/pinctrl-sunxi.c
@@ -1139,8 +1139,7 @@ static void sunxi_pinctrl_irq_handler(struct irq_desc *desc)
 		if (irq == pctl->irq[bank])
 			break;
 
-	if (bank == pctl->desc->irq_banks)
-		return;
+	WARN_ON(bank == pctl->desc->irq_banks);
 
 	reg = sunxi_irq_status_reg_from_bank(pctl->desc, bank);
 	val = readl(pctl->membase + reg);
-- 
2.28.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2020-11-10  4:07 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-10  4:05 [PATCH 00/19] Second step support for A100 Frank Lee
2020-11-10  4:05 ` Frank Lee
2020-11-10  4:05 ` [PATCH 01/19] pinctrl: sunxi: fix irq bank map for the Allwinner A100 pin controller Frank Lee
2020-11-10  4:05   ` Frank Lee
2020-11-10  4:05 ` Frank Lee [this message]
2020-11-10  4:05   ` [PATCH 02/19] pinctrl: sunxi: Mark the irq bank not found in sunxi_pinctrl_irq_handler() with WARN_ON Frank Lee
2020-11-10  4:05 ` [PATCH 03/19] pinctrl: sunxi: Always call chained_irq_{enter, exit} in sunxi_pinctrl_irq_handler Frank Lee
2020-11-10  4:05   ` Frank Lee
2020-11-10  4:05 ` [PATCH 04/19] dt-bindings: dma: allwinner,sun50i-a64-dma: Add A100 compatible Frank Lee
2020-11-10  4:05   ` [PATCH 04/19] dt-bindings: dma: allwinner, sun50i-a64-dma: " Frank Lee
2020-11-10  4:05 ` [PATCH 05/19] dmaengine: sun6i: Add support for A100 DMA Frank Lee
2020-11-10  4:05   ` Frank Lee
2020-11-10  4:05 ` [PATCH 06/19] arm64: allwinner: a100: Add device node for DMA controller Frank Lee
2020-11-10  4:05   ` Frank Lee
2020-11-10  4:05 ` [PATCH 07/19] arm64: dts: allwinner: A100: Add PMU mode Frank Lee
2020-11-10  4:05   ` Frank Lee
2020-11-10  4:05 ` [PATCH 08/19] phy: sun4i-usb: remove enable_pmu_unk1 from sun50i_h6_cfg Frank Lee
2020-11-10  4:05   ` Frank Lee
2020-11-10  4:05 ` [PATCH 09/19] phy: allwinner: Convert to devm_platform_ioremap_* API Frank Lee
2020-11-10  4:05   ` Frank Lee
2020-11-10  4:05 ` [PATCH 10/19] dt-bindings: watchdog: sun4i: Add A100 compatible Frank Lee
2020-11-10  6:00 ` [PATCH 00/19] Second step support for A100 Frank Lee
2020-11-10  6:00   ` Frank Lee
2020-11-10  8:43   ` Krzysztof Kozlowski
2020-11-10  8:43     ` Krzysztof Kozlowski
2020-11-10  8:51     ` Frank Lee
2020-11-10  8:51       ` Frank Lee
2020-11-10 12:48       ` Vinod Koul
2020-11-10 12:48         ` Vinod Koul
2020-11-10 12:55         ` maxime
2020-11-10 12:55           ` maxime

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201110040553.1381-3-frank@allwinnertech.com \
    --to=frank@allwinnertech.com \
    --cc=colin.king@canonical.com \
    --cc=dan.j.williams@intel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=dmaengine@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=kishon@ti.com \
    --cc=krzk@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=marex@denx.de \
    --cc=megous@megous.com \
    --cc=mripard@kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=rikard.falkeborn@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=tiny.windzz@gmail.com \
    --cc=ulf.hansson@linaro.org \
    --cc=vkoul@kernel.org \
    --cc=wens@csie.org \
    --cc=wim@linux-watchdog.org \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.