From: Anshuman Gupta <anshuman.gupta@intel.com> To: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Cc: jani.nikula@intel.com, uma.shankar@intel.com, seanpaul@chromium.org, Anshuman Gupta <anshuman.gupta@intel.com>, juston.li@intel.com Subject: [PATCH v5 01/17] drm/i915/hdcp: Update CP property in update_pipe Date: Wed, 11 Nov 2020 11:50:35 +0530 [thread overview] Message-ID: <20201111062051.11529-2-anshuman.gupta@intel.com> (raw) In-Reply-To: <20201111062051.11529-1-anshuman.gupta@intel.com> When crtc state need_modeset is true it is not necessary it is going to be a real modeset, it can turns to be a fastset instead of modeset. This turns content protection property to be DESIRED and hdcp update_pipe left with property to be in DESIRED state but actual hdcp->value was ENABLED. This issue is caught with DP MST setup, where we have multiple connector in same DP_MST topology. When disabling HDCP on one of DP MST connector leads to set the crtc state need_modeset to true for all other crtc driving the other DP-MST topology connectors. This turns up other DP MST connectors CP property to be DESIRED despite the actual hdcp->value is ENABLED. Above scenario fails the DP MST HDCP IGT test, disabling HDCP on one MST stream should not cause to disable HDCP on another MST stream on same DP MST topology. v2: Fix WARN_ON(connector->base.registration_state == DRM_CONNECTOR_REGISTERED) v3: Commit log improvement. [Uma] Added a comment before scheduling prop_work. [Uma] Fixes: 33f9a623bfc6 ("drm/i915/hdcp: Update CP as per the kernel internal state") Cc: Ramalingam C <ramalingam.c@intel.com> Reviewed-by: Uma Shankar <uma.shankar@intel.com> Reviewed-by: Ramalingam C <ramalingam.c@intel.com> Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com> --- drivers/gpu/drm/i915/display/intel_hdcp.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c b/drivers/gpu/drm/i915/display/intel_hdcp.c index b2a4bbcfdcd2..eee8263405b9 100644 --- a/drivers/gpu/drm/i915/display/intel_hdcp.c +++ b/drivers/gpu/drm/i915/display/intel_hdcp.c @@ -2221,6 +2221,14 @@ void intel_hdcp_update_pipe(struct intel_atomic_state *state, desired_and_not_enabled = hdcp->value != DRM_MODE_CONTENT_PROTECTION_ENABLED; mutex_unlock(&hdcp->mutex); + /* + * If HDCP already ENABLED and CP property is DESIRED, schedule + * prop_work to update correct CP property to user space. + */ + if (!desired_and_not_enabled && !content_protection_type_changed) { + drm_connector_get(&connector->base); + schedule_work(&hdcp->prop_work); + } } if (desired_and_not_enabled || content_protection_type_changed) -- 2.26.2 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Anshuman Gupta <anshuman.gupta@intel.com> To: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Cc: jani.nikula@intel.com, seanpaul@chromium.org Subject: [Intel-gfx] [PATCH v5 01/17] drm/i915/hdcp: Update CP property in update_pipe Date: Wed, 11 Nov 2020 11:50:35 +0530 [thread overview] Message-ID: <20201111062051.11529-2-anshuman.gupta@intel.com> (raw) In-Reply-To: <20201111062051.11529-1-anshuman.gupta@intel.com> When crtc state need_modeset is true it is not necessary it is going to be a real modeset, it can turns to be a fastset instead of modeset. This turns content protection property to be DESIRED and hdcp update_pipe left with property to be in DESIRED state but actual hdcp->value was ENABLED. This issue is caught with DP MST setup, where we have multiple connector in same DP_MST topology. When disabling HDCP on one of DP MST connector leads to set the crtc state need_modeset to true for all other crtc driving the other DP-MST topology connectors. This turns up other DP MST connectors CP property to be DESIRED despite the actual hdcp->value is ENABLED. Above scenario fails the DP MST HDCP IGT test, disabling HDCP on one MST stream should not cause to disable HDCP on another MST stream on same DP MST topology. v2: Fix WARN_ON(connector->base.registration_state == DRM_CONNECTOR_REGISTERED) v3: Commit log improvement. [Uma] Added a comment before scheduling prop_work. [Uma] Fixes: 33f9a623bfc6 ("drm/i915/hdcp: Update CP as per the kernel internal state") Cc: Ramalingam C <ramalingam.c@intel.com> Reviewed-by: Uma Shankar <uma.shankar@intel.com> Reviewed-by: Ramalingam C <ramalingam.c@intel.com> Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com> --- drivers/gpu/drm/i915/display/intel_hdcp.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c b/drivers/gpu/drm/i915/display/intel_hdcp.c index b2a4bbcfdcd2..eee8263405b9 100644 --- a/drivers/gpu/drm/i915/display/intel_hdcp.c +++ b/drivers/gpu/drm/i915/display/intel_hdcp.c @@ -2221,6 +2221,14 @@ void intel_hdcp_update_pipe(struct intel_atomic_state *state, desired_and_not_enabled = hdcp->value != DRM_MODE_CONTENT_PROTECTION_ENABLED; mutex_unlock(&hdcp->mutex); + /* + * If HDCP already ENABLED and CP property is DESIRED, schedule + * prop_work to update correct CP property to user space. + */ + if (!desired_and_not_enabled && !content_protection_type_changed) { + drm_connector_get(&connector->base); + schedule_work(&hdcp->prop_work); + } } if (desired_and_not_enabled || content_protection_type_changed) -- 2.26.2 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-11-11 6:35 UTC|newest] Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-11 6:20 [PATCH v5 00/17] HDCP 2.2 and HDCP 1.4 Gen12 DP MST support Anshuman Gupta 2020-11-11 6:20 ` [Intel-gfx] " Anshuman Gupta 2020-11-11 6:20 ` Anshuman Gupta [this message] 2020-11-11 6:20 ` [Intel-gfx] [PATCH v5 01/17] drm/i915/hdcp: Update CP property in update_pipe Anshuman Gupta 2020-11-11 6:20 ` [PATCH v5 02/17] drm/i915/hdcp: Get conn while content_type changed Anshuman Gupta 2020-11-11 6:20 ` [Intel-gfx] " Anshuman Gupta 2020-11-11 6:20 ` [PATCH v5 03/17] drm/i915/hotplug: Handle CP_IRQ for DP-MST Anshuman Gupta 2020-11-11 6:20 ` [Intel-gfx] " Anshuman Gupta 2020-11-11 6:20 ` [PATCH v5 04/17] drm/i915/hdcp: DP MST transcoder for link and stream Anshuman Gupta 2020-11-11 6:20 ` [Intel-gfx] " Anshuman Gupta 2020-11-11 6:20 ` [PATCH v5 05/17] drm/i915/hdcp: Move HDCP enc status timeout to header Anshuman Gupta 2020-11-11 6:20 ` [Intel-gfx] " Anshuman Gupta 2020-11-11 6:20 ` [PATCH v5 06/17] drm/i915/hdcp: HDCP stream encryption support Anshuman Gupta 2020-11-11 6:20 ` [Intel-gfx] " Anshuman Gupta 2020-11-11 6:20 ` [PATCH v5 07/17] drm/i915/hdcp: Enable HDCP 1.4 stream encryption Anshuman Gupta 2020-11-11 6:20 ` [Intel-gfx] " Anshuman Gupta 2020-11-24 14:14 ` Ramalingam C 2020-11-24 14:14 ` [Intel-gfx] " Ramalingam C 2020-11-24 15:05 ` Anshuman Gupta 2020-11-24 15:05 ` [Intel-gfx] " Anshuman Gupta 2020-11-11 6:20 ` [PATCH v5 08/17] drm/i915/hdcp: Enable Gen12 HDCP 1.4 DP MST support Anshuman Gupta 2020-11-11 6:20 ` [Intel-gfx] " Anshuman Gupta 2020-11-24 14:20 ` Ramalingam C 2020-11-24 14:20 ` [Intel-gfx] " Ramalingam C 2020-11-24 15:02 ` Anshuman Gupta 2020-11-24 15:02 ` [Intel-gfx] " Anshuman Gupta 2020-11-24 16:17 ` Ramalingam C 2020-11-24 16:17 ` [Intel-gfx] " Ramalingam C 2020-11-24 16:05 ` Anshuman Gupta 2020-11-24 16:05 ` [Intel-gfx] " Anshuman Gupta 2020-11-11 6:20 ` [PATCH v5 09/17] drm/i915/hdcp: Pass dig_port to intel_hdcp_init Anshuman Gupta 2020-11-11 6:20 ` [Intel-gfx] " Anshuman Gupta 2020-11-11 6:20 ` [PATCH v5 10/17] drm/i915/hdcp: Encapsulate hdcp_port_data to dig_port Anshuman Gupta 2020-11-11 6:20 ` [Intel-gfx] " Anshuman Gupta 2020-11-11 6:20 ` [PATCH v5 11/17] misc/mei/hdcp: Fix AUTH_STREAM_REQ cmd buffer len Anshuman Gupta 2020-11-11 6:20 ` [Intel-gfx] " Anshuman Gupta 2020-11-11 6:20 ` [PATCH v5 12/17] drm/hdcp: Max MST content streams Anshuman Gupta 2020-11-11 6:20 ` [Intel-gfx] " Anshuman Gupta 2020-11-11 6:20 ` [PATCH v5 13/17] drm/i915/hdcp: MST streams support in hdcp port_data Anshuman Gupta 2020-11-11 6:20 ` [Intel-gfx] " Anshuman Gupta 2020-11-24 16:49 ` Ramalingam C 2020-11-24 16:49 ` [Intel-gfx] " Ramalingam C 2020-11-11 6:20 ` [PATCH v5 14/17] drm/i915/hdcp: Pass connector to check_2_2_link Anshuman Gupta 2020-11-11 6:20 ` [Intel-gfx] " Anshuman Gupta 2020-11-24 17:03 ` Ramalingam C 2020-11-24 17:03 ` [Intel-gfx] " Ramalingam C 2020-11-11 6:20 ` [PATCH v5 15/17] drm/i915/hdcp: Add HDCP 2.2 stream register Anshuman Gupta 2020-11-11 6:20 ` [Intel-gfx] " Anshuman Gupta 2020-11-11 6:20 ` [PATCH v5 16/17] drm/i915/hdcp: Support for HDCP 2.2 MST shim callbacks Anshuman Gupta 2020-11-11 6:20 ` [Intel-gfx] " Anshuman Gupta 2020-11-11 6:20 ` [PATCH v5 17/17] drm/i915/hdcp: Enable HDCP 2.2 MST support Anshuman Gupta 2020-11-11 6:20 ` [Intel-gfx] " Anshuman Gupta 2020-11-11 15:51 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for HDCP 2.2 and HDCP 1.4 Gen12 DP MST support (rev4) Patchwork 2020-11-11 16:20 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2020-11-11 18:16 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork 2020-11-24 10:57 ` [Intel-gfx] [PATCH v5 00/17] HDCP 2.2 and HDCP 1.4 Gen12 DP MST support Karthik B S 2020-11-24 10:57 ` Karthik B S
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201111062051.11529-2-anshuman.gupta@intel.com \ --to=anshuman.gupta@intel.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=intel-gfx@lists.freedesktop.org \ --cc=jani.nikula@intel.com \ --cc=juston.li@intel.com \ --cc=seanpaul@chromium.org \ --cc=uma.shankar@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.