From: Alexandru Ardelean <alexandru.ardelean@analog.com>
To: <linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Cc: <alexandru.tachici@analog.com>, <jic23@kernel.org>,
<lars@metafoo.de>,
Alexandru Ardelean <alexandru.ardelean@analog.com>
Subject: [PATCH v2] iio: ad_sigma_delta: Don't put SPI transfer buffer on the stack
Date: Fri, 13 Nov 2020 11:40:59 +0200 [thread overview]
Message-ID: <20201113094059.152651-1-alexandru.ardelean@analog.com> (raw)
In-Reply-To: <20201112091050.84991-1-alexandru.ardelean@analog.com>
From: Lars-Peter Clausen <lars@metafoo.de>
Use a heap allocated memory for the SPI transfer buffer. Using stack memory
can corrupt stack memory when using DMA on some systems.
This change moves the buffer from the stack of the trigger handler call to
the heap of the buffer of the state struct. The size increases takes into
account the alignment for the timestamp, which is 8 bytes.
So the buffer is put at an offset of 8 bytes.
Fixes: af3008485ea03 ("iio:adc: Add common code for ADI Sigma Delta devices")
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
---
Changelog v1 -> v2:
* bumped the buffer on state struct to 24 bytes
* increased the offset to 8 bytes to account for the timestamp alignment
drivers/iio/adc/ad_sigma_delta.c | 2 +-
include/linux/iio/adc/ad_sigma_delta.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/adc/ad_sigma_delta.c b/drivers/iio/adc/ad_sigma_delta.c
index 86039e9ecaca..9f730c9d6aaa 100644
--- a/drivers/iio/adc/ad_sigma_delta.c
+++ b/drivers/iio/adc/ad_sigma_delta.c
@@ -395,9 +395,9 @@ static irqreturn_t ad_sd_trigger_handler(int irq, void *p)
struct iio_poll_func *pf = p;
struct iio_dev *indio_dev = pf->indio_dev;
struct ad_sigma_delta *sigma_delta = iio_device_get_drvdata(indio_dev);
+ uint8_t *data = &sigma_delta->data[8];
unsigned int reg_size;
unsigned int data_reg;
- uint8_t data[16];
memset(data, 0x00, 16);
diff --git a/include/linux/iio/adc/ad_sigma_delta.h b/include/linux/iio/adc/ad_sigma_delta.h
index a3a838dcf8e4..8fb74755f873 100644
--- a/include/linux/iio/adc/ad_sigma_delta.h
+++ b/include/linux/iio/adc/ad_sigma_delta.h
@@ -80,7 +80,7 @@ struct ad_sigma_delta {
* DMA (thus cache coherency maintenance) requires the
* transfer buffers to live in their own cache lines.
*/
- uint8_t data[4] ____cacheline_aligned;
+ uint8_t data[24] ____cacheline_aligned;
};
static inline int ad_sigma_delta_set_channel(struct ad_sigma_delta *sd,
--
2.27.0
next prev parent reply other threads:[~2020-11-13 9:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-12 9:10 [PATCH] iio: ad_sigma_delta: Don't put SPI transfer buffer on the stack Alexandru Ardelean
2020-11-12 9:54 ` Lars-Peter Clausen
2020-11-12 10:14 ` Alexandru Ardelean
2020-11-12 10:52 ` Lars-Peter Clausen
2020-11-13 9:40 ` Alexandru Ardelean [this message]
2020-11-14 16:20 ` [PATCH v2] " Jonathan Cameron
2020-11-19 8:30 ` Alexandru Ardelean
2020-11-21 16:41 ` Jonathan Cameron
2020-11-24 12:38 ` [PATCH v3] " Alexandru Ardelean
2020-11-28 13:34 ` Jonathan Cameron
-- strict thread matches above, loose matches on Subject: below --
2019-04-09 7:58 [PATCH] " Alexandru Ardelean
2019-04-16 8:19 ` [PATCH V2] " Alexandru Ardelean
2019-04-22 8:56 ` Jonathan Cameron
2019-04-22 10:28 ` Ardelean, Alexandru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201113094059.152651-1-alexandru.ardelean@analog.com \
--to=alexandru.ardelean@analog.com \
--cc=alexandru.tachici@analog.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.