All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Sai Pavan Boddu" <sai.pavan.boddu@xilinx.com>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>
Subject: [PULL 3/6] hw/usb/Kconfig: Fix USB_XHCI_NEC (depends on USB_XHCI_PCI)
Date: Fri, 13 Nov 2020 13:29:52 +0100	[thread overview]
Message-ID: <20201113122955.759-4-kraxel@redhat.com> (raw)
In-Reply-To: <20201113122955.759-1-kraxel@redhat.com>

From: Philippe Mathieu-Daudé <philmd@redhat.com>

Since commit 755fba11fbc and 8ddab8dd3d8 we can not build
USB_XHCI_NEC without USB_XHCI_PCI. Correct the Kconfig
dependency.

Fixes: 755fba11fbc ("usb/hcd-xhci: Move qemu-xhci device to hcd-xhci-pci.c")
Reviewed-by: Sai Pavan Boddu <sai.pavan.boddu@xilinx.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-id: 20201109135300.2592982-2-philmd@redhat.com

[ kraxel: restore "default y if PCI_DEVICES" because
          "qemu-system-ppc64 -M pseries,usb=on" needs USB_XHCI_NEC=y ]

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 hw/usb/Kconfig | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/hw/usb/Kconfig b/hw/usb/Kconfig
index a674ce4c542e..3b07d9cf6879 100644
--- a/hw/usb/Kconfig
+++ b/hw/usb/Kconfig
@@ -43,8 +43,7 @@ config USB_XHCI_PCI
 config USB_XHCI_NEC
     bool
     default y if PCI_DEVICES
-    depends on PCI
-    select USB_XHCI
+    select USB_XHCI_PCI
 
 config USB_XHCI_SYSBUS
     bool
-- 
2.27.0



  parent reply	other threads:[~2020-11-13 12:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-13 12:29 [PULL 0/6] Fixes 20201113 patches Gerd Hoffmann
2020-11-13 12:29 ` [PULL 1/6] audio/jack: fix use after free segfault Gerd Hoffmann
2020-11-13 12:29 ` [PULL 2/6] console: avoid passing con=NULL to graphic_hw_update_done() Gerd Hoffmann
2020-11-13 12:29 ` Gerd Hoffmann [this message]
2020-11-13 12:29 ` [PULL 4/6] hw/display/cirrus_vga: Remove debugging code commented out Gerd Hoffmann
2020-11-13 12:29 ` [PULL 5/6] hw/display/cirrus_vga: Fix hexadecimal format string specifier Gerd Hoffmann
2020-11-13 12:29 ` [PULL 6/6] xhci: fix nec-usb-xhci properties Gerd Hoffmann
2020-11-13 13:40 ` [PULL 0/6] Fixes 20201113 patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201113122955.759-4-kraxel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=sai.pavan.boddu@xilinx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.