From: "Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>
To: linux-media@vger.kernel.org
Cc: linux-renesas-soc@vger.kernel.org,
"Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>
Subject: [PATCH 0/3] adv748x: Add support for s2ram
Date: Sun, 22 Nov 2020 17:36:34 +0100 [thread overview]
Message-ID: <20201122163637.3590465-1-niklas.soderlund+renesas@ragnatech.se> (raw)
Hello,
This series enables usage of the ADV748x after the system have been
suspended to ram. During s2ram the ADV748x may be powered down and thus
lose its configuration from probe time. The configuration contains
among other things the i2c slave address mappings for the different
blocks inside the ADV748x. If this is lost the hardware listens to the
"wrong" i2c addresses and becomes inaccessible.
Example trying to read the analog standard before and after s2ram with
and without this this series.
Without this series,
# subdev=$(grep -l "adv748x 4-0070 afe" /sys/class/video4linux/*/name | sed 's#.*video4linux\(.*\)/name#/dev\1#g')
# v4l2-ctl --get-detected-standard -d $subdev
Video Standard = 0x000000ff
PAL-B/B1/G/H/I/D/D1/K
# echo on > /sys/bus/i2c/drivers/bd9571mwv/*/bd9571mwv-regulator*/backup_mode
** flipp SW23 off **
# echo mem > /sys/power/state
** flipp SW23 on **
# v4l2-ctl --get-detected-standard -d $subdev
[ 502.753723] adv748x 4-0070: error reading 63, 02
[ 502.866437] adv748x 4-0070: error reading 63, 02
VIDIOC_QUERYSTD: failed: No such device or address
With this series,
# subdev=$(grep -l "adv748x 4-0070 afe" /sys/class/video4linux/*/name | sed 's#.*video4linux\(.*\)/name#/dev\1#g')
# v4l2-ctl --get-detected-standard -d $subdev
Video Standard = 0x000000ff
PAL-B/B1/G/H/I/D/D1/K
# echo on > /sys/bus/i2c/drivers/bd9571mwv/*/bd9571mwv-regulator*/backup_mode
** flipp SW23 off **
# echo mem > /sys/power/state
** flipp SW23 on **
# v4l2-ctl --get-detected-standard -d $subdev
Video Standard = 0x000000ff
PAL-B/B1/G/H/I/D/D1/K
Also any streaming while the system is suspended to ram fails to resume
without this series due to the issue demonstrated above. This series is
tested on R-Car M3-N on-top of latest media-tree.
Niklas Söderlund (3):
adv748x: afe: Select input port when device is reset
adv748x: csi2: Set virtual channel when device is reset
adv748x: Configure device when resuming from sleep
drivers/media/i2c/adv748x/adv748x-afe.c | 6 +----
drivers/media/i2c/adv748x/adv748x-core.c | 29 ++++++++++++++++++++++--
drivers/media/i2c/adv748x/adv748x-csi2.c | 6 +----
drivers/media/i2c/adv748x/adv748x.h | 2 ++
4 files changed, 31 insertions(+), 12 deletions(-)
--
2.29.2
next reply other threads:[~2020-11-22 16:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-22 16:36 Niklas Söderlund [this message]
2020-11-22 16:36 ` [PATCH 1/3] adv748x: afe: Select input port when device is reset Niklas Söderlund
2020-11-23 8:00 ` Sergei Shtylyov
2020-11-25 12:10 ` Kieran Bingham
2020-11-25 13:16 ` Niklas Söderlund
2020-11-22 16:36 ` [PATCH 2/3] adv748x: csi2: Set virtual channel " Niklas Söderlund
2020-11-23 8:06 ` Sergei Shtylyov
2020-11-22 16:36 ` [PATCH 3/3] adv748x: Configure device when resuming from sleep Niklas Söderlund
2020-11-23 8:09 ` Sergei Shtylyov
2020-11-23 8:05 ` [PATCH 0/3] adv748x: Add support for s2ram Sergei Shtylyov
2020-11-25 13:09 ` Kieran Bingham
2020-11-25 13:39 ` Niklas Söderlund
2020-11-25 13:58 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201122163637.3590465-1-niklas.soderlund+renesas@ragnatech.se \
--to=niklas.soderlund+renesas@ragnatech.se \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.