From: Takashi Iwai <tiwai@suse.de>
To: alsa-devel@alsa-project.org
Cc: Matwey Kornilov <matwey.kornilov@gmail.com>,
Dylan Robinson <dylan_robinson@motu.com>,
Keith Milner <kamilner@superlative.org>
Subject: [PATCH 00/41] USB audio refactoring for better implicit feedback support
Date: Mon, 23 Nov 2020 09:53:06 +0100 [thread overview]
Message-ID: <20201123085347.19667-1-tiwai@suse.de> (raw)
Hi,
here is a largish patch set for USB-audio. Its main goal is to
address the long-standing issues wrt the implicit feedback mode.
With the current driver, when the implicit fb is used, the full duplex
doesn't work properly unless you start both streams *very* carefully.
This patch set tries to ease such the configuration mismatch and fix
many other bugs.
In short, with this patch set applied, USB-audio driver will try to
restrict the hw_params to match with the already opened counter-part
stream automatically. So individual aplay and arecord invocation
should work now, as well as PulseAudio.
Also, the patch set includes more fixes, e.g. the generic detection of
the implicit feedback mode on UAC2/3, and the fix for the sample rate
selection on UAC2/3, as well as a few more quirks to follow the new
implicit fb model.
The latest patches are available in topic/usb-audio-refactoring
branch.
I specially thank Keith Milner and Dylan Robinson for their time spent
for lots of testing. Without their patient help, I couldn't finish
those patches, as I myself don't own such devices.
Takashi
===
Dylan Robinson (1):
ALSA: usb-audio: Fix MOTU M-Series quirks
Takashi Iwai (40):
ALSA: usb-audio: Handle discrete rates properly in hw constraints
ALSA: usb-audio: Don't call usb_set_interface() at trigger callback
ALSA: usb-audio: Check valid altsetting at parsing rates for UAC2/3
ALSA: usb-audio: Check implicit feedback EP generically for UAC2
ALSA: usb-audio: Add snd_usb_get_endpoint() helper
ALSA: usb-audio: Set and clear sync EP link properly
ALSA: usb-audio: Improve some debug prints
ALSA: usb-audio: Track implicit fb sync endpoint in audioformat list
ALSA: usb-audio: Move snd_usb_autoresume() call out of setup_hw_info()
ALSA: usb-audio: Add hw constraint for implicit fb sync
ALSA: usb-audio: Simplify hw_params rules
ALSA: usb-audio: Drop debug.h
ALSA: usb-audio: Avoid doubly initialization for implicit fb
ALSA: usb-audio: Create endpoint objects at parsing phase
ALSA: usb-audio: Drop keep_interface flag again
ALSA: usb-audio: Add snd_usb_get_host_interface() helper
ALSA: usb-audio: Don't set altsetting before initializing sample rate
ALSA: usb-audio: Pass snd_usb_audio object to quirk functions
ALSA: usb-audio: Simplify snd_usb_init_sample_rate() arguments
ALSA: usb-audio: Simplify snd_usb_init_pitch() arguments
ALSA: usb-audio: Stop both endpoints properly at error
ALSA: usb-audio: Set callbacks via snd_usb_endpoint_set_callback()
ALSA: usb-audio: Always set up the parameters after resume
ALSA: usb-audio: Fix EP matching for continuous rates
ALSA: usb-audio: Refactor endpoint management
ALSA: usb-audio: Fix possible stall of implicit fb packet ring-buffer
ALSA: usb-audio: Constify audioformat pointer references
ALSA: usb-audio: Use atomic_t for endpoint use_count
ALSA: usb-audio: Refactoring endpoint URB deactivation
ALSA: usb-audio: Drop unneeded snd_usb_substream fields
ALSA: usb-audio: Unify the code for the next packet size calculation
ALSA: usb-audio: Simplify rate_min/max and rates set up
ALSA: usb-audio: Replace slave/master terms
ALSA: usb-audio: Use unsigned char for iface and altsettings fields
ALSA: usb-audio: Show sync endpoint information in proc outputs
ALSA: usb-audio: Quirk for BOSS GT-001
ALSA: usb-audio: Factor out the implicit feedback quirk code
ALSA: usb-audio: Add generic implicit fb parsing
ALSA: usb-audio: Add implicit_fb module option
ALSA: usb-audio: Fix quirks for other BOSS devices
Documentation/sound/alsa-configuration.rst | 5 +
sound/usb/Makefile | 1 +
sound/usb/card.c | 14 +-
sound/usb/card.h | 53 +-
sound/usb/clock.c | 152 ++--
sound/usb/clock.h | 11 +-
sound/usb/debug.h | 16 -
sound/usb/endpoint.c | 943 +++++++++++++----------
sound/usb/endpoint.h | 57 +-
sound/usb/format.c | 125 +++-
sound/usb/helper.c | 10 +
sound/usb/helper.h | 3 +
sound/usb/implicit.c | 402 ++++++++++
sound/usb/implicit.h | 14 +
sound/usb/mixer.c | 46 --
sound/usb/pcm.c | 1117 ++++++++++------------------
sound/usb/pcm.h | 7 +-
sound/usb/proc.c | 35 +-
sound/usb/quirks-table.h | 8 -
sound/usb/quirks.c | 60 +-
sound/usb/quirks.h | 10 +-
sound/usb/stream.c | 24 +-
sound/usb/usbaudio.h | 5 +-
23 files changed, 1696 insertions(+), 1422 deletions(-)
delete mode 100644 sound/usb/debug.h
create mode 100644 sound/usb/implicit.c
create mode 100644 sound/usb/implicit.h
--
2.16.4
next reply other threads:[~2020-11-23 8:55 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-23 8:53 Takashi Iwai [this message]
2020-11-23 8:53 ` [PATCH 01/41] ALSA: usb-audio: Handle discrete rates properly in hw constraints Takashi Iwai
2020-11-23 8:53 ` [PATCH 02/41] ALSA: usb-audio: Don't call usb_set_interface() at trigger callback Takashi Iwai
2020-11-23 8:53 ` [PATCH 03/41] ALSA: usb-audio: Check valid altsetting at parsing rates for UAC2/3 Takashi Iwai
2020-11-23 8:53 ` [PATCH 04/41] ALSA: usb-audio: Check implicit feedback EP generically for UAC2 Takashi Iwai
2020-11-23 8:53 ` [PATCH 05/41] ALSA: usb-audio: Add snd_usb_get_endpoint() helper Takashi Iwai
2020-11-23 8:53 ` [PATCH 06/41] ALSA: usb-audio: Set and clear sync EP link properly Takashi Iwai
2020-11-23 8:53 ` [PATCH 07/41] ALSA: usb-audio: Improve some debug prints Takashi Iwai
2020-11-23 8:53 ` [PATCH 08/41] ALSA: usb-audio: Track implicit fb sync endpoint in audioformat list Takashi Iwai
2020-11-23 8:53 ` [PATCH 09/41] ALSA: usb-audio: Move snd_usb_autoresume() call out of setup_hw_info() Takashi Iwai
2020-11-23 8:53 ` [PATCH 10/41] ALSA: usb-audio: Add hw constraint for implicit fb sync Takashi Iwai
2020-11-23 8:53 ` [PATCH 11/41] ALSA: usb-audio: Simplify hw_params rules Takashi Iwai
2020-11-23 8:53 ` [PATCH 12/41] ALSA: usb-audio: Drop debug.h Takashi Iwai
2020-11-23 8:53 ` [PATCH 13/41] ALSA: usb-audio: Avoid doubly initialization for implicit fb Takashi Iwai
2020-11-23 8:53 ` [PATCH 14/41] ALSA: usb-audio: Create endpoint objects at parsing phase Takashi Iwai
2021-01-03 17:09 ` [PATCH 14/41] ALSA: usb-audio: Create endpoint objects at parsing phase - Pioneer DJ DJM-250MK2 stopped working František Kučera
2021-01-03 17:19 ` Takashi Iwai
2021-01-03 18:15 ` František Kučera
2021-01-05 9:29 ` Takashi Iwai
2021-01-05 13:20 ` Takashi Iwai
2021-01-05 22:27 ` František Kučera
2021-01-06 9:03 ` Takashi Iwai
2021-01-06 19:01 ` František Kučera
2021-01-07 13:30 ` Takashi Iwai
2020-11-23 8:53 ` [PATCH 15/41] ALSA: usb-audio: Drop keep_interface flag again Takashi Iwai
2020-11-23 8:53 ` [PATCH 16/41] ALSA: usb-audio: Add snd_usb_get_host_interface() helper Takashi Iwai
2020-11-23 8:53 ` [PATCH 17/41] ALSA: usb-audio: Don't set altsetting before initializing sample rate Takashi Iwai
2020-11-23 8:53 ` [PATCH 18/41] ALSA: usb-audio: Pass snd_usb_audio object to quirk functions Takashi Iwai
2020-11-23 8:53 ` [PATCH 19/41] ALSA: usb-audio: Simplify snd_usb_init_sample_rate() arguments Takashi Iwai
2020-11-23 8:53 ` [PATCH 20/41] ALSA: usb-audio: Simplify snd_usb_init_pitch() arguments Takashi Iwai
2020-11-23 8:53 ` [PATCH 21/41] ALSA: usb-audio: Stop both endpoints properly at error Takashi Iwai
2020-11-23 8:53 ` [PATCH 22/41] ALSA: usb-audio: Set callbacks via snd_usb_endpoint_set_callback() Takashi Iwai
2020-11-23 8:53 ` [PATCH 23/41] ALSA: usb-audio: Always set up the parameters after resume Takashi Iwai
2020-11-23 8:53 ` [PATCH 24/41] ALSA: usb-audio: Fix EP matching for continuous rates Takashi Iwai
2020-11-23 8:53 ` [PATCH 25/41] ALSA: usb-audio: Refactor endpoint management Takashi Iwai
2020-11-23 8:53 ` [PATCH 26/41] ALSA: usb-audio: Fix possible stall of implicit fb packet ring-buffer Takashi Iwai
2020-11-23 8:53 ` [PATCH 27/41] ALSA: usb-audio: Constify audioformat pointer references Takashi Iwai
2020-11-23 8:53 ` [PATCH 28/41] ALSA: usb-audio: Use atomic_t for endpoint use_count Takashi Iwai
2020-11-23 8:53 ` [PATCH 29/41] ALSA: usb-audio: Refactoring endpoint URB deactivation Takashi Iwai
2020-11-23 8:53 ` [PATCH 30/41] ALSA: usb-audio: Drop unneeded snd_usb_substream fields Takashi Iwai
2020-11-23 8:53 ` [PATCH 31/41] ALSA: usb-audio: Unify the code for the next packet size calculation Takashi Iwai
2020-11-23 8:53 ` [PATCH 32/41] ALSA: usb-audio: Simplify rate_min/max and rates set up Takashi Iwai
2020-11-23 8:53 ` [PATCH 33/41] ALSA: usb-audio: Replace slave/master terms Takashi Iwai
2020-11-23 8:53 ` [PATCH 34/41] ALSA: usb-audio: Use unsigned char for iface and altsettings fields Takashi Iwai
2020-11-23 8:53 ` [PATCH 35/41] ALSA: usb-audio: Show sync endpoint information in proc outputs Takashi Iwai
2020-11-23 8:53 ` [PATCH 36/41] ALSA: usb-audio: Quirk for BOSS GT-001 Takashi Iwai
2020-11-23 8:53 ` [PATCH 37/41] ALSA: usb-audio: Factor out the implicit feedback quirk code Takashi Iwai
2020-11-23 8:53 ` [PATCH 38/41] ALSA: usb-audio: Add generic implicit fb parsing Takashi Iwai
2020-11-23 8:53 ` [PATCH 39/41] ALSA: usb-audio: Add implicit_fb module option Takashi Iwai
2020-11-23 9:46 ` Pavel Hofman
2020-11-23 8:53 ` [PATCH 40/41] ALSA: usb-audio: Fix quirks for other BOSS devices Takashi Iwai
2020-11-23 8:53 ` [PATCH 41/41] ALSA: usb-audio: Fix MOTU M-Series quirks Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201123085347.19667-1-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=dylan_robinson@motu.com \
--cc=kamilner@superlative.org \
--cc=matwey.kornilov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.