From: Kai-Heng Feng <kai.heng.feng@canonical.com>
To: rafael.j.wysocki@intel.com
Cc: andy.shevchenko@gmail.com, mika.westerberg@linux.intel.com,
hdegoede@redhat.com, bhelgaas@google.com,
linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org,
Kai-Heng Feng <kai.heng.feng@canonical.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH] ACPI: PM: Re-enable ACPI GPE if it's already enabled
Date: Tue, 24 Nov 2020 15:36:19 +0800 [thread overview]
Message-ID: <20201124073619.771940-1-kai.heng.feng@canonical.com> (raw)
Dell Precision 5550 fails to detect Thunderbolt device hotplug events,
once the Thunderbolt device and its root port are runtime-suspended to
D3cold.
While putting the entire hierarchy to D3cold, the root port ACPI GPE is
enabled via acpi_pci_propagate_wakeup() when suspending Thunderbolt
bridges/switches. So when putting the root port to D3cold as last step,
ACPI GPE is untouched as it's already enabled.
However, platform may need PCI devices to be in D3hot or PME enabled
prior enabling GPE to make it work. So re-enable ACPI GPE to address
this.
Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
---
drivers/acpi/device_pm.c | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/drivers/acpi/device_pm.c b/drivers/acpi/device_pm.c
index 94d91c67aeae..dc25d9d204ae 100644
--- a/drivers/acpi/device_pm.c
+++ b/drivers/acpi/device_pm.c
@@ -757,11 +757,10 @@ static int __acpi_device_wakeup_enable(struct acpi_device *adev,
mutex_lock(&acpi_wakeup_lock);
- if (wakeup->enable_count >= max_count)
- goto out;
-
- if (wakeup->enable_count > 0)
- goto inc;
+ if (wakeup->enable_count > 0) {
+ acpi_disable_gpe(wakeup->gpe_device, wakeup->gpe_number);
+ acpi_disable_wakeup_device_power(adev);
+ }
error = acpi_enable_wakeup_device_power(adev, target_state);
if (error)
@@ -777,8 +776,8 @@ static int __acpi_device_wakeup_enable(struct acpi_device *adev,
acpi_handle_debug(adev->handle, "GPE%2X enabled for wakeup\n",
(unsigned int)wakeup->gpe_number);
-inc:
- wakeup->enable_count++;
+ if (wakeup->enable_count < max_count)
+ wakeup->enable_count++;
out:
mutex_unlock(&acpi_wakeup_lock);
--
2.29.2
next reply other threads:[~2020-11-24 7:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-24 7:36 Kai-Heng Feng [this message]
2020-11-24 14:00 ` [PATCH] ACPI: PM: Re-enable ACPI GPE if it's already enabled Rafael J. Wysocki
2020-11-24 17:31 ` Kai-Heng Feng
2020-11-24 17:48 ` Rafael J. Wysocki
2020-11-24 18:12 ` Kai-Heng Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201124073619.771940-1-kai.heng.feng@canonical.com \
--to=kai.heng.feng@canonical.com \
--cc=andy.shevchenko@gmail.com \
--cc=bhelgaas@google.com \
--cc=hdegoede@redhat.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rafael.j.wysocki@intel.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.