From: "Matthew Wilcox (Oracle)" <willy@infradead.org>
To: akpm@linux-foundation.org
Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>,
davem@davemloft.net, rppt@kernel.org, sparclinux@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: [PATCH 1/2] sparc: Fix handling of page table constructor failure
Date: Wed, 25 Nov 2020 03:46:54 +0000 [thread overview]
Message-ID: <20201125034655.27687-1-willy@infradead.org> (raw)
The page has just been allocated, so its refcount is 1. free_unref_page()
is for use on pages which have a zero refcount. Use __free_page()
like the other implementations of pte_alloc_one().
Fixes: 1ae9ae5f7df7 ("sparc: handle pgtable_page_ctor() fail")
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
---
arch/sparc/mm/init_64.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/sparc/mm/init_64.c b/arch/sparc/mm/init_64.c
index 96edf64d4fb3..182bb7bdaa0a 100644
--- a/arch/sparc/mm/init_64.c
+++ b/arch/sparc/mm/init_64.c
@@ -2894,7 +2894,7 @@ pgtable_t pte_alloc_one(struct mm_struct *mm)
if (!page)
return NULL;
if (!pgtable_pte_page_ctor(page)) {
- free_unref_page(page);
+ __free_page(page);
return NULL;
}
return (pte_t *) page_address(page);
--
2.29.2
next reply other threads:[~2020-11-25 3:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-25 3:46 Matthew Wilcox (Oracle) [this message]
2020-11-25 3:46 ` [PATCH 2/2] mm: Move free_unref_page to mm/internal.h Matthew Wilcox (Oracle)
2020-11-25 8:43 ` David Hildenbrand
2020-11-25 8:43 ` David Hildenbrand
2020-11-25 8:58 ` Mike Rapoport
2020-11-25 8:58 ` Mike Rapoport
2020-11-25 12:34 ` Vlastimil Babka
2020-11-25 12:34 ` Vlastimil Babka
2020-11-25 12:46 ` Matthew Wilcox
2020-11-25 8:43 ` [PATCH 1/2] sparc: Fix handling of page table constructor failure David Hildenbrand
2020-11-25 8:43 ` David Hildenbrand
2020-11-25 12:10 ` Matthew Wilcox
2020-11-25 13:24 ` David Hildenbrand
2020-11-25 13:24 ` David Hildenbrand
2020-11-25 8:57 ` Mike Rapoport
2020-11-25 8:57 ` Mike Rapoport
2020-11-25 12:30 ` Vlastimil Babka
2020-11-25 12:30 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201125034655.27687-1-willy@infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rppt@kernel.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.