[PATCH v1 0/28] drivers/video: W=1 warning fixes

From: Sam Ravnborg <sam@ravnborg.org>
To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Lee Jones <lee.jones@linaro.org>
Cc: Aditya Pakki <pakki001@umn.edu>,
	Alexander Klimov <grandmaster@al2klimov.de>,
	Alex Dewar <alex.dewar90@gmail.com>,
	Antonino Daplas <adaplas@gmail.com>,
	Arnd Bergmann <arnd@arndb.de>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	Evgeny Novikov <novikov@ispras.ru>,
	Ferenc Bakonyi <fero@drama.obuda.kando.hu>,
	Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
	George Kennedy <george.kennedy@oracle.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Gustavo Silva <gustavoars@kernel.org>,
	Jani Nikula <jani.nikula@intel.com>,
	Jason Yan <yanaijie@huawei.com>,
	Jingoo Han <jingoohan1@gmail.com>,
	Jiri Slaby <jirislaby@kernel.org>, Joe Perches <joe@perches.com>,
	Kristoffer Ericson <kristoffer.ericson@gmail.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	linux-nvidia@lists.surfsouth.com,
	Michal Januszewski <spock@gentoo.org>,
	Mike Rapoport <rppt@kernel.org>,
	Nathan Chancellor <natechancellor@gmail.com>,
	Peilin Ye <yepeilin.cs@gmail.com>, Peter Rosin <peda@axentia.se>,
	Qilong Zhang <zhangqilong3@huawei.com>,
	Randy Dunlap <rdunlap@infradead.org>,
	Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>,
	Sam Ravnborg <sam@ravnborg.org>,
	Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
	Thomas Winischhofer <thomas@winischhofer.net>,
	Thomas Zimemrmann <tzimmermann@suse.de>,
	Vaibhav Gupta <vaibhavgupta40@gmail.com>,
	Xiaofei Tan <tanxiaofei@huawei.com>
Subject: [PATCH v1 0/28] drivers/video: W=1 warning fixes
Date: Fri, 27 Nov 2020 20:57:57 +0100	[thread overview]
Message-ID: <20201127195825.858960-1-sam@ravnborg.org> (raw)

Following the great work of Lee Jones in other subsystems
here is a set of patches that address all remaining W=1
warnings in drivers/video/.
Lee Jones already fixed all warnings in video/backlight/ so
this is mostly fbdev related fixes.

The general approach used were:
- Fix kernel-doc, this is often very trivial
- Drop unused local variables
- Use no_printk for local logging support

Build tested on a set of architectures with various configs.

The patches do not depends on each other and in most cases all
fixes for one driver is kept in a single patch.

The individual changes are trivial so this is a great
starter task to try to review these patches.

A timely Reviewed-by: or Acked-by: would be very nice so we can
get the warnings fixes before we cut for the merge window.

	Sam

Sam Ravnborg (28):
      video: Fix W=1 warnings in of_videomode + of_display_timing
      video: fbcon: Use pr_debug() in fbcon
      video: fbdev: core: Fix W=1 warnings in fbmon + fb_notify
      video: fbdev: aty: Delete unused variable in radeon_monitor
      video: fbdev: aty: Fix W=1 warnings in atyfb_base
      video: fbdev: aty: Fix W=1 warnings in mach64_ct
      video: fbdev: sis: Fix W=1 warnings about static symbols
      video: fbdev: sis: Fix W=1 warning about SiS_TVDelay
      video: fbdev: sis: Fix W=1 warnings in init.c
      video: fbdev: sis: Fix W=1 warnings in sis_main
      video: fbdev: via: Fix W=1 warnings
      video: fbdev: tdfx: Fix W=1 warnings
      video: fbdev: riva: Fix W=1 warnings
      video: fbdev: pm2fb: Fix W=1 warnings
      video: fbdev: neofb: Fix W=1 warnings
      video: fbdev: hgafb: Fix W=1 warnings
      video: fbdev: tgafb: Fix W=1 warnings
      video: fbdev: mx3fb: Fix W=1 warnings
      video: fbdev: sstfb: Fix W=1 warnings
      video: fbdev: nvidia: Fix W=1 warnings
      video: fbdev: tmiofb: Fix W=1 warnings
      video: fbdev: omapfb: Fix W=1 warnings in dsi
      video: fbdev: omapfb: Fix W=1 warnings in hdmi*_core
      video: fbdev: s3c-fb: Fix W=1 warnings
      video: fbdev: uvesafb: Fix W=1 warning
      video: fbdev: uvesafb: Fix W=1 string related warnings
      video: fbdev: cirrusfb: Fix W=1 warnings
      video: fbdev: s1d13xxxfb: Fix W=1 warnings

 drivers/video/fbdev/aty/atyfb_base.c              | 12 ++------
 drivers/video/fbdev/aty/mach64_ct.c               | 15 ++++++----
 drivers/video/fbdev/aty/radeon_monitor.c          |  4 +--
 drivers/video/fbdev/cirrusfb.c                    | 20 ++++++-------
 drivers/video/fbdev/core/fb_notify.c              |  3 +-
 drivers/video/fbdev/core/fbcon.c                  | 20 ++++---------
 drivers/video/fbdev/core/fbmon.c                  |  2 +-
 drivers/video/fbdev/hgafb.c                       |  4 +--
 drivers/video/fbdev/mx3fb.c                       | 13 +++++----
 drivers/video/fbdev/neofb.c                       |  4 ---
 drivers/video/fbdev/nvidia/nv_setup.c             |  7 ++---
 drivers/video/fbdev/omap2/omapfb/dss/dsi.c        | 12 ++------
 drivers/video/fbdev/omap2/omapfb/dss/hdmi4_core.c |  4 +--
 drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c |  4 +--
 drivers/video/fbdev/pm2fb.c                       |  8 +++---
 drivers/video/fbdev/riva/fbdev.c                  |  9 +++---
 drivers/video/fbdev/riva/riva_hw.c                | 28 ++++++-------------
 drivers/video/fbdev/s1d13xxxfb.c                  |  3 +-
 drivers/video/fbdev/s3c-fb.c                      | 11 ++++----
 drivers/video/fbdev/sis/init.c                    | 34 ++++-------------------
 drivers/video/fbdev/sis/oem310.h                  |  2 ++
 drivers/video/fbdev/sis/sis.h                     |  1 -
 drivers/video/fbdev/sis/sis_main.c                |  9 +++---
 drivers/video/fbdev/sstfb.c                       |  2 +-
 drivers/video/fbdev/tdfxfb.c                      |  4 +--
 drivers/video/fbdev/tgafb.c                       |  7 ++---
 drivers/video/fbdev/tmiofb.c                      |  6 ++--
 drivers/video/fbdev/uvesafb.c                     |  8 +++---
 drivers/video/fbdev/via/lcd.c                     |  4 +--
 drivers/video/of_display_timing.c                 |  1 +
 drivers/video/of_videomode.c                      |  8 +++---
 include/video/sstfb.h                             |  4 +--
 32 files changed, 104 insertions(+), 169 deletions(-)