From: Vicente Bergas <vicencb@gmail.com>
To: Rob Herring <robh+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
Johan Jonker <jbx6244@gmail.com>, Chen-Yu Tsai <wens@csie.org>,
Douglas Anderson <dianders@chromium.org>,
Carlos de Paula <me@carlosedp.com>,
Sugar Zhang <sugar.zhang@rock-chips.com>,
Shunqian Zheng <zhengsq@rock-chips.com>,
Boris Brezillon <boris.brezillon@collabora.com>,
Robin Murphy <robin.murphy@arm.com>,
linux-rockchip@lists.infradead.org
Cc: Vicente Bergas <vicencb@gmail.com>
Subject: [PATCH 1/3] arm64: dts: rockchip: fix supplies on rk3399-rock-pi-4
Date: Tue, 1 Dec 2020 16:41:30 +0100 [thread overview]
Message-ID: <20201201154132.1286-2-vicencb@gmail.com> (raw)
In-Reply-To: <20201201154132.1286-1-vicencb@gmail.com>
Based on the board schematics at
https://dl.radxa.com/rockpi4/docs/hw/rockpi4/rockpi_4c_v12_sch_20200620.pdf
on page 18:
vcc_lan is not controllable by software, it is just an analog LC filter.
Because of this, it can not be turned off-in-suspend.
and on page 17:
vcc_cam and vcc_mipi are not voltage regulators, they are just switches.
So, the voltage range is not applicable.
This silences an error message about not being able to adjust the voltage.
Signed-off-by: Vicente Bergas <vicencb@gmail.com>
---
arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi | 8 --------
1 file changed, 8 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi
index 678a33601..06df2397b 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi
@@ -111,10 +111,6 @@ vcc_lan: vcc3v3-phy-regulator {
regulator-boot-on;
regulator-min-microvolt = <3300000>;
regulator-max-microvolt = <3300000>;
-
- regulator-state-mem {
- regulator-off-in-suspend;
- };
};
vdd_log: vdd-log {
@@ -362,8 +358,6 @@ vcc_cam: SWITCH_REG1 {
regulator-name = "vcc_cam";
regulator-always-on;
regulator-boot-on;
- regulator-min-microvolt = <3300000>;
- regulator-max-microvolt = <3300000>;
regulator-state-mem {
regulator-off-in-suspend;
};
@@ -373,8 +367,6 @@ vcc_mipi: SWITCH_REG2 {
regulator-name = "vcc_mipi";
regulator-always-on;
regulator-boot-on;
- regulator-min-microvolt = <3300000>;
- regulator-max-microvolt = <3300000>;
regulator-state-mem {
regulator-off-in-suspend;
};
--
2.29.2
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2020-12-01 15:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-01 15:41 [PATCH 0/3] arm64: dts: rockchip: miscellaneous fixes for rk3399-rock-pi-4c Vicente Bergas
2020-12-01 15:41 ` Vicente Bergas [this message]
2020-12-01 15:41 ` [PATCH 2/3] arm64: dts: rockchip: fix I2S conflict on rk3399-rock-pi-4 Vicente Bergas
2020-12-01 15:41 ` [PATCH 3/3] arm64: dts: rockchip: use USB host by default " Vicente Bergas
2020-12-04 11:01 ` [PATCH 0/3] arm64: dts: rockchip: miscellaneous fixes for rk3399-rock-pi-4c Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201201154132.1286-2-vicencb@gmail.com \
--to=vicencb@gmail.com \
--cc=boris.brezillon@collabora.com \
--cc=dianders@chromium.org \
--cc=heiko@sntech.de \
--cc=jbx6244@gmail.com \
--cc=linux-rockchip@lists.infradead.org \
--cc=me@carlosedp.com \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=sugar.zhang@rock-chips.com \
--cc=wens@csie.org \
--cc=zhengsq@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.