All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
To: dri-devel@lists.freedesktop.org
Cc: linux-renesas-soc@vger.kernel.org,
	Kieran Bingham <kieran.bingham@ideasonboard.com>,
	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Subject: [PATCH 0/9] drm: rcar-du: Fix LVDS-related crash
Date: Sat,  5 Dec 2020 00:01:30 +0200	[thread overview]
Message-ID: <20201204220139.15272-1-laurent.pinchart+renesas@ideasonboard.com> (raw)

Hello,

This patch series fixes a crash in the LVDS encoder on D3 and E3 SoCs.
See patch 1/9 for details. The next patches are additional cleanups.

Patches 4/9 to 6/9 fix incorrect usage of the devm_* API. They could be
made simpler by using the proposed drmm_* allocators for encoders and
planes ([1]), but those haven't landed yet. Not depending on them also
helps backporting those fixes to stable kernels. I will switch to the
new helpers when they will be available.

[1] https://lore.kernel.org/dri-devel/20200911135724.25833-1-p.zabel@pengutronix.de/

Laurent Pinchart (9):
  drm: rcar-du: Fix crash when using LVDS1 clock for CRTC
  drm: rcar-du: Release vsp device reference in all error paths
  drm: rcar-du: Drop unneeded encoder cleanup in error path
  drm: rcar-du: Use DRM-managed allocation for VSP planes
  drm: rcar-du: Use DRM-managed allocation for encoders
  drm: rcar-du: Embed drm_device in rcar_du_device
  drm: rcar-du: Replace dev_private with container_of
  drm: rcar-du: Skip encoder allocation for LVDS1 in dual-link mode
  drm: rcar-du: Drop local encoder variable

 drivers/gpu/drm/rcar-du/rcar_du_crtc.c      | 12 +--
 drivers/gpu/drm/rcar-du/rcar_du_drv.c       | 33 +++----
 drivers/gpu/drm/rcar-du/rcar_du_drv.h       | 13 ++-
 drivers/gpu/drm/rcar-du/rcar_du_encoder.c   | 95 +++++++++++----------
 drivers/gpu/drm/rcar-du/rcar_du_encoder.h   |  2 -
 drivers/gpu/drm/rcar-du/rcar_du_kms.c       | 12 +--
 drivers/gpu/drm/rcar-du/rcar_du_plane.c     |  8 +-
 drivers/gpu/drm/rcar-du/rcar_du_vsp.c       | 28 ++++--
 drivers/gpu/drm/rcar-du/rcar_du_writeback.c |  2 +-
 9 files changed, 107 insertions(+), 98 deletions(-)

-- 
Regards,

Laurent Pinchart


WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
To: dri-devel@lists.freedesktop.org
Cc: linux-renesas-soc@vger.kernel.org,
	Kieran Bingham <kieran.bingham@ideasonboard.com>,
	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Subject: [PATCH 0/9] drm: rcar-du: Fix LVDS-related crash
Date: Sat,  5 Dec 2020 00:01:30 +0200	[thread overview]
Message-ID: <20201204220139.15272-1-laurent.pinchart+renesas@ideasonboard.com> (raw)

Hello,

This patch series fixes a crash in the LVDS encoder on D3 and E3 SoCs.
See patch 1/9 for details. The next patches are additional cleanups.

Patches 4/9 to 6/9 fix incorrect usage of the devm_* API. They could be
made simpler by using the proposed drmm_* allocators for encoders and
planes ([1]), but those haven't landed yet. Not depending on them also
helps backporting those fixes to stable kernels. I will switch to the
new helpers when they will be available.

[1] https://lore.kernel.org/dri-devel/20200911135724.25833-1-p.zabel@pengutronix.de/

Laurent Pinchart (9):
  drm: rcar-du: Fix crash when using LVDS1 clock for CRTC
  drm: rcar-du: Release vsp device reference in all error paths
  drm: rcar-du: Drop unneeded encoder cleanup in error path
  drm: rcar-du: Use DRM-managed allocation for VSP planes
  drm: rcar-du: Use DRM-managed allocation for encoders
  drm: rcar-du: Embed drm_device in rcar_du_device
  drm: rcar-du: Replace dev_private with container_of
  drm: rcar-du: Skip encoder allocation for LVDS1 in dual-link mode
  drm: rcar-du: Drop local encoder variable

 drivers/gpu/drm/rcar-du/rcar_du_crtc.c      | 12 +--
 drivers/gpu/drm/rcar-du/rcar_du_drv.c       | 33 +++----
 drivers/gpu/drm/rcar-du/rcar_du_drv.h       | 13 ++-
 drivers/gpu/drm/rcar-du/rcar_du_encoder.c   | 95 +++++++++++----------
 drivers/gpu/drm/rcar-du/rcar_du_encoder.h   |  2 -
 drivers/gpu/drm/rcar-du/rcar_du_kms.c       | 12 +--
 drivers/gpu/drm/rcar-du/rcar_du_plane.c     |  8 +-
 drivers/gpu/drm/rcar-du/rcar_du_vsp.c       | 28 ++++--
 drivers/gpu/drm/rcar-du/rcar_du_writeback.c |  2 +-
 9 files changed, 107 insertions(+), 98 deletions(-)

-- 
Regards,

Laurent Pinchart

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

             reply	other threads:[~2020-12-04 22:02 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-04 22:01 Laurent Pinchart [this message]
2020-12-04 22:01 ` [PATCH 0/9] drm: rcar-du: Fix LVDS-related crash Laurent Pinchart
2020-12-04 22:01 ` [PATCH 1/9] drm: rcar-du: Fix crash when using LVDS1 clock for CRTC Laurent Pinchart
2020-12-04 22:01   ` Laurent Pinchart
2020-12-07  8:15   ` Geert Uytterhoeven
2020-12-07  8:15     ` Geert Uytterhoeven
2020-12-08  0:42     ` Laurent Pinchart
2020-12-08  0:42       ` Laurent Pinchart
2020-12-14  9:43   ` Jacopo Mondi
2020-12-14  9:43     ` Jacopo Mondi
2020-12-14 15:36   ` Kieran Bingham
2020-12-14 15:36     ` Kieran Bingham
2020-12-04 22:01 ` [PATCH 2/9] drm: rcar-du: Release vsp device reference in all error paths Laurent Pinchart
2020-12-04 22:01   ` Laurent Pinchart
2020-12-14 10:03   ` Jacopo Mondi
2020-12-14 10:03     ` Jacopo Mondi
2020-12-14 15:42   ` Kieran Bingham
2020-12-14 15:42     ` Kieran Bingham
2020-12-04 22:01 ` [PATCH 3/9] drm: rcar-du: Drop unneeded encoder cleanup in error path Laurent Pinchart
2020-12-04 22:01   ` Laurent Pinchart
2020-12-14 10:11   ` Jacopo Mondi
2020-12-14 10:11     ` Jacopo Mondi
2020-12-14 13:19     ` Laurent Pinchart
2020-12-14 13:19       ` Laurent Pinchart
2020-12-14 15:59   ` Kieran Bingham
2020-12-14 15:59     ` Kieran Bingham
2020-12-04 22:01 ` [PATCH 4/9] drm: rcar-du: Use DRM-managed allocation for VSP planes Laurent Pinchart
2020-12-04 22:01   ` Laurent Pinchart
2020-12-14 16:20   ` Kieran Bingham
2020-12-14 16:20     ` Kieran Bingham
2020-12-14 16:26     ` Laurent Pinchart
2020-12-14 16:26       ` Laurent Pinchart
2020-12-15 15:42       ` Geert Uytterhoeven
2020-12-15 15:42         ` Geert Uytterhoeven
2020-12-04 22:01 ` [PATCH 5/9] drm: rcar-du: Use DRM-managed allocation for encoders Laurent Pinchart
2020-12-04 22:01   ` Laurent Pinchart
2020-12-14 10:37   ` Jacopo Mondi
2020-12-14 10:37     ` Jacopo Mondi
2020-12-14 13:28     ` Laurent Pinchart
2020-12-14 13:28       ` Laurent Pinchart
2020-12-04 22:01 ` [PATCH 6/9] drm: rcar-du: Embed drm_device in rcar_du_device Laurent Pinchart
2020-12-04 22:01   ` Laurent Pinchart
2020-12-14 10:55   ` Jacopo Mondi
2020-12-14 10:55     ` Jacopo Mondi
2020-12-14 17:02   ` Kieran Bingham
2020-12-14 17:02     ` Kieran Bingham
2020-12-04 22:01 ` [PATCH 7/9] drm: rcar-du: Replace dev_private with container_of Laurent Pinchart
2020-12-04 22:01   ` Laurent Pinchart
2020-12-14 10:58   ` Jacopo Mondi
2020-12-14 10:58     ` Jacopo Mondi
2020-12-14 17:11     ` Kieran Bingham
2020-12-14 17:11       ` Kieran Bingham
2020-12-04 22:01 ` [PATCH 8/9] drm: rcar-du: Skip encoder allocation for LVDS1 in dual-link mode Laurent Pinchart
2020-12-04 22:01   ` Laurent Pinchart
2020-12-14 11:04   ` Jacopo Mondi
2020-12-14 11:04     ` Jacopo Mondi
2020-12-14 13:32     ` Laurent Pinchart
2020-12-14 13:32       ` Laurent Pinchart
2020-12-14 17:21   ` Kieran Bingham
2020-12-14 17:21     ` Kieran Bingham
2020-12-04 22:01 ` [PATCH 9/9] drm: rcar-du: Drop local encoder variable Laurent Pinchart
2020-12-04 22:01   ` Laurent Pinchart
2020-12-14 11:05   ` Jacopo Mondi
2020-12-14 11:05     ` Jacopo Mondi
2020-12-14 17:16   ` Kieran Bingham
2020-12-14 17:16     ` Kieran Bingham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201204220139.15272-1-laurent.pinchart+renesas@ideasonboard.com \
    --to=laurent.pinchart+renesas@ideasonboard.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kieran.bingham@ideasonboard.com \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=linux-renesas-soc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.