From: "Rafał Miłecki" <zajec5@gmail.com> To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>, Rob Herring <robh+dt@kernel.org> Cc: "Bjorn Helgaas" <bhelgaas@google.com>, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, "Florian Fainelli" <f.fainelli@gmail.com>, "Nicolas Saenz Julienne" <nsaenzjulienne@suse.de>, "Philipp Zabel" <p.zabel@pengutronix.de>, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, "Rafał Miłecki" <rafal@milecki.pl> Subject: [PATCH v3 1/2] dt-bindings: PCI: brcmstb: add BCM4908 binding Date: Thu, 10 Dec 2020 19:04:20 +0100 [thread overview] Message-ID: <20201210180421.7230-2-zajec5@gmail.com> (raw) In-Reply-To: <20201210180421.7230-1-zajec5@gmail.com> From: Rafał Miłecki <rafal@milecki.pl> BCM4908 is a SoC family with PCIe controller sharing design with the one for STB. BCM4908 has different power management and memory controller so few tweaks are required. PERST# signal on BCM4908 is handled by an external MISC block so it needs specifying a reset phandle. Signed-off-by: Rafał Miłecki <rafal@milecki.pl> Acked-by: Florian Fainelli <f.fainelli@gmail.com> --- V3: Drop "reset-names" from the generic "properties" - it's now defined as "compatible" specific property Drop "$ref" from the "resets" - thanks Rob. --- .../bindings/pci/brcm,stb-pcie.yaml | 37 ++++++++++++++----- 1 file changed, 28 insertions(+), 9 deletions(-) diff --git a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml index 807694b4f41f..f90557f6deb8 100644 --- a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml +++ b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml @@ -14,6 +14,7 @@ properties: items: - enum: - brcm,bcm2711-pcie # The Raspberry Pi 4 + - brcm,bcm4908-pcie - brcm,bcm7211-pcie # Broadcom STB version of RPi4 - brcm,bcm7278-pcie # Broadcom 7278 Arm - brcm,bcm7216-pcie # Broadcom 7216 Arm @@ -63,15 +64,6 @@ properties: aspm-no-l0s: true - resets: - description: for "brcm,bcm7216-pcie", must be a valid reset - phandle pointing to the RESCAL reset controller provider node. - $ref: "/schemas/types.yaml#/definitions/phandle" - - reset-names: - items: - - const: rescal - brcm,scb-sizes: description: u64 giving the 64bit PCIe memory viewport size of a memory controller. There may be up to @@ -98,12 +90,39 @@ required: allOf: - $ref: /schemas/pci/pci-bus.yaml# + - if: + properties: + compatible: + contains: + const: brcm,bcm4908-pcie + then: + properties: + resets: + items: + - description: reset controller handling the PERST# signal + + reset-names: + items: + - const: perst + + required: + - resets + - reset-names - if: properties: compatible: contains: const: brcm,bcm7216-pcie then: + properties: + resets: + items: + - description: phandle pointing to the RESCAL reset controller + + reset-names: + items: + - const: rescal + required: - resets - reset-names -- 2.26.2
WARNING: multiple messages have this Message-ID (diff)
From: "Rafał Miłecki" <zajec5@gmail.com> To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>, Rob Herring <robh+dt@kernel.org> Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, "Florian Fainelli" <f.fainelli@gmail.com>, linux-pci@vger.kernel.org, "Rafał Miłecki" <rafal@milecki.pl>, bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, "Philipp Zabel" <p.zabel@pengutronix.de>, "Bjorn Helgaas" <bhelgaas@google.com>, "Nicolas Saenz Julienne" <nsaenzjulienne@suse.de> Subject: [PATCH v3 1/2] dt-bindings: PCI: brcmstb: add BCM4908 binding Date: Thu, 10 Dec 2020 19:04:20 +0100 [thread overview] Message-ID: <20201210180421.7230-2-zajec5@gmail.com> (raw) In-Reply-To: <20201210180421.7230-1-zajec5@gmail.com> From: Rafał Miłecki <rafal@milecki.pl> BCM4908 is a SoC family with PCIe controller sharing design with the one for STB. BCM4908 has different power management and memory controller so few tweaks are required. PERST# signal on BCM4908 is handled by an external MISC block so it needs specifying a reset phandle. Signed-off-by: Rafał Miłecki <rafal@milecki.pl> Acked-by: Florian Fainelli <f.fainelli@gmail.com> --- V3: Drop "reset-names" from the generic "properties" - it's now defined as "compatible" specific property Drop "$ref" from the "resets" - thanks Rob. --- .../bindings/pci/brcm,stb-pcie.yaml | 37 ++++++++++++++----- 1 file changed, 28 insertions(+), 9 deletions(-) diff --git a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml index 807694b4f41f..f90557f6deb8 100644 --- a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml +++ b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml @@ -14,6 +14,7 @@ properties: items: - enum: - brcm,bcm2711-pcie # The Raspberry Pi 4 + - brcm,bcm4908-pcie - brcm,bcm7211-pcie # Broadcom STB version of RPi4 - brcm,bcm7278-pcie # Broadcom 7278 Arm - brcm,bcm7216-pcie # Broadcom 7216 Arm @@ -63,15 +64,6 @@ properties: aspm-no-l0s: true - resets: - description: for "brcm,bcm7216-pcie", must be a valid reset - phandle pointing to the RESCAL reset controller provider node. - $ref: "/schemas/types.yaml#/definitions/phandle" - - reset-names: - items: - - const: rescal - brcm,scb-sizes: description: u64 giving the 64bit PCIe memory viewport size of a memory controller. There may be up to @@ -98,12 +90,39 @@ required: allOf: - $ref: /schemas/pci/pci-bus.yaml# + - if: + properties: + compatible: + contains: + const: brcm,bcm4908-pcie + then: + properties: + resets: + items: + - description: reset controller handling the PERST# signal + + reset-names: + items: + - const: perst + + required: + - resets + - reset-names - if: properties: compatible: contains: const: brcm,bcm7216-pcie then: + properties: + resets: + items: + - description: phandle pointing to the RESCAL reset controller + + reset-names: + items: + - const: rescal + required: - resets - reset-names -- 2.26.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-12-10 18:05 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-12-10 18:04 [PATCH v3 0/2] brcmstb: initial work on BCM4908 Rafał Miłecki 2020-12-10 18:04 ` Rafał Miłecki 2020-12-10 18:04 ` Rafał Miłecki [this message] 2020-12-10 18:04 ` [PATCH v3 1/2] dt-bindings: PCI: brcmstb: add BCM4908 binding Rafał Miłecki 2020-12-11 3:56 ` Rob Herring 2020-12-11 3:56 ` Rob Herring 2020-12-10 18:04 ` [PATCH v3 2/2] PCI: brcmstb: support BCM4908 with external PERST# signal controller Rafał Miłecki 2020-12-10 18:04 ` Rafał Miłecki 2021-01-19 11:59 ` [PATCH v3 0/2] brcmstb: initial work on BCM4908 Lorenzo Pieralisi 2021-01-19 11:59 ` Lorenzo Pieralisi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201210180421.7230-2-zajec5@gmail.com \ --to=zajec5@gmail.com \ --cc=bcm-kernel-feedback-list@broadcom.com \ --cc=bhelgaas@google.com \ --cc=devicetree@vger.kernel.org \ --cc=f.fainelli@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-pci@vger.kernel.org \ --cc=linux-rpi-kernel@lists.infradead.org \ --cc=lorenzo.pieralisi@arm.com \ --cc=nsaenzjulienne@suse.de \ --cc=p.zabel@pengutronix.de \ --cc=rafal@milecki.pl \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.