All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Lee Jones <lee.jones@linaro.org>,
	Chanwoo Choi <cw00.choi@samsung.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
	Sylwester Nawrocki <snawrocki@kernel.org>
Subject: [PATCH 9/9] mfd: sec-irq: Do not enforce (incorrect) interrupt trigger type
Date: Thu, 10 Dec 2020 22:29:03 +0100	[thread overview]
Message-ID: <20201210212903.216728-9-krzk@kernel.org> (raw)
In-Reply-To: <20201210212903.216728-1-krzk@kernel.org>

Interrupt line can be configured on different hardware in different way,
even inverted.  Therefore driver should not enforce specific trigger
type - edge falling - but instead rely on Devicetree to configure it.

The Samsung PMIC drivers are used only on Devicetree boards.

Additionally, the PMIC datasheets describe the interrupt line as active
low with a requirement of acknowledge from the CPU therefore the edge
falling is not correct.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

---

This patch should wait till DTS changes are merged, as it relies on
proper Devicetree.
---
 drivers/mfd/sec-irq.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/mfd/sec-irq.c b/drivers/mfd/sec-irq.c
index a98c5d165039..760f88a865ab 100644
--- a/drivers/mfd/sec-irq.c
+++ b/drivers/mfd/sec-irq.c
@@ -480,8 +480,7 @@ int sec_irq_init(struct sec_pmic_dev *sec_pmic)
 	}
 
 	ret = devm_regmap_add_irq_chip(sec_pmic->dev, sec_pmic->regmap_pmic,
-				       sec_pmic->irq,
-				       IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
+				       sec_pmic->irq, IRQF_ONESHOT,
 				       sec_pmic->irq_base, sec_irq_chip,
 				       &sec_pmic->irq_data);
 	if (ret != 0) {
-- 
2.25.1


WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Lee Jones <lee.jones@linaro.org>,
	Chanwoo Choi <cw00.choi@samsung.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Sylwester Nawrocki <snawrocki@kernel.org>,
	Marek Szyprowski <m.szyprowski@samsung.com>
Subject: [PATCH 9/9] mfd: sec-irq: Do not enforce (incorrect) interrupt trigger type
Date: Thu, 10 Dec 2020 22:29:03 +0100	[thread overview]
Message-ID: <20201210212903.216728-9-krzk@kernel.org> (raw)
In-Reply-To: <20201210212903.216728-1-krzk@kernel.org>

Interrupt line can be configured on different hardware in different way,
even inverted.  Therefore driver should not enforce specific trigger
type - edge falling - but instead rely on Devicetree to configure it.

The Samsung PMIC drivers are used only on Devicetree boards.

Additionally, the PMIC datasheets describe the interrupt line as active
low with a requirement of acknowledge from the CPU therefore the edge
falling is not correct.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

---

This patch should wait till DTS changes are merged, as it relies on
proper Devicetree.
---
 drivers/mfd/sec-irq.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/mfd/sec-irq.c b/drivers/mfd/sec-irq.c
index a98c5d165039..760f88a865ab 100644
--- a/drivers/mfd/sec-irq.c
+++ b/drivers/mfd/sec-irq.c
@@ -480,8 +480,7 @@ int sec_irq_init(struct sec_pmic_dev *sec_pmic)
 	}
 
 	ret = devm_regmap_add_irq_chip(sec_pmic->dev, sec_pmic->regmap_pmic,
-				       sec_pmic->irq,
-				       IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
+				       sec_pmic->irq, IRQF_ONESHOT,
 				       sec_pmic->irq_base, sec_irq_chip,
 				       &sec_pmic->irq_data);
 	if (ret != 0) {
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2020-12-10 21:31 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20201210212917eucas1p2d0bc9a3099abfc2d2c223facc86be03e@eucas1p2.samsung.com>
2020-12-10 21:28 ` [PATCH 1/9] ARM: dts: exynos: correct PMIC interrupt trigger level on Artik 5 Krzysztof Kozlowski
2020-12-10 21:28   ` Krzysztof Kozlowski
2020-12-10 21:28   ` [PATCH 2/9] ARM: dts: exynos: correct PMIC interrupt trigger level on Monk Krzysztof Kozlowski
2020-12-10 21:28     ` Krzysztof Kozlowski
2020-12-10 21:28   ` [PATCH 3/9] ARM: dts: exynos: correct PMIC interrupt trigger level on Rinato Krzysztof Kozlowski
2020-12-10 21:28     ` Krzysztof Kozlowski
2020-12-11 15:49     ` Marek Szyprowski
2020-12-11 15:49       ` Marek Szyprowski
2020-12-10 21:28   ` [PATCH 4/9] ARM: dts: exynos: correct PMIC interrupt trigger level on Spring Krzysztof Kozlowski
2020-12-10 21:28     ` Krzysztof Kozlowski
2020-12-10 21:28   ` [PATCH 5/9] ARM: dts: exynos: correct PMIC interrupt trigger level on Arndale Octa Krzysztof Kozlowski
2020-12-10 21:28     ` Krzysztof Kozlowski
2020-12-11 15:51     ` Marek Szyprowski
2020-12-11 15:51       ` Marek Szyprowski
2020-12-10 21:29   ` [PATCH 6/9] ARM: dts: exynos: correct PMIC interrupt trigger level on Odroid XU3 family Krzysztof Kozlowski
2020-12-10 21:29     ` Krzysztof Kozlowski
2020-12-11 15:49     ` Marek Szyprowski
2020-12-11 15:49       ` Marek Szyprowski
2020-12-10 21:29   ` [PATCH 7/9] arm64: dts: exynos: correct PMIC interrupt trigger level on TM2 Krzysztof Kozlowski
2020-12-10 21:29     ` Krzysztof Kozlowski
2020-12-18 12:46     ` Marek Szyprowski
2020-12-18 12:46       ` Marek Szyprowski
2020-12-10 21:29   ` [PATCH 8/9] arm64: dts: exynos: correct PMIC interrupt trigger level on Espresso Krzysztof Kozlowski
2020-12-10 21:29     ` Krzysztof Kozlowski
2020-12-10 21:29   ` Krzysztof Kozlowski [this message]
2020-12-10 21:29     ` [PATCH 9/9] mfd: sec-irq: Do not enforce (incorrect) interrupt trigger type Krzysztof Kozlowski
2020-12-18 13:25     ` Marek Szyprowski
2020-12-18 13:25       ` Marek Szyprowski
2020-12-18 14:22       ` Krzysztof Kozlowski
2020-12-18 14:22         ` Krzysztof Kozlowski
2020-12-21  7:36         ` Marek Szyprowski
2020-12-21  7:36           ` Marek Szyprowski
2020-12-21  7:55           ` Krzysztof Kozlowski
2020-12-21  7:55             ` Krzysztof Kozlowski
2020-12-21  8:25             ` Marek Szyprowski
2020-12-21  8:25               ` Marek Szyprowski
2020-12-11 15:49   ` [PATCH 1/9] ARM: dts: exynos: correct PMIC interrupt trigger level on Artik 5 Marek Szyprowski
2020-12-11 15:49     ` Marek Szyprowski
2020-12-29 15:59   ` Krzysztof Kozlowski
2020-12-29 15:59     ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201210212903.216728-9-krzk@kernel.org \
    --to=krzk@kernel.org \
    --cc=b.zolnierkie@samsung.com \
    --cc=cw00.choi@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=robh+dt@kernel.org \
    --cc=snawrocki@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.