From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: alsa-devel@alsa-project.org,
Adam Brickman <Adam.Brickman@cirrus.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Vlad Karpovich <Vlad.Karpovich@cirrus.com>,
kernel-janitors@vger.kernel.org, Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
patches@opensource.cirrus.com, Luo Meng <luomeng12@huawei.com>,
James Schulman <james.schulman@cirrus.com>,
David Rhodes <david.rhodes@cirrus.com>
Subject: Re: [PATCH] ASoC: wm_adsp: remove "ctl" from list on error in wm_adsp_create_control()
Date: Fri, 11 Dec 2020 09:46:45 +0000 [thread overview]
Message-ID: <20201211094645.GB9673@ediswmail.ad.cirrus.com> (raw)
In-Reply-To: <X9B0keV/02wrx9Xs@mwanda>
On Wed, Dec 09, 2020 at 09:54:09AM +0300, Dan Carpenter wrote:
> The error handling frees "ctl" but it's still on the "dsp->ctl_list"
> list so that could result in a use after free. Remove it from the list
> before returning.
>
> Fixes: 2323736dca72 ("ASoC: wm_adsp: Add basic support for rev 1 firmware file format")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
Good spot there, thanks.
Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Thanks,
Charles
next prev parent reply other threads:[~2020-12-11 9:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-09 6:54 [PATCH] ASoC: wm_adsp: remove "ctl" from list on error in wm_adsp_create_control() Dan Carpenter
2020-12-09 6:54 ` Dan Carpenter
2020-12-11 9:46 ` Charles Keepax [this message]
2020-12-11 17:49 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201211094645.GB9673@ediswmail.ad.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=Adam.Brickman@cirrus.com \
--cc=Vlad.Karpovich@cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=david.rhodes@cirrus.com \
--cc=james.schulman@cirrus.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=luomeng12@huawei.com \
--cc=patches@opensource.cirrus.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.