From: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
To: u.kleine-koenig@pengutronix.de, linux-kernel@vger.kernel.org
Cc: f.fainelli@gmail.com, linux-pwm@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
wahrenst@gmx.net, linux-input@vger.kernel.org,
dmitry.torokhov@gmail.com, gregkh@linuxfoundation.org,
devel@driverdev.osuosl.org, p.zabel@pengutronix.de,
linux-gpio@vger.kernel.org, linus.walleij@linaro.org,
linux-clk@vger.kernel.org, sboyd@kernel.org,
linux-rpi-kernel@lists.infradead.org, bgolaszewski@baylibre.com,
andy.shevchenko@gmail.com,
Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Subject: [PATCH v6 06/11] soc: bcm: raspberrypi-power: Release firmware handle on unbind
Date: Fri, 11 Dec 2020 17:47:55 +0100 [thread overview]
Message-ID: <20201211164801.7838-7-nsaenzjulienne@suse.de> (raw)
In-Reply-To: <20201211164801.7838-1-nsaenzjulienne@suse.de>
Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware
interface when unbinding the device.
Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
---
drivers/soc/bcm/raspberrypi-power.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/bcm/raspberrypi-power.c b/drivers/soc/bcm/raspberrypi-power.c
index 5d1aacdd84ef..068715d6e66d 100644
--- a/drivers/soc/bcm/raspberrypi-power.c
+++ b/drivers/soc/bcm/raspberrypi-power.c
@@ -177,7 +177,7 @@ static int rpi_power_probe(struct platform_device *pdev)
return -ENODEV;
}
- rpi_domains->fw = rpi_firmware_get(fw_np);
+ rpi_domains->fw = devm_rpi_firmware_get(&pdev->dev, fw_np);
of_node_put(fw_np);
if (!rpi_domains->fw)
return -EPROBE_DEFER;
--
2.29.2
WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
To: u.kleine-koenig@pengutronix.de, linux-kernel@vger.kernel.org
Cc: devel@driverdev.osuosl.org, linux-pwm@vger.kernel.org,
f.fainelli@gmail.com, devicetree@vger.kernel.org,
sboyd@kernel.org, gregkh@linuxfoundation.org,
linus.walleij@linaro.org, dmitry.torokhov@gmail.com,
linux-gpio@vger.kernel.org, andy.shevchenko@gmail.com,
bcm-kernel-feedback-list@broadcom.com, wahrenst@gmx.net,
p.zabel@pengutronix.de, linux-input@vger.kernel.org,
Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
bgolaszewski@baylibre.com, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rpi-kernel@lists.infradead.org
Subject: [PATCH v6 06/11] soc: bcm: raspberrypi-power: Release firmware handle on unbind
Date: Fri, 11 Dec 2020 17:47:55 +0100 [thread overview]
Message-ID: <20201211164801.7838-7-nsaenzjulienne@suse.de> (raw)
In-Reply-To: <20201211164801.7838-1-nsaenzjulienne@suse.de>
Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware
interface when unbinding the device.
Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
---
drivers/soc/bcm/raspberrypi-power.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/bcm/raspberrypi-power.c b/drivers/soc/bcm/raspberrypi-power.c
index 5d1aacdd84ef..068715d6e66d 100644
--- a/drivers/soc/bcm/raspberrypi-power.c
+++ b/drivers/soc/bcm/raspberrypi-power.c
@@ -177,7 +177,7 @@ static int rpi_power_probe(struct platform_device *pdev)
return -ENODEV;
}
- rpi_domains->fw = rpi_firmware_get(fw_np);
+ rpi_domains->fw = devm_rpi_firmware_get(&pdev->dev, fw_np);
of_node_put(fw_np);
if (!rpi_domains->fw)
return -EPROBE_DEFER;
--
2.29.2
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
To: u.kleine-koenig@pengutronix.de, linux-kernel@vger.kernel.org
Cc: devel@driverdev.osuosl.org, linux-pwm@vger.kernel.org,
f.fainelli@gmail.com, devicetree@vger.kernel.org,
sboyd@kernel.org, gregkh@linuxfoundation.org,
linus.walleij@linaro.org, dmitry.torokhov@gmail.com,
linux-gpio@vger.kernel.org, andy.shevchenko@gmail.com,
bcm-kernel-feedback-list@broadcom.com, wahrenst@gmx.net,
p.zabel@pengutronix.de, linux-input@vger.kernel.org,
Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
bgolaszewski@baylibre.com, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rpi-kernel@lists.infradead.org
Subject: [PATCH v6 06/11] soc: bcm: raspberrypi-power: Release firmware handle on unbind
Date: Fri, 11 Dec 2020 17:47:55 +0100 [thread overview]
Message-ID: <20201211164801.7838-7-nsaenzjulienne@suse.de> (raw)
In-Reply-To: <20201211164801.7838-1-nsaenzjulienne@suse.de>
Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware
interface when unbinding the device.
Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
---
drivers/soc/bcm/raspberrypi-power.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/bcm/raspberrypi-power.c b/drivers/soc/bcm/raspberrypi-power.c
index 5d1aacdd84ef..068715d6e66d 100644
--- a/drivers/soc/bcm/raspberrypi-power.c
+++ b/drivers/soc/bcm/raspberrypi-power.c
@@ -177,7 +177,7 @@ static int rpi_power_probe(struct platform_device *pdev)
return -ENODEV;
}
- rpi_domains->fw = rpi_firmware_get(fw_np);
+ rpi_domains->fw = devm_rpi_firmware_get(&pdev->dev, fw_np);
of_node_put(fw_np);
if (!rpi_domains->fw)
return -EPROBE_DEFER;
--
2.29.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-12-11 18:01 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-11 16:47 [PATCH v6 00/11] Raspberry Pi PoE HAT fan support Nicolas Saenz Julienne
2020-12-11 16:47 ` Nicolas Saenz Julienne
2020-12-11 16:47 ` Nicolas Saenz Julienne
2020-12-11 16:47 ` [PATCH v6 01/11] firmware: raspberrypi: Keep count of all consumers Nicolas Saenz Julienne
2020-12-11 16:47 ` Nicolas Saenz Julienne
2020-12-11 16:47 ` Nicolas Saenz Julienne
2020-12-13 5:14 ` Stephen Boyd
2020-12-13 5:14 ` Stephen Boyd
2020-12-13 5:14 ` Stephen Boyd
2020-12-16 10:37 ` Bartosz Golaszewski
2020-12-16 10:37 ` Bartosz Golaszewski
2020-12-16 10:37 ` Bartosz Golaszewski
2020-12-11 16:47 ` [PATCH v6 02/11] firmware: raspberrypi: Introduce devm_rpi_firmware_get() Nicolas Saenz Julienne
2020-12-11 16:47 ` Nicolas Saenz Julienne
2020-12-11 16:47 ` Nicolas Saenz Julienne
2020-12-16 10:35 ` Bartosz Golaszewski
2020-12-16 10:35 ` Bartosz Golaszewski
2020-12-16 10:35 ` Bartosz Golaszewski
2020-12-16 10:37 ` Nicolas Saenz Julienne
2020-12-16 10:37 ` Nicolas Saenz Julienne
2020-12-16 10:37 ` Nicolas Saenz Julienne
2020-12-11 16:47 ` [PATCH v6 03/11] clk: bcm: rpi: Release firmware handle on unbind Nicolas Saenz Julienne
2020-12-11 16:47 ` Nicolas Saenz Julienne
2020-12-11 16:47 ` Nicolas Saenz Julienne
2020-12-13 5:12 ` Stephen Boyd
2020-12-13 5:12 ` Stephen Boyd
2020-12-13 5:12 ` Stephen Boyd
2020-12-11 16:47 ` [PATCH v6 04/11] gpio: raspberrypi-exp: " Nicolas Saenz Julienne
2020-12-11 16:47 ` Nicolas Saenz Julienne
2020-12-11 16:47 ` Nicolas Saenz Julienne
2020-12-11 16:47 ` [PATCH v6 05/11] reset: raspberrypi: " Nicolas Saenz Julienne
2020-12-11 16:47 ` Nicolas Saenz Julienne
2020-12-11 16:47 ` Nicolas Saenz Julienne
2020-12-11 16:47 ` Nicolas Saenz Julienne [this message]
2020-12-11 16:47 ` [PATCH v6 06/11] soc: bcm: raspberrypi-power: " Nicolas Saenz Julienne
2020-12-11 16:47 ` Nicolas Saenz Julienne
2020-12-11 16:47 ` [PATCH v6 07/11] staging: vchiq: " Nicolas Saenz Julienne
2020-12-11 16:47 ` Nicolas Saenz Julienne
2020-12-11 16:47 ` Nicolas Saenz Julienne
2020-12-11 16:47 ` [PATCH v6 08/11] input: raspberrypi-ts: Release firmware handle when not needed Nicolas Saenz Julienne
2020-12-11 16:47 ` Nicolas Saenz Julienne
2020-12-11 16:47 ` Nicolas Saenz Julienne
2020-12-11 18:17 ` Florian Fainelli
2020-12-11 18:17 ` Florian Fainelli
2020-12-11 18:17 ` Florian Fainelli
2020-12-11 16:47 ` [PATCH v6 09/11] dt-bindings: pwm: Add binding for RPi firmware PWM bus Nicolas Saenz Julienne
2020-12-11 16:47 ` Nicolas Saenz Julienne
2020-12-11 16:47 ` Nicolas Saenz Julienne
2020-12-11 16:47 ` [PATCH v6 10/11] DO NOT MERGE: ARM: dts: Add RPi's official PoE hat support Nicolas Saenz Julienne
2020-12-11 16:47 ` Nicolas Saenz Julienne
2020-12-11 16:47 ` Nicolas Saenz Julienne
2020-12-11 16:48 ` [PATCH v6 11/11] pwm: Add Raspberry Pi Firmware based PWM bus Nicolas Saenz Julienne
2020-12-11 16:48 ` Nicolas Saenz Julienne
2020-12-11 16:48 ` Nicolas Saenz Julienne
2021-01-12 9:18 ` Uwe Kleine-König
2021-01-12 9:18 ` Uwe Kleine-König
2021-01-12 9:18 ` Uwe Kleine-König
2021-01-14 18:44 ` Nicolas Saenz Julienne
2021-01-14 18:44 ` Nicolas Saenz Julienne
2021-01-14 18:44 ` Nicolas Saenz Julienne
2021-01-11 21:02 ` [PATCH v6 00/11] Raspberry Pi PoE HAT fan support Nicolas Saenz Julienne
2021-01-11 21:02 ` Nicolas Saenz Julienne
2021-01-11 21:02 ` Nicolas Saenz Julienne
2021-01-12 8:52 ` Linus Walleij
2021-01-12 8:52 ` Linus Walleij
2021-01-12 8:52 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201211164801.7838-7-nsaenzjulienne@suse.de \
--to=nsaenzjulienne@suse.de \
--cc=andy.shevchenko@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bgolaszewski@baylibre.com \
--cc=devel@driverdev.osuosl.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=p.zabel@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.