All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
To: dri-devel@lists.freedesktop.org
Cc: linux-renesas-soc@vger.kernel.org,
	Kieran Bingham <kieran.bingham@ideasonboard.com>
Subject: [PATCH v2 2/9] drm: rcar-du: Release vsp device reference in all error paths
Date: Mon, 14 Dec 2020 22:52:01 +0200	[thread overview]
Message-ID: <20201214205208.10248-3-laurent.pinchart+renesas@ideasonboard.com> (raw)
In-Reply-To: <20201214205208.10248-1-laurent.pinchart+renesas@ideasonboard.com>

Use drmm_add_action_or_reset() instead of drmm_add_action() to ensure
the vsp device reference is released in case the function call fails.

Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Reviewed-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
---
 drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/rcar-du/rcar_du_vsp.c b/drivers/gpu/drm/rcar-du/rcar_du_vsp.c
index f6a69aa116e6..4dcb1bfbe201 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_vsp.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_vsp.c
@@ -364,7 +364,7 @@ int rcar_du_vsp_init(struct rcar_du_vsp *vsp, struct device_node *np,
 
 	vsp->vsp = &pdev->dev;
 
-	ret = drmm_add_action(rcdu->ddev, rcar_du_vsp_cleanup, vsp);
+	ret = drmm_add_action_or_reset(rcdu->ddev, rcar_du_vsp_cleanup, vsp);
 	if (ret < 0)
 		return ret;
 
-- 
Regards,

Laurent Pinchart


WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
To: dri-devel@lists.freedesktop.org
Cc: linux-renesas-soc@vger.kernel.org,
	Kieran Bingham <kieran.bingham@ideasonboard.com>
Subject: [PATCH v2 2/9] drm: rcar-du: Release vsp device reference in all error paths
Date: Mon, 14 Dec 2020 22:52:01 +0200	[thread overview]
Message-ID: <20201214205208.10248-3-laurent.pinchart+renesas@ideasonboard.com> (raw)
In-Reply-To: <20201214205208.10248-1-laurent.pinchart+renesas@ideasonboard.com>

Use drmm_add_action_or_reset() instead of drmm_add_action() to ensure
the vsp device reference is released in case the function call fails.

Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Reviewed-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
---
 drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/rcar-du/rcar_du_vsp.c b/drivers/gpu/drm/rcar-du/rcar_du_vsp.c
index f6a69aa116e6..4dcb1bfbe201 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_vsp.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_vsp.c
@@ -364,7 +364,7 @@ int rcar_du_vsp_init(struct rcar_du_vsp *vsp, struct device_node *np,
 
 	vsp->vsp = &pdev->dev;
 
-	ret = drmm_add_action(rcdu->ddev, rcar_du_vsp_cleanup, vsp);
+	ret = drmm_add_action_or_reset(rcdu->ddev, rcar_du_vsp_cleanup, vsp);
 	if (ret < 0)
 		return ret;
 
-- 
Regards,

Laurent Pinchart

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2020-12-14 20:53 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-14 20:51 [PATCH v2 0/9] drm: rcar-du: Fix LVDS-related crash Laurent Pinchart
2020-12-14 20:51 ` Laurent Pinchart
2020-12-14 20:52 ` [PATCH v2 1/9] drm: rcar-du: Fix crash when using LVDS1 clock for CRTC Laurent Pinchart
2020-12-14 20:52   ` Laurent Pinchart
2020-12-14 20:52 ` Laurent Pinchart [this message]
2020-12-14 20:52   ` [PATCH v2 2/9] drm: rcar-du: Release vsp device reference in all error paths Laurent Pinchart
2020-12-14 20:52 ` [PATCH v2 3/9] drm: rcar-du: Drop unneeded encoder cleanup in error path Laurent Pinchart
2020-12-14 20:52   ` Laurent Pinchart
2020-12-14 20:52 ` [PATCH v2 4/9] drm: rcar-du: Use DRM-managed allocation for VSP planes Laurent Pinchart
2020-12-14 20:52   ` Laurent Pinchart
2020-12-15 11:16   ` Jacopo Mondi
2020-12-15 11:16     ` Jacopo Mondi
2020-12-14 20:52 ` [PATCH v2 5/9] drm: rcar-du: Use DRM-managed allocation for encoders Laurent Pinchart
2020-12-14 20:52   ` Laurent Pinchart
2020-12-15 11:15   ` Jacopo Mondi
2020-12-15 11:15     ` Jacopo Mondi
2020-12-21 15:54   ` Kieran Bingham
2020-12-21 15:54     ` Kieran Bingham
2020-12-14 20:52 ` [PATCH v2 6/9] drm: rcar-du: Embed drm_device in rcar_du_device Laurent Pinchart
2020-12-14 20:52   ` Laurent Pinchart
2020-12-14 20:52 ` [PATCH v2 7/9] drm: rcar-du: Replace dev_private with container_of Laurent Pinchart
2020-12-14 20:52   ` Laurent Pinchart
2020-12-14 20:52 ` [PATCH v2 8/9] drm: rcar-du: Skip encoder allocation for LVDS1 in dual-link mode Laurent Pinchart
2020-12-14 20:52   ` Laurent Pinchart
2020-12-14 20:52 ` [PATCH v2 9/9] drm: rcar-du: Drop local encoder variable Laurent Pinchart
2020-12-14 20:52   ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201214205208.10248-3-laurent.pinchart+renesas@ideasonboard.com \
    --to=laurent.pinchart+renesas@ideasonboard.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kieran.bingham@ideasonboard.com \
    --cc=linux-renesas-soc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.