All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Peter Chen <Peter.Chen@nxp.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Alan Stern <stern@rowland.harvard.edu>,
	Felipe Balbi <balbi@kernel.org>,
	Matt Merhar <mattmerhar@protonmail.com>,
	Nicolas Chauvet <kwizart@gmail.com>,
	Peter Geis <pgwipeout@gmail.com>, Ion Agorria <ion@agorria.com>
Cc: linux-tegra@vger.kernel.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH v2 1/8] usb: phy: tegra: Add delay after power up
Date: Thu, 17 Dec 2020 12:40:00 +0300	[thread overview]
Message-ID: <20201217094007.19336-2-digetx@gmail.com> (raw)
In-Reply-To: <20201217094007.19336-1-digetx@gmail.com>

The PHY hardware needs the delay of 2ms after power up, otherwise initial
interrupt may be lost if USB controller is accessed before PHY is settled
down. Previously this issue was masked by implicit delays, but now it pops
up after squashing the older ehci-tegra driver into the ChipIdea driver.

Tested-by: Matt Merhar <mattmerhar@protonmail.com>
Tested-by: Nicolas Chauvet <kwizart@gmail.com>
Tested-by: Peter Geis <pgwipeout@gmail.com>
Tested-by: Ion Agorria <ion@agorria.com>
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 drivers/usb/phy/phy-tegra-usb.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/usb/phy/phy-tegra-usb.c b/drivers/usb/phy/phy-tegra-usb.c
index 03a333797382..1296524e1bee 100644
--- a/drivers/usb/phy/phy-tegra-usb.c
+++ b/drivers/usb/phy/phy-tegra-usb.c
@@ -784,6 +784,9 @@ static int tegra_usb_phy_power_on(struct tegra_usb_phy *phy)
 
 	phy->powered_on = true;
 
+	/* Let PHY settle down */
+	usleep_range(2000, 2500);
+
 	return 0;
 }
 
-- 
2.29.2


  reply	other threads:[~2020-12-17  9:46 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-17  9:39 [PATCH v2 0/8] Support Runtime PM and host mode by Tegra ChipIdea USB driver Dmitry Osipenko
2020-12-17  9:40 ` Dmitry Osipenko [this message]
2020-12-17 13:25   ` [PATCH v2 1/8] usb: phy: tegra: Add delay after power up Thierry Reding
2020-12-17  9:40 ` [PATCH v2 2/8] usb: phy: tegra: Support waking up from a low power mode Dmitry Osipenko
2020-12-17 13:33   ` Thierry Reding
2020-12-17 13:47     ` Dmitry Osipenko
2020-12-17 15:04       ` Thierry Reding
2020-12-17  9:40 ` [PATCH v2 3/8] usb: chipidea: tegra: Remove MODULE_ALIAS Dmitry Osipenko
2020-12-17  9:40 ` [PATCH v2 4/8] usb: chipidea: tegra: Rename UDC to USB Dmitry Osipenko
2020-12-17 13:36   ` Thierry Reding
2020-12-17 14:00     ` Dmitry Osipenko
2020-12-17  9:40 ` [PATCH v2 5/8] usb: chipidea: tegra: Support host mode Dmitry Osipenko
2020-12-17 13:40   ` Thierry Reding
2020-12-17  9:40 ` [PATCH v2 6/8] usb: chipidea: tegra: Support runtime PM Dmitry Osipenko
2020-12-17 13:41   ` Thierry Reding
2020-12-17 13:45     ` Dmitry Osipenko
2020-12-17 15:02       ` Thierry Reding
2020-12-17 19:51         ` Dmitry Osipenko
2020-12-17 15:02   ` Thierry Reding
2020-12-17  9:40 ` [PATCH v2 7/8] usb: host: ehci-tegra: Remove the driver Dmitry Osipenko
2020-12-17 13:42   ` Thierry Reding
2020-12-17 15:50   ` Alan Stern
2020-12-17 19:43     ` Dmitry Osipenko
2020-12-17  9:40 ` [PATCH v2 8/8] ARM: tegra_defconfig: Enable USB_CHIPIDEA and remove USB_EHCI_TEGRA Dmitry Osipenko
2020-12-17 13:45   ` Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201217094007.19336-2-digetx@gmail.com \
    --to=digetx@gmail.com \
    --cc=Peter.Chen@nxp.com \
    --cc=balbi@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=ion@agorria.com \
    --cc=jonathanh@nvidia.com \
    --cc=kwizart@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mattmerhar@protonmail.com \
    --cc=pgwipeout@gmail.com \
    --cc=stern@rowland.harvard.edu \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.