All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jari Hämäläinen" <nuumiofi@gmail.com>
To: Shawn Lin <shawn.lin@rock-chips.com>, Heiko Stuebner <heiko@sntech.de>
Cc: "Jari Hämäläinen" <nuumiofi@gmail.com>,
	linux-pci@vger.kernel.org, linux-rockchip@lists.infradead.org,
	"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
	"Rob Herring" <robh@kernel.org>,
	"Bjorn Helgaas" <bhelgaas@google.com>
Subject: [RFC PATCH 3/3] arm64: dts: rockchip: use bus-scan-delay-ms workaround with RockPro64 PCIe
Date: Thu, 31 Dec 2020 14:52:14 +0200	[thread overview]
Message-ID: <20201231125214.25733-4-nuumiofi@gmail.com> (raw)
In-Reply-To: <20201231125214.25733-1-nuumiofi@gmail.com>

Add delay before RockPro64 PCIe bus scan as a workaround for some devices
causing a crash like many LSI SAS controller based RAID controllers and
host bus adapters.

As a side effect this slows down system startup by the amount of delay
even with devices that don't need the delay to work.

Signed-off-by: Jari Hämäläinen <nuumiofi@gmail.com>
---
 arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi
index 6e553ff47534..256c357c069e 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi
@@ -546,6 +546,7 @@ &pcie0 {
 	num-lanes = <4>;
 	pinctrl-names = "default";
 	pinctrl-0 = <&pcie_perst>;
+	rockchip,bus-scan-delay-ms = <1100>;
 	vpcie12v-supply = <&vcc12v_dcin>;
 	vpcie3v3-supply = <&vcc3v3_pcie>;
 	status = "okay";
-- 
2.29.2


WARNING: multiple messages have this Message-ID (diff)
From: "Jari Hämäläinen" <nuumiofi@gmail.com>
To: Shawn Lin <shawn.lin@rock-chips.com>, Heiko Stuebner <heiko@sntech.de>
Cc: "Rob Herring" <robh@kernel.org>,
	"Jari Hämäläinen" <nuumiofi@gmail.com>,
	linux-pci@vger.kernel.org, linux-rockchip@lists.infradead.org,
	"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
	"Bjorn Helgaas" <bhelgaas@google.com>
Subject: [RFC PATCH 3/3] arm64: dts: rockchip: use bus-scan-delay-ms workaround with RockPro64 PCIe
Date: Thu, 31 Dec 2020 14:52:14 +0200	[thread overview]
Message-ID: <20201231125214.25733-4-nuumiofi@gmail.com> (raw)
In-Reply-To: <20201231125214.25733-1-nuumiofi@gmail.com>

Add delay before RockPro64 PCIe bus scan as a workaround for some devices
causing a crash like many LSI SAS controller based RAID controllers and
host bus adapters.

As a side effect this slows down system startup by the amount of delay
even with devices that don't need the delay to work.

Signed-off-by: Jari Hämäläinen <nuumiofi@gmail.com>
---
 arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi
index 6e553ff47534..256c357c069e 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi
@@ -546,6 +546,7 @@ &pcie0 {
 	num-lanes = <4>;
 	pinctrl-names = "default";
 	pinctrl-0 = <&pcie_perst>;
+	rockchip,bus-scan-delay-ms = <1100>;
 	vpcie12v-supply = <&vcc12v_dcin>;
 	vpcie3v3-supply = <&vcc3v3_pcie>;
 	status = "okay";
-- 
2.29.2


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  parent reply	other threads:[~2020-12-31 12:57 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-31 12:52 [RFC PATCH 0/3] provide workaround for Rockchip PCIe bus scan crash with optional delay Jari Hämäläinen
2020-12-31 12:52 ` Jari Hämäläinen
2020-12-31 12:52 ` [RFC PATCH 1/3] PCI: rockchip: provide workaround for " Jari Hämäläinen
2020-12-31 12:52   ` Jari Hämäläinen
2021-01-01 17:37   ` Bjorn Helgaas
2021-01-01 17:37     ` Bjorn Helgaas
2021-01-02 13:43     ` Jari Hämäläinen
2021-01-02 13:43       ` Jari Hämäläinen
2021-01-24  6:39       ` Jari Hämäläinen
2021-01-24  6:39         ` Jari Hämäläinen
2021-01-25 18:08         ` Robin Murphy
2021-01-25 18:08           ` Robin Murphy
2020-12-31 12:52 ` [RFC PATCH 2/3] dt-bindings: PCI: rockchip: document bus-scan-delay-ms workaround property Jari Hämäläinen
2020-12-31 12:52   ` Jari Hämäläinen
2020-12-31 12:52 ` Jari Hämäläinen [this message]
2020-12-31 12:52   ` [RFC PATCH 3/3] arm64: dts: rockchip: use bus-scan-delay-ms workaround with RockPro64 PCIe Jari Hämäläinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201231125214.25733-4-nuumiofi@gmail.com \
    --to=nuumiofi@gmail.com \
    --cc=bhelgaas@google.com \
    --cc=heiko@sntech.de \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=robh@kernel.org \
    --cc=shawn.lin@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.