From: "Jari Hämäläinen" <nuumiofi@gmail.com>
To: Rob Herring <robh+dt@kernel.org>, Heiko Stuebner <heiko@sntech.de>
Cc: "Tobias Schramm" <t.schramm@manjaro.org>,
devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org,
"Jari Hämäläinen" <nuumiofi@gmail.com>
Subject: [RFC PATCH] arm64: dts: rockchip: remove unused bus-scan-delay-ms from Pinebook Pro
Date: Fri, 1 Jan 2021 17:18:45 +0200 [thread overview]
Message-ID: <20210101151845.766986-1-nuumiofi@gmail.com> (raw)
bus-scan-delay-ms property is not used anywhere in the code. This was found
while preparing a workaround patch using equally named property for
RockPro64 [1] which uses the same RK3399 SoC as Pinebook Pro.
bus-scan-delay-ms might have been picked to Pinebook Pro DT from my earlier
patches for RockPro64 custom kernels like [2] or [3].
[1] https://lore.kernel.org/r/20201231125214.25733-1-nuumiofi@gmail.com
[2] https://github.com/nuumio/linux-kernel/commit/710570b8ad809bf3f162f8326
[3] https://github.com/nuumio/rp64-linux-mainline-kernel/commit/2bfc7d397f3
Signed-off-by: Jari Hämäläinen <nuumiofi@gmail.com>
---
Hello all,
Sending this as RFC because I don't have Pinebook Pro to test the cleaned
up DT and can only check that the change doesn't break the build. I did not
find any code reference to removed property and believe it has been
accidentally copied over, but there could always be some surpise.
Testing and comments how to proceed are welcome.
arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts
index 06d48338c836..9589646824bf 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts
@@ -788,7 +788,6 @@ &pcie_phy {
};
&pcie0 {
- bus-scan-delay-ms = <1000>;
ep-gpios = <&gpio2 RK_PD4 GPIO_ACTIVE_HIGH>;
max-link-speed = <2>;
num-lanes = <4>;
base-commit: f6e1ea19649216156576aeafa784e3b4cee45549
--
2.29.2
WARNING: multiple messages have this Message-ID (diff)
From: "Jari Hämäläinen" <nuumiofi@gmail.com>
To: Rob Herring <robh+dt@kernel.org>, Heiko Stuebner <heiko@sntech.de>
Cc: devicetree@vger.kernel.org,
"Jari Hämäläinen" <nuumiofi@gmail.com>,
"Tobias Schramm" <t.schramm@manjaro.org>,
linux-rockchip@lists.infradead.org
Subject: [RFC PATCH] arm64: dts: rockchip: remove unused bus-scan-delay-ms from Pinebook Pro
Date: Fri, 1 Jan 2021 17:18:45 +0200 [thread overview]
Message-ID: <20210101151845.766986-1-nuumiofi@gmail.com> (raw)
bus-scan-delay-ms property is not used anywhere in the code. This was found
while preparing a workaround patch using equally named property for
RockPro64 [1] which uses the same RK3399 SoC as Pinebook Pro.
bus-scan-delay-ms might have been picked to Pinebook Pro DT from my earlier
patches for RockPro64 custom kernels like [2] or [3].
[1] https://lore.kernel.org/r/20201231125214.25733-1-nuumiofi@gmail.com
[2] https://github.com/nuumio/linux-kernel/commit/710570b8ad809bf3f162f8326
[3] https://github.com/nuumio/rp64-linux-mainline-kernel/commit/2bfc7d397f3
Signed-off-by: Jari Hämäläinen <nuumiofi@gmail.com>
---
Hello all,
Sending this as RFC because I don't have Pinebook Pro to test the cleaned
up DT and can only check that the change doesn't break the build. I did not
find any code reference to removed property and believe it has been
accidentally copied over, but there could always be some surpise.
Testing and comments how to proceed are welcome.
arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts
index 06d48338c836..9589646824bf 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts
@@ -788,7 +788,6 @@ &pcie_phy {
};
&pcie0 {
- bus-scan-delay-ms = <1000>;
ep-gpios = <&gpio2 RK_PD4 GPIO_ACTIVE_HIGH>;
max-link-speed = <2>;
num-lanes = <4>;
base-commit: f6e1ea19649216156576aeafa784e3b4cee45549
--
2.29.2
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next reply other threads:[~2021-01-01 15:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-01 15:18 Jari Hämäläinen [this message]
2021-01-01 15:18 ` [RFC PATCH] arm64: dts: rockchip: remove unused bus-scan-delay-ms from Pinebook Pro Jari Hämäläinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210101151845.766986-1-nuumiofi@gmail.com \
--to=nuumiofi@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=t.schramm@manjaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.