From: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> To: dri-devel@lists.freedesktop.org Cc: daniel.vetter@ffwll.ch, zhan.liu@amd.com, amd-gfx@lists.freedesktop.org, alexander.deucher@amd.com, nicholas.kazlauskas@amd.com Subject: [PATCH] drm: Check actual format for legacy pageflip. Date: Sat, 2 Jan 2021 15:02:35 +0100 [thread overview] Message-ID: <20210102140235.514039-1-bas@basnieuwenhuizen.nl> (raw) With modifiers one can actually have different format_info structs for the same format, which now matters for AMDGPU since we convert implicit modifiers to explicit modifiers with multiple planes. I checked other drivers and it doesn't look like they end up triggering this case so I think this is safe to relax. Signed-off-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Fixes: 816853f9dc40 ("drm/amd/display: Set new format info for converted metadata.") --- drivers/gpu/drm/drm_plane.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_plane.c b/drivers/gpu/drm/drm_plane.c index e6231947f987..f5085990cfac 100644 --- a/drivers/gpu/drm/drm_plane.c +++ b/drivers/gpu/drm/drm_plane.c @@ -1163,7 +1163,7 @@ int drm_mode_page_flip_ioctl(struct drm_device *dev, if (ret) goto out; - if (old_fb->format != fb->format) { + if (old_fb->format->format != fb->format->format) { DRM_DEBUG_KMS("Page flip is not allowed to change frame buffer format.\n"); ret = -EINVAL; goto out; -- 2.29.2 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> To: dri-devel@lists.freedesktop.org Cc: mario.kleiner.de@gmail.com, daniel.vetter@ffwll.ch, zhan.liu@amd.com, amd-gfx@lists.freedesktop.org, Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>, alexander.deucher@amd.com, nicholas.kazlauskas@amd.com Subject: [PATCH] drm: Check actual format for legacy pageflip. Date: Sat, 2 Jan 2021 15:02:35 +0100 [thread overview] Message-ID: <20210102140235.514039-1-bas@basnieuwenhuizen.nl> (raw) With modifiers one can actually have different format_info structs for the same format, which now matters for AMDGPU since we convert implicit modifiers to explicit modifiers with multiple planes. I checked other drivers and it doesn't look like they end up triggering this case so I think this is safe to relax. Signed-off-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Fixes: 816853f9dc40 ("drm/amd/display: Set new format info for converted metadata.") --- drivers/gpu/drm/drm_plane.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_plane.c b/drivers/gpu/drm/drm_plane.c index e6231947f987..f5085990cfac 100644 --- a/drivers/gpu/drm/drm_plane.c +++ b/drivers/gpu/drm/drm_plane.c @@ -1163,7 +1163,7 @@ int drm_mode_page_flip_ioctl(struct drm_device *dev, if (ret) goto out; - if (old_fb->format != fb->format) { + if (old_fb->format->format != fb->format->format) { DRM_DEBUG_KMS("Page flip is not allowed to change frame buffer format.\n"); ret = -EINVAL; goto out; -- 2.29.2 _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next reply other threads:[~2021-01-02 14:02 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-02 14:02 Bas Nieuwenhuizen [this message] 2021-01-02 14:02 ` [PATCH] drm: Check actual format for legacy pageflip Bas Nieuwenhuizen 2021-01-02 15:31 ` Mario Kleiner 2021-01-02 15:31 ` Mario Kleiner 2021-01-04 18:17 ` Bas Nieuwenhuizen 2021-01-04 18:17 ` Bas Nieuwenhuizen 2021-01-04 20:46 ` Liu, Zhan 2021-01-04 20:46 ` Liu, Zhan 2021-01-06 15:04 ` Liu, Zhan 2021-01-06 15:04 ` Liu, Zhan 2021-01-07 17:21 ` Liu, Zhan 2021-01-07 17:21 ` Liu, Zhan 2021-01-07 17:57 ` Mario Kleiner 2021-01-07 17:57 ` Mario Kleiner 2021-01-07 17:57 ` Daniel Vetter 2021-01-07 17:57 ` Daniel Vetter 2021-01-07 18:00 ` Mario Kleiner 2021-01-07 18:00 ` Mario Kleiner 2021-01-07 18:04 ` Daniel Vetter 2021-01-07 18:04 ` Daniel Vetter 2021-01-07 18:16 ` Mario Kleiner 2021-01-07 18:16 ` Mario Kleiner 2021-01-07 22:51 ` Daniel Vetter 2021-01-07 22:51 ` Daniel Vetter 2021-01-04 10:23 ` Pierre-Eric Pelloux-Prayer 2021-01-04 10:23 ` Pierre-Eric Pelloux-Prayer 2021-01-04 10:30 ` Christian König 2021-01-04 10:30 ` Christian König 2021-01-04 17:21 ` Alex Deucher 2021-01-04 17:21 ` Alex Deucher
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210102140235.514039-1-bas@basnieuwenhuizen.nl \ --to=bas@basnieuwenhuizen.nl \ --cc=alexander.deucher@amd.com \ --cc=amd-gfx@lists.freedesktop.org \ --cc=daniel.vetter@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=nicholas.kazlauskas@amd.com \ --cc=zhan.liu@amd.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.