All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adam Lackorzynski <adam@l4re.org>
To: maz@kernel.org, tglx@linutronix.de
Cc: linux-arm-kernel@lists.infradead.org, linusw@kernel.org,
	kaloz@openwrt.org, khalasa@piap.pl, andrew@lunn.ch,
	gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com,
	linux-gpio@vger.kernel.org, bgolaszewski@baylibre.com
Subject: [PATCH 4/6] irqchip/ixp4xx: Fix return check of __irq_domain_alloc_irqs
Date: Sat,  2 Jan 2021 18:58:57 +0100	[thread overview]
Message-ID: <20210102175859.335447-4-adam@l4re.org> (raw)
In-Reply-To: <20210102175859.335447-1-adam@l4re.org>

0 is not a proper IRQ number and also indicates failure.

Signed-off-by: Adam Lackorzynski <adam@l4re.org>
---
 drivers/irqchip/irq-ixp4xx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-ixp4xx.c b/drivers/irqchip/irq-ixp4xx.c
index 37e0749215c7..54dcffe2309f 100644
--- a/drivers/irqchip/irq-ixp4xx.c
+++ b/drivers/irqchip/irq-ixp4xx.c
@@ -355,7 +355,7 @@ void __init ixp4xx_irq_init(resource_size_t irqbase,
 					      &fwspec,
 					      false,
 					      NULL);
-		if (ret < 0) {
+		if (ret <= 0) {
 			pr_crit("IXP4XX: can not allocate irqs in hierarchy %d\n",
 				ret);
 			return;
-- 
2.30.0.rc2


WARNING: multiple messages have this Message-ID (diff)
From: Adam Lackorzynski <adam@l4re.org>
To: maz@kernel.org, tglx@linutronix.de
Cc: andrew@lunn.ch, bgolaszewski@baylibre.com, linusw@kernel.org,
	linux-gpio@vger.kernel.org, khalasa@piap.pl, kaloz@openwrt.org,
	gregory.clement@bootlin.com,
	linux-arm-kernel@lists.infradead.org,
	sebastian.hesselbarth@gmail.com
Subject: [PATCH 4/6] irqchip/ixp4xx: Fix return check of __irq_domain_alloc_irqs
Date: Sat,  2 Jan 2021 18:58:57 +0100	[thread overview]
Message-ID: <20210102175859.335447-4-adam@l4re.org> (raw)
In-Reply-To: <20210102175859.335447-1-adam@l4re.org>

0 is not a proper IRQ number and also indicates failure.

Signed-off-by: Adam Lackorzynski <adam@l4re.org>
---
 drivers/irqchip/irq-ixp4xx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-ixp4xx.c b/drivers/irqchip/irq-ixp4xx.c
index 37e0749215c7..54dcffe2309f 100644
--- a/drivers/irqchip/irq-ixp4xx.c
+++ b/drivers/irqchip/irq-ixp4xx.c
@@ -355,7 +355,7 @@ void __init ixp4xx_irq_init(resource_size_t irqbase,
 					      &fwspec,
 					      false,
 					      NULL);
-		if (ret < 0) {
+		if (ret <= 0) {
 			pr_crit("IXP4XX: can not allocate irqs in hierarchy %d\n",
 				ret);
 			return;
-- 
2.30.0.rc2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2021-01-02 18:22 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-02 17:58 [PATCH 1/6] irqchip/bcm2836: Fix return check in IPI alloc Adam Lackorzynski
2021-01-02 17:58 ` Adam Lackorzynski
2021-01-02 17:58 ` [PATCH 2/6] irqchip/armada-370-xp: " Adam Lackorzynski
2021-01-02 17:58   ` Adam Lackorzynski
2021-01-02 18:24   ` Andrew Lunn
2021-01-02 18:24     ` Andrew Lunn
2021-01-02 17:58 ` [PATCH 3/6] irqdomain/msi: Fix return check of __irq_domain_alloc_irqs Adam Lackorzynski
2021-01-02 17:58   ` Adam Lackorzynski
2021-01-02 17:58 ` Adam Lackorzynski [this message]
2021-01-02 17:58   ` [PATCH 4/6] irqchip/ixp4xx: " Adam Lackorzynski
2021-01-02 17:58 ` [PATCH 5/6] gpiolib: " Adam Lackorzynski
2021-01-02 17:58   ` Adam Lackorzynski
2021-01-04 13:57   ` Bartosz Golaszewski
2021-01-04 13:57     ` Bartosz Golaszewski
2021-01-04 14:43     ` Adam Lackorzynski
2021-01-04 14:43       ` Adam Lackorzynski
2021-01-04 15:00   ` Andy Shevchenko
2021-01-04 15:00     ` Andy Shevchenko
2021-01-02 17:58 ` [PATCH 6/6] x86/ioapic: " Adam Lackorzynski
2021-01-02 17:58   ` Adam Lackorzynski
2021-01-27 12:03   ` Thomas Gleixner
2021-01-27 12:03     ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210102175859.335447-4-adam@l4re.org \
    --to=adam@l4re.org \
    --cc=andrew@lunn.ch \
    --cc=bgolaszewski@baylibre.com \
    --cc=gregory.clement@bootlin.com \
    --cc=kaloz@openwrt.org \
    --cc=khalasa@piap.pl \
    --cc=linusw@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=sebastian.hesselbarth@gmail.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.