All of lore.kernel.org
 help / color / mirror / Atom feed
From: Muchun Song <songmuchun@bytedance.com>
To: mike.kravetz@oracle.com, akpm@linux-foundation.org
Cc: hillf.zj@alibaba-inc.com, n-horiguchi@ah.jp.nec.com,
	ak@linux.intel.com, yongjun_wei@trendmicro.com.cn,
	mhocko@suse.cz, linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Muchun Song <songmuchun@bytedance.com>
Subject: [PATCH 2/6] hugetlbfs: fix cannot migrate the fallocated HugeTLB page
Date: Mon,  4 Jan 2021 14:58:39 +0800	[thread overview]
Message-ID: <20210104065843.5658-2-songmuchun@bytedance.com> (raw)
In-Reply-To: <20210104065843.5658-1-songmuchun@bytedance.com>

Because we only can isolate a active page via isolate_huge_page()
and hugetlbfs_fallocate() forget to mark it as active, we cannot
isolate and migrate those pages.

Fixes: 70c3547e36f5 (hugetlbfs: add hugetlbfs_fallocate())
Signed-off-by: Muchun Song <songmuchun@bytedance.com>
---
 fs/hugetlbfs/inode.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c
index b5c109703daa..2aceb085d202 100644
--- a/fs/hugetlbfs/inode.c
+++ b/fs/hugetlbfs/inode.c
@@ -737,10 +737,11 @@ static long hugetlbfs_fallocate(struct file *file, int mode, loff_t offset,
 
 		/*
 		 * unlock_page because locked by add_to_page_cache()
-		 * page_put due to reference from alloc_huge_page()
+		 * put_page() (which is in the putback_active_hugepage())
+		 * due to reference from alloc_huge_page()
 		 */
 		unlock_page(page);
-		put_page(page);
+		putback_active_hugepage(page);
 	}
 
 	if (!(mode & FALLOC_FL_KEEP_SIZE) && offset + len > inode->i_size)
-- 
2.11.0


  reply	other threads:[~2021-01-04  7:02 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-04  6:58 [PATCH 1/6] mm: migrate: do not migrate HugeTLB page whose refcount is one Muchun Song
2021-01-04  6:58 ` Muchun Song [this message]
2021-01-04 22:38   ` [PATCH 2/6] hugetlbfs: fix cannot migrate the fallocated HugeTLB page Mike Kravetz
2021-01-05  2:44     ` [External] " Muchun Song
2021-01-05  2:44       ` Muchun Song
2021-01-05 22:27       ` Mike Kravetz
2021-01-06  2:57         ` Muchun Song
2021-01-06  2:57           ` Muchun Song
2021-01-04  6:58 ` [PATCH 3/6] mm: hugetlb: fix a race between freeing and dissolving the page Muchun Song
2021-01-05  0:00   ` Mike Kravetz
2021-01-05  2:55     ` [External] " Muchun Song
2021-01-05  2:55       ` Muchun Song
2021-01-05 23:22       ` Mike Kravetz
2021-01-06  6:05         ` Muchun Song
2021-01-06  6:05           ` Muchun Song
2021-01-05  6:12     ` Muchun Song
2021-01-05  6:12       ` Muchun Song
2021-01-04  6:58 ` [PATCH 4/6] mm: hugetlb: add return -EAGAIN for dissolve_free_huge_page Muchun Song
2021-01-05  1:32   ` Mike Kravetz
2021-01-05  3:14     ` [External] " Muchun Song
2021-01-05  3:14       ` Muchun Song
2021-01-05  3:46       ` Muchun Song
2021-01-05  3:46         ` Muchun Song
2021-01-06  0:07         ` Mike Kravetz
2021-01-05  6:37   ` HORIGUCHI NAOYA(堀口　直也)
2021-01-05  7:10     ` [External] " Muchun Song
2021-01-05  7:10       ` Muchun Song
2021-01-05  7:30       ` HORIGUCHI NAOYA(堀口　直也)
2021-01-04  6:58 ` [PATCH 5/6] mm: hugetlb: fix a race between isolating and freeing page Muchun Song
2021-01-05  1:42   ` Mike Kravetz
2021-01-04  6:58 ` [PATCH 6/6] mm: hugetlb: remove VM_BUG_ON_PAGE from page_huge_active Muchun Song
2021-01-05  1:50   ` Mike Kravetz
2021-01-04 22:17 ` [PATCH 1/6] mm: migrate: do not migrate HugeTLB page whose refcount is one Mike Kravetz
2021-01-05 16:58 ` David Hildenbrand
2021-01-05 18:04   ` Yang Shi
2021-01-05 18:04     ` Yang Shi
2021-01-05 18:05     ` David Hildenbrand
2021-01-05 18:04 ` Yang Shi
2021-01-05 18:04   ` Yang Shi
2021-01-06 16:11 ` Michal Hocko
2021-01-06 16:12   ` Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210104065843.5658-2-songmuchun@bytedance.com \
    --to=songmuchun@bytedance.com \
    --cc=ak@linux.intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=hillf.zj@alibaba-inc.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.cz \
    --cc=mike.kravetz@oracle.com \
    --cc=n-horiguchi@ah.jp.nec.com \
    --cc=yongjun_wei@trendmicro.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.