All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Cédric Le Goater" <clg@kaod.org>
To: linuxppc-dev@lists.ozlabs.org
Cc: "Christophe Leroy" <christophe.leroy@c-s.fr>,
	"Cédric Le Goater" <clg@kaod.org>,
	"Nicholas Piggin" <npiggin@gmail.com>
Subject: [PATCH v2 17/23] powerpc/watchdog: Declare soft_nmi_interrupt() prototype
Date: Mon,  4 Jan 2021 15:32:00 +0100	[thread overview]
Message-ID: <20210104143206.695198-18-clg@kaod.org> (raw)
In-Reply-To: <20210104143206.695198-1-clg@kaod.org>

soft_nmi_interrupt() usage requires PPC_WATCHDOG to be configured.
Check the CONFIG definition to declare the prototype.

It fixes this W=1 compile error :

../arch/powerpc/kernel/watchdog.c:250:6: error: no previous prototype for ‘soft_nmi_interrupt’ [-Werror=missing-prototypes]
  250 | void soft_nmi_interrupt(struct pt_regs *regs)
      |      ^~~~~~~~~~~~~~~~~~

Cc: Nicholas Piggin <npiggin@gmail.com>
Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
 arch/powerpc/include/asm/nmi.h | 1 +
 arch/powerpc/kernel/watchdog.c | 1 +
 2 files changed, 2 insertions(+)

diff --git a/arch/powerpc/include/asm/nmi.h b/arch/powerpc/include/asm/nmi.h
index 84b4cfe73edd..63eccea93796 100644
--- a/arch/powerpc/include/asm/nmi.h
+++ b/arch/powerpc/include/asm/nmi.h
@@ -4,6 +4,7 @@
 
 #ifdef CONFIG_PPC_WATCHDOG
 extern void arch_touch_nmi_watchdog(void);
+void soft_nmi_interrupt(struct pt_regs *regs);
 #else
 static inline void arch_touch_nmi_watchdog(void) {}
 #endif
diff --git a/arch/powerpc/kernel/watchdog.c b/arch/powerpc/kernel/watchdog.c
index af3c15a1d41e..3ae13c2a10cf 100644
--- a/arch/powerpc/kernel/watchdog.c
+++ b/arch/powerpc/kernel/watchdog.c
@@ -27,6 +27,7 @@
 #include <linux/smp.h>
 
 #include <asm/paca.h>
+#include <asm/nmi.h>
 
 /*
  * The powerpc watchdog ensures that each CPU is able to service timers.
-- 
2.26.2


  parent reply	other threads:[~2021-01-04 15:06 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-04 14:31 [PATCH v2 00/23] powerpc: Fix W=1 compile errors Cédric Le Goater
2021-01-04 14:31 ` [PATCH v2 01/23] powerpc/mm: Include __find_linux_pte() prototype Cédric Le Goater
2021-01-04 14:31 ` [PATCH v2 02/23] powerpc/pseries/ras: Remove unused variable 'status' Cédric Le Goater
2021-01-04 14:31 ` [PATCH v2 03/23] powerpc/pseries/eeh: Make pseries_pcibios_bus_add_device() static Cédric Le Goater
2021-01-04 14:31 ` [PATCH v2 04/23] powerpc/pseries/ras: Make init_ras_hotplug_IRQ() static Cédric Le Goater
2021-01-04 14:31 ` [PATCH v2 05/23] powerpc/pmem: Include pmem prototypes Cédric Le Goater
2021-01-04 14:31 ` [PATCH v2 06/23] powerpc/setup_64: Make some routines static Cédric Le Goater
2021-01-04 14:31 ` [PATCH v2 07/23] powerpc/mce: Include prototypes Cédric Le Goater
2021-01-04 14:31 ` [PATCH v2 08/23] powerpc/smp: Include tick_broadcast() prototype Cédric Le Goater
2021-01-04 14:31 ` [PATCH v2 09/23] powerpc/smp: Make debugger_ipi_callback() static Cédric Le Goater
2021-01-04 14:31 ` [PATCH v2 10/23] powerpc/optprobes: Remove unused routine patch_imm32_load_insns() Cédric Le Goater
2021-01-04 14:31 ` [PATCH v2 11/23] powerpc/optprobes: Make patch_imm64_load_insns() static Cédric Le Goater
2021-01-04 14:31 ` [PATCH v2 12/23] powerpc/mm: Declare some prototypes Cédric Le Goater
2021-01-04 14:31 ` [PATCH v2 13/23] powerpc/mm: Move hpte_insert_repeating() prototype Cédric Le Goater
2021-01-04 14:31 ` [PATCH v2 14/23] powerpc/mm: Declare preload_new_slb_context() prototype Cédric Le Goater
2021-01-04 14:31 ` [PATCH v2 15/23] powerpc/mm/hugetlb: Make pseries_alloc_bootmem_huge_page() static Cédric Le Goater
2021-01-04 14:31 ` [PATCH v2 16/23] powerpc/mm: Declare arch_report_meminfo() prototype Cédric Le Goater
2021-01-04 14:32 ` Cédric Le Goater [this message]
2021-01-04 14:32 ` [PATCH v2 18/23] KVM: PPC: Make the VMX instruction emulation routines static Cédric Le Goater
2021-01-04 14:32 ` [PATCH v2 19/23] KVM: PPC: Book3S HV: Include prototypes Cédric Le Goater
2021-01-04 14:32 ` [PATCH v2 20/23] KVM: PPC: Book3S HV: Declare some prototypes Cédric Le Goater
2021-01-04 14:32 ` [PATCH v2 21/23] powerpc/pseries: Make IOV setup routines static Cédric Le Goater
2021-01-04 14:32 ` [PATCH v2 22/23] powerpc/pcidn: " Cédric Le Goater
2021-01-04 14:32 ` [PATCH v2 23/23] powerpc/pseries/eeh: Make pseries_send_allow_unfreeze() static Cédric Le Goater
2021-02-03 11:40 ` [PATCH v2 00/23] powerpc: Fix W=1 compile errors Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210104143206.695198-18-clg@kaod.org \
    --to=clg@kaod.org \
    --cc=christophe.leroy@c-s.fr \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=npiggin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.