From: Eric Biggers <ebiggers@kernel.org> To: linux-fsdevel@vger.kernel.org Cc: linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-xfs@vger.kernel.org, Theodore Ts'o <tytso@mit.edu>, Christoph Hellwig <hch@lst.de> Subject: [PATCH 00/13] lazytime fixes and cleanups Date: Mon, 4 Jan 2021 16:54:39 -0800 [thread overview] Message-ID: <20210105005452.92521-1-ebiggers@kernel.org> (raw) Hello, This patchset fixes the lazytime bug which I reported last year (https://lore.kernel.org/r/20200306004555.GB225345@gmail.com). This bug causes inodes with dirty timestamps to remain dirty after a sync, which causes the inodes to be unnecessarily written again, and also causes the FS_IOC_REMOVE_ENCRYPTION_KEY ioctl to not work properly. This bug is causing xfstest generic/580 to fail when lazytime is enabled. Ted and Christoph proposed fixes for this. Ted's fix (https://lore.kernel.org/r/20200307020043.60118-1-tytso@mit.edu) changed the call to mark_inode_dirty_sync(inode) in __writeback_single_inode() to ->dirty_inode(inode, I_DIRTY_TIME_EXPIRED). However this would have broken XFS, which wants an I_DIRTY_SYNC notification. Also, people preferred a larger rework involving adding a ->lazytime_expired method. Christoph's fix (https://lore.kernel.org/r/20200325122825.1086872-3-hch@lst.de) introduced ->lazytime_expired, but it wasn't correct because it didn't consider cases in which timestamps are force-expired. To resolve this, I propose that we first fix the bug by making __writeback_single_inode() do an I_DIRTY_SYNC notification if the timestamps expired (patch #1). Then, the remaining patches introduce ->lazytime_expired and make XFS use it. They also clean up various things, such as improving comments. Also, it turns out that lazytime on XFS is broken because it doesn't actually write timestamps to disk after a sync() or after 24 hours. This is fixed by the patch to switch XFS to use ->lazytime_expired. I've written an xfstest which reproduces this bug. This patchset applies to v5.11-rc2. Eric Biggers (13): fs: avoid double-writing inodes on lazytime expiration gfs2: don't worry about I_DIRTY_TIME in gfs2_fsync() fs: only specify I_DIRTY_TIME when needed in generic_update_time() fat: only specify I_DIRTY_TIME when needed in fat_update_time() fs: don't call ->dirty_inode for lazytime timestamp updates fs: pass only I_DIRTY_INODE flags to ->dirty_inode fs: correctly document the inode dirty flags ext4: simplify i_state checks in __ext4_update_other_inode_time() fs: drop redundant checks from __writeback_single_inode() fs: clean up __mark_inode_dirty() a bit fs: add a lazytime_expired method xfs: remove a stale comment from xfs_file_aio_write_checks() xfs: implement lazytime_expired Documentation/filesystems/locking.rst | 2 + Documentation/filesystems/vfs.rst | 15 ++++- fs/ext4/inode.c | 20 ++---- fs/f2fs/super.c | 3 - fs/fat/misc.c | 21 +++--- fs/fs-writeback.c | 94 +++++++++++++++++++-------- fs/gfs2/file.c | 4 +- fs/gfs2/super.c | 2 - fs/inode.c | 40 ++++++------ fs/sync.c | 2 +- fs/xfs/xfs_file.c | 6 -- fs/xfs/xfs_super.c | 12 +--- include/linux/fs.h | 25 +++++-- 13 files changed, 143 insertions(+), 103 deletions(-) base-commit: e71ba9452f0b5b2e8dc8aa5445198cd9214a6a62 -- 2.30.0
WARNING: multiple messages have this Message-ID (diff)
From: Eric Biggers <ebiggers@kernel.org> To: linux-fsdevel@vger.kernel.org Cc: linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org, Theodore Ts'o <tytso@mit.edu>, Christoph Hellwig <hch@lst.de>, linux-f2fs-devel@lists.sourceforge.net Subject: [f2fs-dev] [PATCH 00/13] lazytime fixes and cleanups Date: Mon, 4 Jan 2021 16:54:39 -0800 [thread overview] Message-ID: <20210105005452.92521-1-ebiggers@kernel.org> (raw) Hello, This patchset fixes the lazytime bug which I reported last year (https://lore.kernel.org/r/20200306004555.GB225345@gmail.com). This bug causes inodes with dirty timestamps to remain dirty after a sync, which causes the inodes to be unnecessarily written again, and also causes the FS_IOC_REMOVE_ENCRYPTION_KEY ioctl to not work properly. This bug is causing xfstest generic/580 to fail when lazytime is enabled. Ted and Christoph proposed fixes for this. Ted's fix (https://lore.kernel.org/r/20200307020043.60118-1-tytso@mit.edu) changed the call to mark_inode_dirty_sync(inode) in __writeback_single_inode() to ->dirty_inode(inode, I_DIRTY_TIME_EXPIRED). However this would have broken XFS, which wants an I_DIRTY_SYNC notification. Also, people preferred a larger rework involving adding a ->lazytime_expired method. Christoph's fix (https://lore.kernel.org/r/20200325122825.1086872-3-hch@lst.de) introduced ->lazytime_expired, but it wasn't correct because it didn't consider cases in which timestamps are force-expired. To resolve this, I propose that we first fix the bug by making __writeback_single_inode() do an I_DIRTY_SYNC notification if the timestamps expired (patch #1). Then, the remaining patches introduce ->lazytime_expired and make XFS use it. They also clean up various things, such as improving comments. Also, it turns out that lazytime on XFS is broken because it doesn't actually write timestamps to disk after a sync() or after 24 hours. This is fixed by the patch to switch XFS to use ->lazytime_expired. I've written an xfstest which reproduces this bug. This patchset applies to v5.11-rc2. Eric Biggers (13): fs: avoid double-writing inodes on lazytime expiration gfs2: don't worry about I_DIRTY_TIME in gfs2_fsync() fs: only specify I_DIRTY_TIME when needed in generic_update_time() fat: only specify I_DIRTY_TIME when needed in fat_update_time() fs: don't call ->dirty_inode for lazytime timestamp updates fs: pass only I_DIRTY_INODE flags to ->dirty_inode fs: correctly document the inode dirty flags ext4: simplify i_state checks in __ext4_update_other_inode_time() fs: drop redundant checks from __writeback_single_inode() fs: clean up __mark_inode_dirty() a bit fs: add a lazytime_expired method xfs: remove a stale comment from xfs_file_aio_write_checks() xfs: implement lazytime_expired Documentation/filesystems/locking.rst | 2 + Documentation/filesystems/vfs.rst | 15 ++++- fs/ext4/inode.c | 20 ++---- fs/f2fs/super.c | 3 - fs/fat/misc.c | 21 +++--- fs/fs-writeback.c | 94 +++++++++++++++++++-------- fs/gfs2/file.c | 4 +- fs/gfs2/super.c | 2 - fs/inode.c | 40 ++++++------ fs/sync.c | 2 +- fs/xfs/xfs_file.c | 6 -- fs/xfs/xfs_super.c | 12 +--- include/linux/fs.h | 25 +++++-- 13 files changed, 143 insertions(+), 103 deletions(-) base-commit: e71ba9452f0b5b2e8dc8aa5445198cd9214a6a62 -- 2.30.0 _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next reply other threads:[~2021-01-05 0:56 UTC|newest] Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-05 0:54 Eric Biggers [this message] 2021-01-05 0:54 ` [f2fs-dev] [PATCH 00/13] lazytime fixes and cleanups Eric Biggers 2021-01-05 0:54 ` [PATCH 01/13] fs: avoid double-writing inodes on lazytime expiration Eric Biggers 2021-01-05 0:54 ` [f2fs-dev] " Eric Biggers 2021-01-07 14:47 ` Jan Kara 2021-01-07 14:58 ` Matthew Wilcox 2021-01-07 14:58 ` [f2fs-dev] " Matthew Wilcox 2021-01-07 21:46 ` Eric Biggers 2021-01-07 21:46 ` [f2fs-dev] " Eric Biggers 2021-01-08 8:54 ` Christoph Hellwig 2021-01-08 8:54 ` [f2fs-dev] " Christoph Hellwig 2021-01-08 9:01 ` Christoph Hellwig 2021-01-08 9:01 ` [f2fs-dev] " Christoph Hellwig 2021-01-09 17:11 ` Eric Biggers 2021-01-09 17:11 ` [f2fs-dev] " Eric Biggers 2021-01-05 0:54 ` [PATCH 02/13] gfs2: don't worry about I_DIRTY_TIME in gfs2_fsync() Eric Biggers 2021-01-05 0:54 ` [f2fs-dev] " Eric Biggers 2021-01-08 8:54 ` Christoph Hellwig 2021-01-08 8:54 ` [f2fs-dev] " Christoph Hellwig 2021-01-05 0:54 ` [PATCH 03/13] fs: only specify I_DIRTY_TIME when needed in generic_update_time() Eric Biggers 2021-01-05 0:54 ` [f2fs-dev] " Eric Biggers 2021-01-08 8:57 ` Christoph Hellwig 2021-01-08 8:57 ` [f2fs-dev] " Christoph Hellwig 2021-01-05 0:54 ` [PATCH 04/13] fat: only specify I_DIRTY_TIME when needed in fat_update_time() Eric Biggers 2021-01-05 0:54 ` [f2fs-dev] " Eric Biggers 2021-01-07 13:13 ` Jan Kara 2021-01-07 13:13 ` [f2fs-dev] " Jan Kara 2021-01-07 19:10 ` Eric Biggers 2021-01-07 19:10 ` [f2fs-dev] " Eric Biggers 2021-01-05 0:54 ` [PATCH 05/13] fs: don't call ->dirty_inode for lazytime timestamp updates Eric Biggers 2021-01-05 0:54 ` [f2fs-dev] " Eric Biggers 2021-01-07 13:17 ` Jan Kara 2021-01-07 13:17 ` [f2fs-dev] " Jan Kara 2021-01-07 13:18 ` Jan Kara 2021-01-07 13:18 ` [f2fs-dev] " Jan Kara 2021-01-08 9:02 ` Christoph Hellwig 2021-01-08 9:02 ` [f2fs-dev] " Christoph Hellwig 2021-01-05 0:54 ` [PATCH 06/13] fs: pass only I_DIRTY_INODE flags to ->dirty_inode Eric Biggers 2021-01-05 0:54 ` [f2fs-dev] " Eric Biggers 2021-01-08 9:02 ` Christoph Hellwig 2021-01-08 9:02 ` [f2fs-dev] " Christoph Hellwig 2021-01-05 0:54 ` [PATCH 07/13] fs: correctly document the inode dirty flags Eric Biggers 2021-01-05 0:54 ` [f2fs-dev] " Eric Biggers 2021-01-08 9:03 ` Christoph Hellwig 2021-01-08 9:03 ` [f2fs-dev] " Christoph Hellwig 2021-01-05 0:54 ` [PATCH 08/13] ext4: simplify i_state checks in __ext4_update_other_inode_time() Eric Biggers 2021-01-05 0:54 ` [f2fs-dev] " Eric Biggers 2021-01-07 13:24 ` Jan Kara 2021-01-07 13:24 ` [f2fs-dev] " Jan Kara 2021-01-07 19:06 ` Eric Biggers 2021-01-07 19:06 ` [f2fs-dev] " Eric Biggers 2021-01-05 0:54 ` [PATCH 09/13] fs: drop redundant checks from __writeback_single_inode() Eric Biggers 2021-01-05 0:54 ` [f2fs-dev] " Eric Biggers 2021-01-08 9:12 ` Christoph Hellwig 2021-01-08 9:12 ` [f2fs-dev] " Christoph Hellwig 2021-01-05 0:54 ` [PATCH 10/13] fs: clean up __mark_inode_dirty() a bit Eric Biggers 2021-01-05 0:54 ` [f2fs-dev] " Eric Biggers 2021-01-08 9:10 ` Christoph Hellwig 2021-01-08 9:10 ` [f2fs-dev] " Christoph Hellwig 2021-01-05 0:54 ` [PATCH 11/13] fs: add a lazytime_expired method Eric Biggers 2021-01-05 0:54 ` [f2fs-dev] " Eric Biggers 2021-01-07 14:02 ` Jan Kara 2021-01-07 14:02 ` [f2fs-dev] " Jan Kara 2021-01-07 22:05 ` Eric Biggers 2021-01-07 22:05 ` [f2fs-dev] " Eric Biggers 2021-01-08 9:14 ` Christoph Hellwig 2021-01-08 9:14 ` [f2fs-dev] " Christoph Hellwig 2021-01-05 0:54 ` [PATCH 12/13] xfs: remove a stale comment from xfs_file_aio_write_checks() Eric Biggers 2021-01-05 0:54 ` [f2fs-dev] " Eric Biggers 2021-01-08 9:15 ` Christoph Hellwig 2021-01-08 9:15 ` [f2fs-dev] " Christoph Hellwig 2021-01-05 0:54 ` [PATCH 13/13] xfs: implement lazytime_expired Eric Biggers 2021-01-05 0:54 ` [f2fs-dev] " Eric Biggers
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210105005452.92521-1-ebiggers@kernel.org \ --to=ebiggers@kernel.org \ --cc=hch@lst.de \ --cc=linux-ext4@vger.kernel.org \ --cc=linux-f2fs-devel@lists.sourceforge.net \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-xfs@vger.kernel.org \ --cc=tytso@mit.edu \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.