All of lore.kernel.org
 help / color / mirror / Atom feed
From: Su Yue <l@damenly.su>
To: linux-btrfs@vger.kernel.org
Cc: l@damenly.su
Subject: [PATCH] btrfs-progs: print bytenr of child eb if mismatched level found in read_node_slot()
Date: Wed,  6 Jan 2021 18:35:50 +0800	[thread overview]
Message-ID: <20210106103550.1145-1-l@damenly.su> (raw)

If btrfs check reported like "ERROR: child eb corrupted: parent bytenr
=178081 item=246 parent level=1 child level=2". It's hard to find
which eb is corrupted without bytenr in dump tree information:
===================================================================
node 178081 level 1 items 424 free 69 generation 44495 owner EXTENT_TREE
fs uuid 7d9dbe1b-dea6-4141-807b-026325123ad8
chunk uuid 97a3e3aa-7105-4101-aaf7-50204a240e69
        key (16613126144 EXTENT_ITEM 4096) block 177939087360 gen 44433
        key (16632803328 EXTENT_ITEM 4096) block 177939120128 gen 44433
        key (16654548992 EXTENT_ITEM 8192) block 177970380800 gen 44336
        key (16697884672 EXTENT_ITEM 8192) block 177970397184 gen 44336
        key (16714223616 EXTENT_ITEM 16384) block 177970413568 gen 44336
        key (16721760256 EXTENT_ITEM 16384) block 177943855104 gen 44436
        key (16857755648 EXTENT_ITEM 4096) block 177857544192 gen 44416
...

===================================================================

For easier lookup, print bytenr of child eb if its level is not equal
to parent's level - 1 in read_node_slot().

Signed-off-by: Su Yue <l@damenly.su>
---
 kernel-shared/ctree.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/kernel-shared/ctree.c b/kernel-shared/ctree.c
index 01bc33a43c33..4cc3aebc1412 100644
--- a/kernel-shared/ctree.c
+++ b/kernel-shared/ctree.c
@@ -809,9 +809,9 @@ struct extent_buffer *read_node_slot(struct btrfs_fs_info *fs_info,
 
 	if (btrfs_header_level(ret) != level - 1) {
 		error(
-"child eb corrupted: parent bytenr=%llu item=%d parent level=%d child level=%d",
-		      btrfs_header_bytenr(parent), slot,
-		      btrfs_header_level(parent), btrfs_header_level(ret));
+"child eb corrupted: parent bytenr=%llu item=%d parent level=%d child bytenr=%llu child level=%d",
+		      btrfs_header_bytenr(parent), slot, btrfs_header_level(parent),
+		      btrfs_header_bytenr(ret), btrfs_header_level(ret));
 		free_extent_buffer(ret);
 		return ERR_PTR(-EIO);
 	}
-- 
2.30.0


             reply	other threads:[~2021-01-06 10:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-06 10:35 Su Yue [this message]
2021-01-06 11:36 ` [PATCH] btrfs-progs: print bytenr of child eb if mismatched level found in read_node_slot() David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210106103550.1145-1-l@damenly.su \
    --to=l@damenly.su \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.