All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andre Przywara <andre.przywara@arm.com>
To: Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
	Rob Herring <robh@kernel.org>
Cc: Jernej Skrabec <jernej.skrabec@siol.net>,
	Icenowy Zheng <icenowy@aosc.io>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-sunxi@googlegroups.com
Subject: [PATCH 3/7] arm64: dts: allwinner: Drop non-removable from SoPine/LTS SD card
Date: Wed,  6 Jan 2021 15:05:21 +0000	[thread overview]
Message-ID: <20210106150525.15403-4-andre.przywara@arm.com> (raw)
In-Reply-To: <20210106150525.15403-1-andre.przywara@arm.com>

The SD card on the SoPine SoM module is somewhat concealed, so was
originally defined as "non-removable".
However there is a working card-detect pin, and in certain SoM base
boards it might be actually accessible at runtime.
Also the Pine64-LTS shares the SoPine base .dtsi, so inherited the
non-removable flag, even though the SD card slot is perfectly accessible
and usable there. (It turns out that just *my* board has a broken card
detect switch, so I originally thought CD wouldn't work on the LTS.)

Drop the "non-removable" flag to describe the SD card slot properly.

Signed-off-by: Andre Przywara <andre.przywara@arm.com>
---
 arch/arm64/boot/dts/allwinner/sun50i-a64-sopine.dtsi | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine.dtsi
index c48692b06e1f..3402cec87035 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine.dtsi
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine.dtsi
@@ -32,7 +32,6 @@
 	pinctrl-names = "default";
 	pinctrl-0 = <&mmc0_pins>;
 	vmmc-supply = <&reg_dcdc1>;
-	non-removable;
 	disable-wp;
 	bus-width = <4>;
 	cd-gpios = <&pio 5 6 GPIO_ACTIVE_LOW>; /* PF6 */
-- 
2.17.5


WARNING: multiple messages have this Message-ID (diff)
From: Andre Przywara <andre.przywara@arm.com>
To: Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
	Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org,
	Jernej Skrabec <jernej.skrabec@siol.net>,
	linux-sunxi@googlegroups.com,
	linux-arm-kernel@lists.infradead.org,
	Icenowy Zheng <icenowy@aosc.io>
Subject: [PATCH 3/7] arm64: dts: allwinner: Drop non-removable from SoPine/LTS SD card
Date: Wed,  6 Jan 2021 15:05:21 +0000	[thread overview]
Message-ID: <20210106150525.15403-4-andre.przywara@arm.com> (raw)
In-Reply-To: <20210106150525.15403-1-andre.przywara@arm.com>

The SD card on the SoPine SoM module is somewhat concealed, so was
originally defined as "non-removable".
However there is a working card-detect pin, and in certain SoM base
boards it might be actually accessible at runtime.
Also the Pine64-LTS shares the SoPine base .dtsi, so inherited the
non-removable flag, even though the SD card slot is perfectly accessible
and usable there. (It turns out that just *my* board has a broken card
detect switch, so I originally thought CD wouldn't work on the LTS.)

Drop the "non-removable" flag to describe the SD card slot properly.

Signed-off-by: Andre Przywara <andre.przywara@arm.com>
---
 arch/arm64/boot/dts/allwinner/sun50i-a64-sopine.dtsi | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine.dtsi
index c48692b06e1f..3402cec87035 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine.dtsi
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine.dtsi
@@ -32,7 +32,6 @@
 	pinctrl-names = "default";
 	pinctrl-0 = <&mmc0_pins>;
 	vmmc-supply = <&reg_dcdc1>;
-	non-removable;
 	disable-wp;
 	bus-width = <4>;
 	cd-gpios = <&pio 5 6 GPIO_ACTIVE_LOW>; /* PF6 */
-- 
2.17.5


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2021-01-06 15:06 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-06 15:05 [PATCH 0/7] arm64: dts: allwinner: Various DT fixes Andre Przywara
2021-01-06 15:05 ` Andre Przywara
2021-01-06 15:05 ` [PATCH 1/7] arm64: dts: allwinner: H6/A64: properly connect USB PHY to port 0 Andre Przywara
2021-01-06 15:05   ` Andre Przywara
2021-01-06 15:56   ` [linux-sunxi] " Chen-Yu Tsai
2021-01-06 15:56     ` Chen-Yu Tsai
2021-01-13 10:30     ` André Przywara
2021-01-13 10:30       ` André Przywara
2021-01-13 10:43       ` Chen-Yu Tsai
2021-01-13 10:43         ` Chen-Yu Tsai
2021-01-06 15:05 ` [PATCH 2/7] arm64: dts: allwinner: Pine64-LTS: Add status LED Andre Przywara
2021-01-06 15:05   ` Andre Przywara
2021-01-06 15:53   ` [linux-sunxi] " Chen-Yu Tsai
2021-01-06 15:53     ` Chen-Yu Tsai
2021-01-06 16:08     ` André Przywara
2021-01-06 16:08       ` André Przywara
2021-01-13 14:02       ` Emmanuel Vadot
2021-01-13 14:02         ` Emmanuel Vadot
2021-01-06 16:01   ` Maxime Ripard
2021-01-06 16:01     ` Maxime Ripard
2021-01-06 15:05 ` Andre Przywara [this message]
2021-01-06 15:05   ` [PATCH 3/7] arm64: dts: allwinner: Drop non-removable from SoPine/LTS SD card Andre Przywara
2021-01-06 15:57   ` [linux-sunxi] " Chen-Yu Tsai
2021-01-06 15:57     ` Chen-Yu Tsai
2021-01-06 15:05 ` [PATCH 4/7] arm64: dts: allwinner: H6: Allow up to 150 MHz MMC bus frequency Andre Przywara
2021-01-06 15:05   ` Andre Przywara
2021-01-06 16:01   ` [linux-sunxi] " Chen-Yu Tsai
2021-01-06 16:01     ` Chen-Yu Tsai
2021-01-06 15:05 ` [PATCH 5/7] arm64: dts: allwinner: A64: Limit MMC2 bus frequency to 150 MHz Andre Przywara
2021-01-06 15:05   ` Andre Przywara
2021-01-06 15:58   ` [linux-sunxi] " Chen-Yu Tsai
2021-01-06 15:58     ` Chen-Yu Tsai
2021-01-06 15:05 ` [PATCH 6/7] arm64: dts: allwinner: Pine64-LTS/SoPine: Enable HS200 eMMC mode Andre Przywara
2021-01-06 15:05   ` Andre Przywara
2021-01-06 15:59   ` [linux-sunxi] " Chen-Yu Tsai
2021-01-06 15:59     ` Chen-Yu Tsai
2021-01-06 15:05 ` [PATCH 7/7] arm64: dts: allwinner: Pine H64: " Andre Przywara
2021-01-06 15:05   ` Andre Przywara
2021-01-06 16:00   ` [linux-sunxi] " Chen-Yu Tsai
2021-01-06 16:00     ` Chen-Yu Tsai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210106150525.15403-4-andre.przywara@arm.com \
    --to=andre.przywara@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=icenowy@aosc.io \
    --cc=jernej.skrabec@siol.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-sunxi@googlegroups.com \
    --cc=mripard@kernel.org \
    --cc=robh@kernel.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.