From: Chao Leng <lengchao@huawei.com> To: <linux-nvme@lists.infradead.org> Cc: <kbusch@kernel.org>, <axboe@fb.com>, <hch@lst.de>, <sagi@grimberg.me>, <linux-block@vger.kernel.org>, <axboe@kernel.dk> Subject: [PATCH v2 6/6] nvme-fc: avoid IO error and repeated request completion Date: Thu, 7 Jan 2021 11:31:49 +0800 [thread overview] Message-ID: <20210107033149.15701-7-lengchao@huawei.com> (raw) In-Reply-To: <20210107033149.15701-1-lengchao@huawei.com> When a request is queued failed, blk_status_t is directly returned to the blk-mq. If blk_status_t is not BLK_STS_RESOURCE, BLK_STS_DEV_RESOURCE, BLK_STS_ZONE_RESOURCE, blk-mq call blk_mq_end_request to complete the request with BLK_STS_IOERR. In two scenarios, the request should be retried and may succeed. First, if work with nvme multipath, the request may be retried successfully in another path, because the error is probably related to the path. Second, if work without multipath software, the request may be retried successfully after error recovery. If the request is completed with BLK_STS_IOERR in blk_mq_dispatch_rq_list. The state of request may be changed to MQ_RQ_IN_FLIGHT. If free the request asynchronously such as in nvme_submit_user_cmd, in extreme scenario the request will be repeated freed in tear down. If a non-resource error occurs when queue_rq, should directly call nvme_complete_rq to complete request and set the state of request to MQ_RQ_COMPLETE. nvme_complete_rq will decide to retry, fail over or end the request. Signed-off-by: Chao Leng <lengchao@huawei.com> --- drivers/nvme/host/fc.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/nvme/host/fc.c b/drivers/nvme/host/fc.c index 38373a0e86ef..f6a5758ef1ea 100644 --- a/drivers/nvme/host/fc.c +++ b/drivers/nvme/host/fc.c @@ -2761,7 +2761,7 @@ nvme_fc_queue_rq(struct blk_mq_hw_ctx *hctx, ret = nvme_setup_cmd(ns, rq, sqe); if (ret) - return ret; + goto fail; /* * nvme core doesn't quite treat the rq opaquely. Commands such @@ -2781,7 +2781,9 @@ nvme_fc_queue_rq(struct blk_mq_hw_ctx *hctx, } - return nvme_fc_start_fcp_op(ctrl, queue, op, data_len, io_dir); + ret = nvme_fc_start_fcp_op(ctrl, queue, op, data_len, io_dir); +fail: + return nvme_try_complete_failed_req(rq, ret); } static void -- 2.16.4
WARNING: multiple messages have this Message-ID (diff)
From: Chao Leng <lengchao@huawei.com> To: <linux-nvme@lists.infradead.org> Cc: axboe@kernel.dk, linux-block@vger.kernel.org, sagi@grimberg.me, axboe@fb.com, kbusch@kernel.org, hch@lst.de Subject: [PATCH v2 6/6] nvme-fc: avoid IO error and repeated request completion Date: Thu, 7 Jan 2021 11:31:49 +0800 [thread overview] Message-ID: <20210107033149.15701-7-lengchao@huawei.com> (raw) In-Reply-To: <20210107033149.15701-1-lengchao@huawei.com> When a request is queued failed, blk_status_t is directly returned to the blk-mq. If blk_status_t is not BLK_STS_RESOURCE, BLK_STS_DEV_RESOURCE, BLK_STS_ZONE_RESOURCE, blk-mq call blk_mq_end_request to complete the request with BLK_STS_IOERR. In two scenarios, the request should be retried and may succeed. First, if work with nvme multipath, the request may be retried successfully in another path, because the error is probably related to the path. Second, if work without multipath software, the request may be retried successfully after error recovery. If the request is completed with BLK_STS_IOERR in blk_mq_dispatch_rq_list. The state of request may be changed to MQ_RQ_IN_FLIGHT. If free the request asynchronously such as in nvme_submit_user_cmd, in extreme scenario the request will be repeated freed in tear down. If a non-resource error occurs when queue_rq, should directly call nvme_complete_rq to complete request and set the state of request to MQ_RQ_COMPLETE. nvme_complete_rq will decide to retry, fail over or end the request. Signed-off-by: Chao Leng <lengchao@huawei.com> --- drivers/nvme/host/fc.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/nvme/host/fc.c b/drivers/nvme/host/fc.c index 38373a0e86ef..f6a5758ef1ea 100644 --- a/drivers/nvme/host/fc.c +++ b/drivers/nvme/host/fc.c @@ -2761,7 +2761,7 @@ nvme_fc_queue_rq(struct blk_mq_hw_ctx *hctx, ret = nvme_setup_cmd(ns, rq, sqe); if (ret) - return ret; + goto fail; /* * nvme core doesn't quite treat the rq opaquely. Commands such @@ -2781,7 +2781,9 @@ nvme_fc_queue_rq(struct blk_mq_hw_ctx *hctx, } - return nvme_fc_start_fcp_op(ctrl, queue, op, data_len, io_dir); + ret = nvme_fc_start_fcp_op(ctrl, queue, op, data_len, io_dir); +fail: + return nvme_try_complete_failed_req(rq, ret); } static void -- 2.16.4 _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-01-07 3:32 UTC|newest] Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-07 3:31 [PATCH v2 0/6] avoid repeated request completion and IO error Chao Leng 2021-01-07 3:31 ` Chao Leng 2021-01-07 3:31 ` [PATCH v2 1/6] blk-mq: introduce blk_mq_set_request_complete Chao Leng 2021-01-07 3:31 ` Chao Leng 2021-01-14 0:17 ` Sagi Grimberg 2021-01-14 0:17 ` Sagi Grimberg 2021-01-14 6:50 ` Chao Leng 2021-01-14 6:50 ` Chao Leng 2021-01-07 3:31 ` [PATCH v2 2/6] nvme-core: introduce complete failed request Chao Leng 2021-01-07 3:31 ` Chao Leng 2021-01-21 8:14 ` Hannes Reinecke 2021-01-22 1:45 ` Chao Leng 2021-01-07 3:31 ` [PATCH v2 3/6] nvme-fabrics: avoid repeated request completion for nvmf_fail_nonready_command Chao Leng 2021-01-07 3:31 ` Chao Leng 2021-01-07 3:31 ` [PATCH v2 4/6] nvme-rdma: avoid IO error and repeated request completion Chao Leng 2021-01-07 3:31 ` Chao Leng 2021-01-14 0:19 ` Sagi Grimberg 2021-01-14 0:19 ` Sagi Grimberg 2021-01-14 6:55 ` Chao Leng 2021-01-14 6:55 ` Chao Leng 2021-01-14 21:25 ` Sagi Grimberg 2021-01-14 21:25 ` Sagi Grimberg 2021-01-15 2:53 ` Chao Leng 2021-01-15 2:53 ` Chao Leng 2021-01-16 1:18 ` Sagi Grimberg 2021-01-16 1:18 ` Sagi Grimberg 2021-01-18 3:22 ` Chao Leng 2021-01-18 3:22 ` Chao Leng 2021-01-18 17:49 ` Christoph Hellwig 2021-01-18 17:49 ` Christoph Hellwig 2021-01-19 1:50 ` Chao Leng 2021-01-19 1:50 ` Chao Leng 2021-01-20 21:35 ` Sagi Grimberg 2021-01-20 21:35 ` Sagi Grimberg 2021-01-21 1:34 ` Chao Leng 2021-01-21 1:34 ` Chao Leng 2021-01-07 3:31 ` [PATCH v2 5/6] nvme-tcp: " Chao Leng 2021-01-07 3:31 ` Chao Leng 2021-01-07 3:31 ` Chao Leng [this message] 2021-01-07 3:31 ` [PATCH v2 6/6] nvme-fc: " Chao Leng 2021-01-14 0:15 ` [PATCH v2 0/6] avoid repeated request completion and IO error Sagi Grimberg 2021-01-14 0:15 ` Sagi Grimberg 2021-01-14 6:50 ` Chao Leng 2021-01-14 6:50 ` Chao Leng
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210107033149.15701-7-lengchao@huawei.com \ --to=lengchao@huawei.com \ --cc=axboe@fb.com \ --cc=axboe@kernel.dk \ --cc=hch@lst.de \ --cc=kbusch@kernel.org \ --cc=linux-block@vger.kernel.org \ --cc=linux-nvme@lists.infradead.org \ --cc=sagi@grimberg.me \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.