From: Mauricio Faria de Oliveira <mfo@canonical.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: Ming Lei <ming.lei@redhat.com>,
linux-block@vger.kernel.org,
Gabriel Krisman Bertazi <krisman@collabora.com>,
Eric Desrochers <eric.desrochers@canonical.com>
Subject: [PATCH v3] loop: fix I/O error on fsync() in detached loop devices
Date: Thu, 7 Jan 2021 15:17:34 -0300 [thread overview]
Message-ID: <20210107181734.128296-1-mfo@canonical.com> (raw)
There's an I/O error on fsync() in a detached loop device
if it has been previously attached.
The issue is write cache is enabled in the attach path in
loop_configure() but it isn't disabled in the detach path;
thus it remains enabled in the block device regardless of
whether it is attached or not.
Now fsync() can get an I/O request that will just be failed
later in loop_queue_rq() as device's state is not 'Lo_bound'.
So, disable write cache in the detach path.
Do so based on the queue flag, not the loop device flag for
read-only (used to enable) as the queue flag can be changed
via sysfs even on read-only loop devices (e.g., losetup -r.)
Test-case:
# DEV=/dev/loop7
# IMG=/tmp/image
# truncate --size 1M $IMG
# losetup $DEV $IMG
# losetup -d $DEV
Before:
# strace -e fsync parted -s $DEV print 2>&1 | grep fsync
fsync(3) = -1 EIO (Input/output error)
Warning: Error fsyncing/closing /dev/loop7: Input/output error
[ 982.529929] blk_update_request: I/O error, dev loop7, sector 0 op 0x1:(WRITE) flags 0x800 phys_seg 0 prio class 0
After:
# strace -e fsync parted -s $DEV print 2>&1 | grep fsync
fsync(3) = 0
Co-developed-by: Eric Desrochers <eric.desrochers@canonical.com>
Signed-off-by: Eric Desrochers <eric.desrochers@canonical.com>
Signed-off-by: Mauricio Faria de Oliveira <mfo@canonical.com>
Tested-by: Gabriel Krisman Bertazi <krisman@collabora.com>
---
drivers/block/loop.c | 3 +++
1 file changed, 3 insertions(+)
v3:
- Disable write cache based on QUEUE_FLAG_WC, not just
!LO_FLAGS_READ_ONLY, as the former can be enabled in
sysfs even for LO_FLAGS_READ_ONLY, thus not disabled
later. Mention that in commit message. (thanks, Ming)
v2:
- Fix ordering of Co-developed-by:/Signed-off-by: tags.
(thanks, Krisman)
- Add Tested-by: tag. (likewise.)
diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index e5ff328f0917..e94a11dbb5bd 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -1212,6 +1212,9 @@ static int __loop_clr_fd(struct loop_device *lo, bool release)
goto out_unlock;
}
+ if (test_bit(QUEUE_FLAG_WC, &lo->lo_queue->queue_flags))
+ blk_queue_write_cache(lo->lo_queue, false, false);
+
/* freeze request queue during the transition */
blk_mq_freeze_queue(lo->lo_queue);
--
2.27.0
next reply other threads:[~2021-01-07 18:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-07 18:17 Mauricio Faria de Oliveira [this message]
2021-01-08 0:23 ` [PATCH v3] loop: fix I/O error on fsync() in detached loop devices Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210107181734.128296-1-mfo@canonical.com \
--to=mfo@canonical.com \
--cc=axboe@kernel.dk \
--cc=eric.desrochers@canonical.com \
--cc=krisman@collabora.com \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.