All of lore.kernel.org
 help / color / mirror / Atom feed
From: Barry Song <song.bao.hua@hisilicon.com>
To: <dmitry.torokhov@gmail.com>, <tglx@linutronix.de>,
	<maz@kernel.org>, <gregkh@linuxfoundation.org>,
	<linux-input@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Cc: <linuxarm@openeuler.org>, Barry Song <song.bao.hua@hisilicon.com>
Subject: [PATCH v3 11/12] Input: tegra-kbc - request_irq by IRQF_NO_AUTOEN and remove disable_irq
Date: Fri, 8 Jan 2021 11:39:25 +1300	[thread overview]
Message-ID: <20210107223926.35284-12-song.bao.hua@hisilicon.com> (raw)
In-Reply-To: <20210107223926.35284-1-song.bao.hua@hisilicon.com>

disable_irq() after request_irq() still has a time gap in which
interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will
disable IRQ auto-enable because of requesting.

Signed-off-by: Barry Song <song.bao.hua@hisilicon.com>
---
 drivers/input/keyboard/tegra-kbc.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/input/keyboard/tegra-kbc.c b/drivers/input/keyboard/tegra-kbc.c
index 9671842a082a..570fe18c0ce9 100644
--- a/drivers/input/keyboard/tegra-kbc.c
+++ b/drivers/input/keyboard/tegra-kbc.c
@@ -694,14 +694,13 @@ static int tegra_kbc_probe(struct platform_device *pdev)
 	input_set_drvdata(kbc->idev, kbc);
 
 	err = devm_request_irq(&pdev->dev, kbc->irq, tegra_kbc_isr,
-			       IRQF_TRIGGER_HIGH, pdev->name, kbc);
+			       IRQF_TRIGGER_HIGH | IRQF_NO_AUTOEN,
+			       pdev->name, kbc);
 	if (err) {
 		dev_err(&pdev->dev, "failed to request keyboard IRQ\n");
 		return err;
 	}
 
-	disable_irq(kbc->irq);
-
 	err = input_register_device(kbc->idev);
 	if (err) {
 		dev_err(&pdev->dev, "failed to register input device\n");
-- 
2.25.1


  parent reply	other threads:[~2021-01-07 22:46 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-07 22:39 [PATCH v3 00/12] add IRQF_NO_AUTOEN for request_irq Barry Song
2021-01-07 22:39 ` [PATCH v3 01/12] genirq: " Barry Song
2021-01-28 19:54   ` Thomas Gleixner
2021-02-01  4:08     ` Song Bao Hua (Barry Song)
2021-01-07 22:39 ` [PATCH v3 02/12] Input: ar1021 - request_irq by IRQF_NO_AUTOEN and remove disable_irq Barry Song
2021-01-07 22:39 ` [PATCH v3 03/12] Input: atmel_mxt_ts " Barry Song
2021-01-07 22:39 ` [PATCH v3 04/12] Input: melfas_mip4 " Barry Song
2021-01-07 22:39 ` [PATCH v3 05/12] Input: bu21029_ts - request_irq by IRQF_NO_AUTOEN and remove irq_set_status_flags Barry Song
2021-01-07 22:39 ` [PATCH v3 06/12] Input: stmfts " Barry Song
2021-01-07 22:39 ` [PATCH v3 07/12] Input: zinitix " Barry Song
2021-01-07 22:39 ` [PATCH v3 08/12] Input: mms114 - request_irq by IRQF_NO_AUTOEN and remove disable_irq Barry Song
2021-01-07 22:39 ` [PATCH v3 09/12] Input: wm831x-ts " Barry Song
2021-01-07 22:39 ` [PATCH v3 10/12] Input: cyttsp " Barry Song
2021-01-07 22:39 ` Barry Song [this message]
2021-01-07 22:39 ` [PATCH v3 12/12] Input: tca6416-keypad " Barry Song
2021-01-21 21:38 ` [PATCH v3 00/12] add IRQF_NO_AUTOEN for request_irq Song Bao Hua (Barry Song)
2021-01-27 13:49   ` gregkh
2021-01-27 19:45     ` dmitry.torokhov
2021-01-28 11:08       ` [Linuxarm] " Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210107223926.35284-12-song.bao.hua@hisilicon.com \
    --to=song.bao.hua@hisilicon.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxarm@openeuler.org \
    --cc=maz@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.