From: Andre Przywara <andre.przywara@arm.com> To: Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>, Rob Herring <robh@kernel.org> Cc: Jernej Skrabec <jernej.skrabec@siol.net>, Icenowy Zheng <icenowy@aosc.io>, Emmanuel Vadot <manu@bidouilliste.com>, Heinrich Schuchardt <xypron.glpk@gmx.de>, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@googlegroups.com Subject: [PATCH v2 2/8] arm64: dts: allwinner: H6: properly connect USB PHY to port 0 Date: Wed, 13 Jan 2021 15:26:24 +0000 [thread overview] Message-ID: <20210113152630.28810-3-andre.przywara@arm.com> (raw) In-Reply-To: <20210113152630.28810-1-andre.przywara@arm.com> In recent Allwinner SoCs the first USB host controller (HCI0) shares the first PHY with the MUSB controller. Probably to make this sharing work, we were avoiding to declare this in the DT. This has two shortcomings: - U-Boot (which uses the same .dts) cannot use this port in host mode without a PHY linked, so we were loosing one USB port there. - It requires the MUSB driver to be enabled and loaded, although we don't actually use it. To avoid those issues, let's add this PHY link to the H6 .dtsi file. After all PHY port 0 *is* connected to HCI0, so we should describe it as this. This makes it work in U-Boot, also improves compatiblity when no MUSB driver is loaded (for instance in distribution installers). Fixes: eabb3d424b6d ("arm64: dts: allwinner: h6: add USB2-related device nodes") Signed-off-by: Andre Przywara <andre.przywara@arm.com> --- arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi index 8a62a9fbe347..f593cfeaecc9 100644 --- a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi @@ -680,6 +680,8 @@ <&ccu CLK_USB_OHCI0>; resets = <&ccu RST_BUS_OHCI0>, <&ccu RST_BUS_EHCI0>; + phys = <&usb2phy 0>; + phy-names = "usb"; status = "disabled"; }; @@ -690,6 +692,8 @@ clocks = <&ccu CLK_BUS_OHCI0>, <&ccu CLK_USB_OHCI0>; resets = <&ccu RST_BUS_OHCI0>; + phys = <&usb2phy 0>; + phy-names = "usb"; status = "disabled"; }; -- 2.17.5
WARNING: multiple messages have this Message-ID (diff)
From: Andre Przywara <andre.przywara@arm.com> To: Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>, Rob Herring <robh@kernel.org> Cc: devicetree@vger.kernel.org, Jernej Skrabec <jernej.skrabec@siol.net>, Emmanuel Vadot <manu@bidouilliste.com>, Heinrich Schuchardt <xypron.glpk@gmx.de>, linux-sunxi@googlegroups.com, linux-arm-kernel@lists.infradead.org, Icenowy Zheng <icenowy@aosc.io> Subject: [PATCH v2 2/8] arm64: dts: allwinner: H6: properly connect USB PHY to port 0 Date: Wed, 13 Jan 2021 15:26:24 +0000 [thread overview] Message-ID: <20210113152630.28810-3-andre.przywara@arm.com> (raw) In-Reply-To: <20210113152630.28810-1-andre.przywara@arm.com> In recent Allwinner SoCs the first USB host controller (HCI0) shares the first PHY with the MUSB controller. Probably to make this sharing work, we were avoiding to declare this in the DT. This has two shortcomings: - U-Boot (which uses the same .dts) cannot use this port in host mode without a PHY linked, so we were loosing one USB port there. - It requires the MUSB driver to be enabled and loaded, although we don't actually use it. To avoid those issues, let's add this PHY link to the H6 .dtsi file. After all PHY port 0 *is* connected to HCI0, so we should describe it as this. This makes it work in U-Boot, also improves compatiblity when no MUSB driver is loaded (for instance in distribution installers). Fixes: eabb3d424b6d ("arm64: dts: allwinner: h6: add USB2-related device nodes") Signed-off-by: Andre Przywara <andre.przywara@arm.com> --- arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi index 8a62a9fbe347..f593cfeaecc9 100644 --- a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi @@ -680,6 +680,8 @@ <&ccu CLK_USB_OHCI0>; resets = <&ccu RST_BUS_OHCI0>, <&ccu RST_BUS_EHCI0>; + phys = <&usb2phy 0>; + phy-names = "usb"; status = "disabled"; }; @@ -690,6 +692,8 @@ clocks = <&ccu CLK_BUS_OHCI0>, <&ccu CLK_USB_OHCI0>; resets = <&ccu RST_BUS_OHCI0>; + phys = <&usb2phy 0>; + phy-names = "usb"; status = "disabled"; }; -- 2.17.5 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-01-13 15:28 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-13 15:26 [PATCH v2 0/8] arm64: dts: allwinner: Various DT fixes Andre Przywara 2021-01-13 15:26 ` Andre Przywara 2021-01-13 15:26 ` [PATCH v2 1/8] arm64: dts: allwinner: A64: properly connect USB PHY to port 0 Andre Przywara 2021-01-13 15:26 ` Andre Przywara 2021-01-13 15:26 ` Andre Przywara [this message] 2021-01-13 15:26 ` [PATCH v2 2/8] arm64: dts: allwinner: H6: " Andre Przywara 2021-01-13 15:26 ` [PATCH v2 3/8] arm64: dts: allwinner: Pine64-LTS: Add status LED Andre Przywara 2021-01-13 15:26 ` Andre Przywara 2021-01-13 17:13 ` Heinrich Schuchardt 2021-01-13 17:13 ` Heinrich Schuchardt 2021-01-14 11:48 ` Maxime Ripard 2021-01-14 11:48 ` Maxime Ripard 2021-01-13 15:26 ` [PATCH v2 4/8] arm64: dts: allwinner: Drop non-removable from SoPine/LTS SD card Andre Przywara 2021-01-13 15:26 ` Andre Przywara 2021-01-13 15:26 ` [PATCH v2 5/8] arm64: dts: allwinner: H6: Allow up to 150 MHz MMC bus frequency Andre Przywara 2021-01-13 15:26 ` Andre Przywara 2021-01-13 15:26 ` [PATCH v2 6/8] arm64: dts: allwinner: A64: Limit MMC2 bus frequency to 150 MHz Andre Przywara 2021-01-13 15:26 ` Andre Przywara 2021-01-13 15:26 ` [PATCH v2 7/8] arm64: dts: allwinner: Pine64-LTS/SoPine: Enable HS200 eMMC mode Andre Przywara 2021-01-13 15:26 ` Andre Przywara 2021-01-13 15:26 ` [PATCH v2 8/8] arm64: dts: allwinner: Pine H64: " Andre Przywara 2021-01-13 15:26 ` Andre Przywara 2021-01-14 5:04 ` [linux-sunxi] [PATCH v2 0/8] arm64: dts: allwinner: Various DT fixes Chen-Yu Tsai 2021-01-14 5:04 ` Chen-Yu Tsai 2021-01-14 11:51 ` Maxime Ripard 2021-01-14 11:51 ` Maxime Ripard
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210113152630.28810-3-andre.przywara@arm.com \ --to=andre.przywara@arm.com \ --cc=devicetree@vger.kernel.org \ --cc=icenowy@aosc.io \ --cc=jernej.skrabec@siol.net \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-sunxi@googlegroups.com \ --cc=manu@bidouilliste.com \ --cc=mripard@kernel.org \ --cc=robh@kernel.org \ --cc=wens@csie.org \ --cc=xypron.glpk@gmx.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.