From: Andre Przywara <andre.przywara@arm.com>
To: Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Rob Herring <robh@kernel.org>
Cc: Jernej Skrabec <jernej.skrabec@siol.net>,
Icenowy Zheng <icenowy@aosc.io>,
Emmanuel Vadot <manu@bidouilliste.com>,
Heinrich Schuchardt <xypron.glpk@gmx.de>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-sunxi@googlegroups.com
Subject: [PATCH v2 4/8] arm64: dts: allwinner: Drop non-removable from SoPine/LTS SD card
Date: Wed, 13 Jan 2021 15:26:26 +0000 [thread overview]
Message-ID: <20210113152630.28810-5-andre.przywara@arm.com> (raw)
In-Reply-To: <20210113152630.28810-1-andre.przywara@arm.com>
The SD card on the SoPine SoM module is somewhat concealed, so was
originally defined as "non-removable".
However there is a working card-detect pin (tested on two different
SoM versions), and in certain SoM base boards it might be actually
accessible at runtime.
Also the Pine64-LTS shares the SoPine base .dtsi, so inherited the
non-removable flag, even though the SD card slot is perfectly accessible
and usable there. (It turns out that just *my* board has a broken card
detect switch, so I originally thought CD wouldn't work on the LTS.)
Drop the "non-removable" flag to describe the SD card slot properly.
Fixes: c3904a269891 ("arm64: allwinner: a64: add DTSI file for SoPine SoM")
Signed-off-by: Andre Przywara <andre.przywara@arm.com>
---
arch/arm64/boot/dts/allwinner/sun50i-a64-sopine.dtsi | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine.dtsi
index c48692b06e1f..3402cec87035 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine.dtsi
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine.dtsi
@@ -32,7 +32,6 @@
pinctrl-names = "default";
pinctrl-0 = <&mmc0_pins>;
vmmc-supply = <®_dcdc1>;
- non-removable;
disable-wp;
bus-width = <4>;
cd-gpios = <&pio 5 6 GPIO_ACTIVE_LOW>; /* PF6 */
--
2.17.5
WARNING: multiple messages have this Message-ID (diff)
From: Andre Przywara <andre.przywara@arm.com>
To: Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org,
Jernej Skrabec <jernej.skrabec@siol.net>,
Emmanuel Vadot <manu@bidouilliste.com>,
Heinrich Schuchardt <xypron.glpk@gmx.de>,
linux-sunxi@googlegroups.com,
linux-arm-kernel@lists.infradead.org,
Icenowy Zheng <icenowy@aosc.io>
Subject: [PATCH v2 4/8] arm64: dts: allwinner: Drop non-removable from SoPine/LTS SD card
Date: Wed, 13 Jan 2021 15:26:26 +0000 [thread overview]
Message-ID: <20210113152630.28810-5-andre.przywara@arm.com> (raw)
In-Reply-To: <20210113152630.28810-1-andre.przywara@arm.com>
The SD card on the SoPine SoM module is somewhat concealed, so was
originally defined as "non-removable".
However there is a working card-detect pin (tested on two different
SoM versions), and in certain SoM base boards it might be actually
accessible at runtime.
Also the Pine64-LTS shares the SoPine base .dtsi, so inherited the
non-removable flag, even though the SD card slot is perfectly accessible
and usable there. (It turns out that just *my* board has a broken card
detect switch, so I originally thought CD wouldn't work on the LTS.)
Drop the "non-removable" flag to describe the SD card slot properly.
Fixes: c3904a269891 ("arm64: allwinner: a64: add DTSI file for SoPine SoM")
Signed-off-by: Andre Przywara <andre.przywara@arm.com>
---
arch/arm64/boot/dts/allwinner/sun50i-a64-sopine.dtsi | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine.dtsi
index c48692b06e1f..3402cec87035 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine.dtsi
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine.dtsi
@@ -32,7 +32,6 @@
pinctrl-names = "default";
pinctrl-0 = <&mmc0_pins>;
vmmc-supply = <®_dcdc1>;
- non-removable;
disable-wp;
bus-width = <4>;
cd-gpios = <&pio 5 6 GPIO_ACTIVE_LOW>; /* PF6 */
--
2.17.5
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-01-13 15:28 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-13 15:26 [PATCH v2 0/8] arm64: dts: allwinner: Various DT fixes Andre Przywara
2021-01-13 15:26 ` Andre Przywara
2021-01-13 15:26 ` [PATCH v2 1/8] arm64: dts: allwinner: A64: properly connect USB PHY to port 0 Andre Przywara
2021-01-13 15:26 ` Andre Przywara
2021-01-13 15:26 ` [PATCH v2 2/8] arm64: dts: allwinner: H6: " Andre Przywara
2021-01-13 15:26 ` Andre Przywara
2021-01-13 15:26 ` [PATCH v2 3/8] arm64: dts: allwinner: Pine64-LTS: Add status LED Andre Przywara
2021-01-13 15:26 ` Andre Przywara
2021-01-13 17:13 ` Heinrich Schuchardt
2021-01-13 17:13 ` Heinrich Schuchardt
2021-01-14 11:48 ` Maxime Ripard
2021-01-14 11:48 ` Maxime Ripard
2021-01-13 15:26 ` Andre Przywara [this message]
2021-01-13 15:26 ` [PATCH v2 4/8] arm64: dts: allwinner: Drop non-removable from SoPine/LTS SD card Andre Przywara
2021-01-13 15:26 ` [PATCH v2 5/8] arm64: dts: allwinner: H6: Allow up to 150 MHz MMC bus frequency Andre Przywara
2021-01-13 15:26 ` Andre Przywara
2021-01-13 15:26 ` [PATCH v2 6/8] arm64: dts: allwinner: A64: Limit MMC2 bus frequency to 150 MHz Andre Przywara
2021-01-13 15:26 ` Andre Przywara
2021-01-13 15:26 ` [PATCH v2 7/8] arm64: dts: allwinner: Pine64-LTS/SoPine: Enable HS200 eMMC mode Andre Przywara
2021-01-13 15:26 ` Andre Przywara
2021-01-13 15:26 ` [PATCH v2 8/8] arm64: dts: allwinner: Pine H64: " Andre Przywara
2021-01-13 15:26 ` Andre Przywara
2021-01-14 5:04 ` [linux-sunxi] [PATCH v2 0/8] arm64: dts: allwinner: Various DT fixes Chen-Yu Tsai
2021-01-14 5:04 ` Chen-Yu Tsai
2021-01-14 11:51 ` Maxime Ripard
2021-01-14 11:51 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210113152630.28810-5-andre.przywara@arm.com \
--to=andre.przywara@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=icenowy@aosc.io \
--cc=jernej.skrabec@siol.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-sunxi@googlegroups.com \
--cc=manu@bidouilliste.com \
--cc=mripard@kernel.org \
--cc=robh@kernel.org \
--cc=wens@csie.org \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.