From: zhenwei pi <pizhenwei@bytedance.com>
To: kbusch@kernel.org, its@irrelevant.dk, kwolf@redhat.com,
mreitz@redhat.com
Cc: zhenwei pi <pizhenwei@bytedance.com>,
philmd@redhat.com, qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: [PATCH v3 2/4] hw/block/nvme: fix overwritten bar.cap
Date: Thu, 14 Jan 2021 15:22:49 +0800 [thread overview]
Message-ID: <20210114072251.334304-3-pizhenwei@bytedance.com> (raw)
In-Reply-To: <20210114072251.334304-1-pizhenwei@bytedance.com>
After PMR initialization, bar.cap should not be clear in function
nvme_init_ctrl. Otherwise the PMR cap would be always disabled.
Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
---
hw/block/nvme.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
index 27d2c72716..f361103bb4 100644
--- a/hw/block/nvme.c
+++ b/hw/block/nvme.c
@@ -2745,7 +2745,6 @@ static void nvme_init_ctrl(NvmeCtrl *n, PCIDevice *pci_dev)
id->psd[0].enlat = cpu_to_le32(0x10);
id->psd[0].exlat = cpu_to_le32(0x4);
- n->bar.cap = 0;
NVME_CAP_SET_MQES(n->bar.cap, 0x7ff);
NVME_CAP_SET_CQR(n->bar.cap, 1);
NVME_CAP_SET_TO(n->bar.cap, 0xf);
--
2.25.1
next prev parent reply other threads:[~2021-01-14 7:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-14 7:22 [PATCH v3 0/4] support NVMe smart critial warning injection zhenwei pi
2021-01-14 7:22 ` [PATCH v3 1/4] block/nvme: introduce bit 5 for critical warning zhenwei pi
2021-01-14 7:22 ` zhenwei pi [this message]
2021-01-14 8:24 ` [PATCH v3 2/4] hw/block/nvme: fix overwritten bar.cap Klaus Jensen
2021-01-14 7:22 ` [PATCH v3 3/4] hw/block/nvme: add smart_critical_warning property zhenwei pi
2021-01-14 8:29 ` Klaus Jensen
2021-01-14 15:55 ` Philippe Mathieu-Daudé
2021-01-14 22:23 ` Keith Busch
2021-01-14 7:22 ` [PATCH v3 4/4] hw/blocl/nvme: trigger async event during injecting smart warning zhenwei pi
2021-01-14 8:23 ` Klaus Jensen
2021-01-14 15:57 ` Philippe Mathieu-Daudé
2021-01-14 22:29 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210114072251.334304-3-pizhenwei@bytedance.com \
--to=pizhenwei@bytedance.com \
--cc=its@irrelevant.dk \
--cc=kbusch@kernel.org \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.