All of lore.kernel.org
 help / color / mirror / Atom feed
From: Muchun Song <songmuchun@bytedance.com>
To: mike.kravetz@oracle.com, akpm@linux-foundation.org
Cc: n-horiguchi@ah.jp.nec.com, ak@linux.intel.com, mhocko@suse.cz,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Muchun Song <songmuchun@bytedance.com>,
	Michal Hocko <mhocko@suse.com>,
	stable@vger.kernel.org
Subject: [PATCH v5 5/5] mm: hugetlb: remove VM_BUG_ON_PAGE from page_huge_active
Date: Thu, 14 Jan 2021 18:35:15 +0800	[thread overview]
Message-ID: <20210114103515.12955-6-songmuchun@bytedance.com> (raw)
In-Reply-To: <20210114103515.12955-1-songmuchun@bytedance.com>

The page_huge_active() can be called from scan_movable_pages() which
do not hold a reference count to the HugeTLB page. So when we call
page_huge_active() from scan_movable_pages(), the HugeTLB page can
be freed parallel. Then we will trigger a BUG_ON which is in the
page_huge_active() when CONFIG_DEBUG_VM is enabled. Just remove the
VM_BUG_ON_PAGE.

Fixes: 7e1f049efb86 ("mm: hugetlb: cleanup using paeg_huge_active()")
Signed-off-by: Muchun Song <songmuchun@bytedance.com>
Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
Acked-by: Michal Hocko <mhocko@suse.com>
Cc: stable@vger.kernel.org
---
 mm/hugetlb.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index 43b7a044f248..6c5dfef682cc 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -1360,8 +1360,7 @@ struct hstate *size_to_hstate(unsigned long size)
  */
 bool page_huge_active(struct page *page)
 {
-	VM_BUG_ON_PAGE(!PageHuge(page), page);
-	return PageHead(page) && PagePrivate(&page[1]);
+	return PageHeadHuge(page) && PagePrivate(&page[1]);
 }
 
 /* never called for tail page */
-- 
2.11.0


      parent reply	other threads:[~2021-01-14 10:40 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-14 10:35 [PATCH v5 0/5] Fix some bugs about HugeTLB code Muchun Song
2021-01-14 10:35 ` [PATCH v5 1/5] mm: migrate: do not migrate HugeTLB page whose refcount is one Muchun Song
2021-01-14 10:35 ` [PATCH v5 2/5] mm: hugetlbfs: fix cannot migrate the fallocated HugeTLB page Muchun Song
2021-01-14 10:35 ` [PATCH v5 3/5] mm: hugetlb: fix a race between freeing and dissolving the page Muchun Song
2021-01-14 13:20   ` Michal Hocko
2021-01-14 13:47     ` [External] " Muchun Song
2021-01-14 13:47       ` Muchun Song
2021-01-14 15:38       ` Michal Hocko
2021-01-14 16:16         ` Muchun Song
2021-01-14 16:16           ` Muchun Song
2021-01-14 10:35 ` [PATCH v5 4/5] mm: hugetlb: fix a race between isolating and freeing page Muchun Song
2021-01-14 10:35 ` Muchun Song [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210114103515.12955-6-songmuchun@bytedance.com \
    --to=songmuchun@bytedance.com \
    --cc=ak@linux.intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=mhocko@suse.cz \
    --cc=mike.kravetz@oracle.com \
    --cc=n-horiguchi@ah.jp.nec.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.