From: "Rafał Miłecki" <zajec5@gmail.com> To: Florian Fainelli <f.fainelli@gmail.com> Cc: bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, "Rafał Miłecki" <rafal@milecki.pl> Subject: [PATCH Broadcom/stblinux] soc: brcmstb: add stubs for getting platform IDs Date: Thu, 14 Jan 2021 11:53:18 +0100 [thread overview] Message-ID: <20210114105318.14970-1-zajec5@gmail.com> (raw) From: Rafał Miłecki <rafal@milecki.pl> Some brcmstb drivers may be shared with other SoC families. E.g. the same USB PHY block is shared by brcmstb and BCM4908. To avoid building brcmstb common code on non-brcmstb platforms we need stubs for: 1. brcmstb_get_family_id() 2. brcmstb_get_product_id() (to avoid "undefined reference to" errors). With this change PHY_BRCM_USB will not have to unconditionally select SOC_BRCMSTB anymore. Signed-off-by: Rafał Miłecki <rafal@milecki.pl> --- include/linux/soc/brcmstb/brcmstb.h | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/include/linux/soc/brcmstb/brcmstb.h b/include/linux/soc/brcmstb/brcmstb.h index 8e884e0dda0a..9433f5c8fd94 100644 --- a/include/linux/soc/brcmstb/brcmstb.h +++ b/include/linux/soc/brcmstb/brcmstb.h @@ -12,6 +12,8 @@ static inline u32 BRCM_REV(u32 reg) return reg & 0xff; } +#ifdef CONFIG_SOC_BRCMSTB + /* * Helper functions for getting family or product id from the * SoC driver. @@ -19,4 +21,18 @@ static inline u32 BRCM_REV(u32 reg) u32 brcmstb_get_family_id(void); u32 brcmstb_get_product_id(void); +#else + +static inline u32 brcmstb_get_family_id(void) +{ + return 0; +} + +static inline u32 brcmstb_get_product_id(void) +{ + return 0; +} + +#endif + #endif /* __BRCMSTB_SOC_H */ -- 2.26.2
WARNING: multiple messages have this Message-ID (diff)
From: "Rafał Miłecki" <zajec5@gmail.com> To: Florian Fainelli <f.fainelli@gmail.com> Cc: "Rafał Miłecki" <rafal@milecki.pl>, bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH Broadcom/stblinux] soc: brcmstb: add stubs for getting platform IDs Date: Thu, 14 Jan 2021 11:53:18 +0100 [thread overview] Message-ID: <20210114105318.14970-1-zajec5@gmail.com> (raw) From: Rafał Miłecki <rafal@milecki.pl> Some brcmstb drivers may be shared with other SoC families. E.g. the same USB PHY block is shared by brcmstb and BCM4908. To avoid building brcmstb common code on non-brcmstb platforms we need stubs for: 1. brcmstb_get_family_id() 2. brcmstb_get_product_id() (to avoid "undefined reference to" errors). With this change PHY_BRCM_USB will not have to unconditionally select SOC_BRCMSTB anymore. Signed-off-by: Rafał Miłecki <rafal@milecki.pl> --- include/linux/soc/brcmstb/brcmstb.h | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/include/linux/soc/brcmstb/brcmstb.h b/include/linux/soc/brcmstb/brcmstb.h index 8e884e0dda0a..9433f5c8fd94 100644 --- a/include/linux/soc/brcmstb/brcmstb.h +++ b/include/linux/soc/brcmstb/brcmstb.h @@ -12,6 +12,8 @@ static inline u32 BRCM_REV(u32 reg) return reg & 0xff; } +#ifdef CONFIG_SOC_BRCMSTB + /* * Helper functions for getting family or product id from the * SoC driver. @@ -19,4 +21,18 @@ static inline u32 BRCM_REV(u32 reg) u32 brcmstb_get_family_id(void); u32 brcmstb_get_product_id(void); +#else + +static inline u32 brcmstb_get_family_id(void) +{ + return 0; +} + +static inline u32 brcmstb_get_product_id(void) +{ + return 0; +} + +#endif + #endif /* __BRCMSTB_SOC_H */ -- 2.26.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2021-01-14 10:54 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-14 10:53 Rafał Miłecki [this message] 2021-01-14 10:53 ` [PATCH Broadcom/stblinux] soc: brcmstb: add stubs for getting platform IDs Rafał Miłecki 2021-01-20 19:48 ` Florian Fainelli 2021-01-20 19:48 ` Florian Fainelli 2021-01-20 19:58 ` Florian Fainelli 2021-01-20 19:58 ` Florian Fainelli 2021-01-20 20:00 ` Rafał Miłecki 2021-01-20 20:00 ` Rafał Miłecki
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210114105318.14970-1-zajec5@gmail.com \ --to=zajec5@gmail.com \ --cc=bcm-kernel-feedback-list@broadcom.com \ --cc=f.fainelli@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=rafal@milecki.pl \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.