From: Vaibhav Gupta <vaibhavgupta40@gmail.com> To: Bjorn Helgaas <helgaas@kernel.org>, Bjorn Helgaas <bhelgaas@google.com>, Bjorn Helgaas <bjorn@helgaas.com>, Vaibhav Gupta <vaibhav.varodek@gmail.com>, Jens Axboe <axboe@kernel.dk>, Joshua Morris <josh.h.morris@us.ibm.com>, Philip Kelleher <pjk1939@linux.ibm.com>, Damien Le Moal <Damien.LeMoal@wdc.com> Cc: Vaibhav Gupta <vaibhavgupta40@gmail.com>, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, Shuah Khan <skhan@linuxfoundation.org> Subject: [PATCH v4 2/3] rsxx: use generic power management Date: Thu, 14 Jan 2021 17:24:22 +0530 [thread overview] Message-ID: <20210114115423.52414-3-vaibhavgupta40@gmail.com> (raw) In-Reply-To: <20210114115423.52414-1-vaibhavgupta40@gmail.com> Drivers using legacy power management .suspen()/.resume() callbacks have to manage PCI states and device's PM states themselves. They also need to take care of standard configuration registers. Switch to generic power management framework using a single "struct dev_pm_ops" variable to take the unnecessary load from the driver. This also avoids the need for the driver to directly call most of the PCI helper functions and device power state control functions, as through the generic framework PCI Core takes care of the necessary operations, and drivers are required to do only device-specific jobs. Signed-off-by: Vaibhav Gupta <vaibhavgupta40@gmail.com> --- drivers/block/rsxx/core.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/block/rsxx/core.c b/drivers/block/rsxx/core.c index 63f549889f87..937ad8a28e85 100644 --- a/drivers/block/rsxx/core.c +++ b/drivers/block/rsxx/core.c @@ -1032,12 +1032,15 @@ static void rsxx_pci_remove(struct pci_dev *dev) kfree(card); } -static int rsxx_pci_suspend(struct pci_dev *dev, pm_message_t state) +static int __maybe_unused rsxx_pci_suspend( + __attribute__((unused)) struct device *dev) { /* We don't support suspend at this time. */ return -ENOSYS; } +#define rsxx_pci_resume NULL + static void rsxx_pci_shutdown(struct pci_dev *dev) { struct rsxx_cardinfo *card = pci_get_drvdata(dev); @@ -1073,12 +1076,14 @@ static const struct pci_device_id rsxx_pci_ids[] = { MODULE_DEVICE_TABLE(pci, rsxx_pci_ids); +static SIMPLE_DEV_PM_OPS(rsxx_pci_pm_ops, rsxx_pci_suspend, rsxx_pci_resume); + static struct pci_driver rsxx_pci_driver = { .name = DRIVER_NAME, .id_table = rsxx_pci_ids, .probe = rsxx_pci_probe, .remove = rsxx_pci_remove, - .suspend = rsxx_pci_suspend, + .driver.pm = &rsxx_pci_pm_ops, .shutdown = rsxx_pci_shutdown, .err_handler = &rsxx_err_handler, }; -- 2.30.0
WARNING: multiple messages have this Message-ID (diff)
From: Vaibhav Gupta <vaibhavgupta40@gmail.com> To: Bjorn Helgaas <helgaas@kernel.org>, Bjorn Helgaas <bhelgaas@google.com>, Bjorn Helgaas <bjorn@helgaas.com>, Vaibhav Gupta <vaibhav.varodek@gmail.com>, Jens Axboe <axboe@kernel.dk>, Joshua Morris <josh.h.morris@us.ibm.com>, Philip Kelleher <pjk1939@linux.ibm.com>, Damien Le Moal <Damien.LeMoal@wdc.com> Cc: linux-block@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, linux-kernel@vger.kernel.org Subject: [Linux-kernel-mentees] [PATCH v4 2/3] rsxx: use generic power management Date: Thu, 14 Jan 2021 17:24:22 +0530 [thread overview] Message-ID: <20210114115423.52414-3-vaibhavgupta40@gmail.com> (raw) In-Reply-To: <20210114115423.52414-1-vaibhavgupta40@gmail.com> Drivers using legacy power management .suspen()/.resume() callbacks have to manage PCI states and device's PM states themselves. They also need to take care of standard configuration registers. Switch to generic power management framework using a single "struct dev_pm_ops" variable to take the unnecessary load from the driver. This also avoids the need for the driver to directly call most of the PCI helper functions and device power state control functions, as through the generic framework PCI Core takes care of the necessary operations, and drivers are required to do only device-specific jobs. Signed-off-by: Vaibhav Gupta <vaibhavgupta40@gmail.com> --- drivers/block/rsxx/core.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/block/rsxx/core.c b/drivers/block/rsxx/core.c index 63f549889f87..937ad8a28e85 100644 --- a/drivers/block/rsxx/core.c +++ b/drivers/block/rsxx/core.c @@ -1032,12 +1032,15 @@ static void rsxx_pci_remove(struct pci_dev *dev) kfree(card); } -static int rsxx_pci_suspend(struct pci_dev *dev, pm_message_t state) +static int __maybe_unused rsxx_pci_suspend( + __attribute__((unused)) struct device *dev) { /* We don't support suspend at this time. */ return -ENOSYS; } +#define rsxx_pci_resume NULL + static void rsxx_pci_shutdown(struct pci_dev *dev) { struct rsxx_cardinfo *card = pci_get_drvdata(dev); @@ -1073,12 +1076,14 @@ static const struct pci_device_id rsxx_pci_ids[] = { MODULE_DEVICE_TABLE(pci, rsxx_pci_ids); +static SIMPLE_DEV_PM_OPS(rsxx_pci_pm_ops, rsxx_pci_suspend, rsxx_pci_resume); + static struct pci_driver rsxx_pci_driver = { .name = DRIVER_NAME, .id_table = rsxx_pci_ids, .probe = rsxx_pci_probe, .remove = rsxx_pci_remove, - .suspend = rsxx_pci_suspend, + .driver.pm = &rsxx_pci_pm_ops, .shutdown = rsxx_pci_shutdown, .err_handler = &rsxx_err_handler, }; -- 2.30.0 _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2021-01-14 11:58 UTC|newest] Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-17 8:09 [PATCH v1 0/3] block: use generic power management Vaibhav Gupta 2020-07-17 8:09 ` [Linux-kernel-mentees] " Vaibhav Gupta 2020-07-17 8:09 ` [PATCH v1 1/3] mtip32xx: " Vaibhav Gupta 2020-07-17 8:09 ` [Linux-kernel-mentees] " Vaibhav Gupta 2020-07-17 8:09 ` [PATCH v1 2/3] rsxx: " Vaibhav Gupta 2020-07-17 8:09 ` [Linux-kernel-mentees] " Vaibhav Gupta 2020-07-17 8:09 ` [PATCH v1 3/3] skd: " Vaibhav Gupta 2020-07-17 8:09 ` [Linux-kernel-mentees] " Vaibhav Gupta 2020-07-20 12:52 ` Damien Le Moal 2020-07-20 12:52 ` [Linux-kernel-mentees] " Damien Le Moal 2020-07-20 13:16 ` Vaibhav Gupta 2020-07-20 13:16 ` [Linux-kernel-mentees] " Vaibhav Gupta 2020-07-21 2:49 ` Damien Le Moal 2020-07-21 2:49 ` [Linux-kernel-mentees] " Damien Le Moal 2020-07-21 7:04 ` Vaibhav Gupta 2020-07-21 7:04 ` [Linux-kernel-mentees] " Vaibhav Gupta 2020-07-20 13:29 ` [PATCH v2 0/3] block: " Vaibhav Gupta 2020-07-20 13:29 ` [Linux-kernel-mentees] " Vaibhav Gupta 2020-07-20 13:30 ` [PATCH v2 1/3] mtip32xx: " Vaibhav Gupta 2020-07-20 13:30 ` [Linux-kernel-mentees] " Vaibhav Gupta 2020-07-20 13:30 ` [PATCH v2 2/3] rsxx: " Vaibhav Gupta 2020-07-20 13:30 ` [Linux-kernel-mentees] " Vaibhav Gupta 2020-07-20 13:30 ` [PATCH v2 3/3] skd: " Vaibhav Gupta 2020-07-20 13:30 ` [Linux-kernel-mentees] " Vaibhav Gupta 2020-07-21 2:57 ` Damien Le Moal 2020-07-21 2:57 ` [Linux-kernel-mentees] " Damien Le Moal 2020-07-21 7:09 ` Vaibhav Gupta 2020-07-21 7:09 ` [Linux-kernel-mentees] " Vaibhav Gupta 2020-07-22 6:28 ` Damien Le Moal 2020-07-22 6:28 ` [Linux-kernel-mentees] " Damien Le Moal 2020-07-22 7:21 ` Vaibhav Gupta 2020-07-22 7:21 ` [Linux-kernel-mentees] " Vaibhav Gupta 2020-07-22 8:33 ` [PATCH v3 0/3] block: " Vaibhav Gupta 2020-07-22 8:33 ` [Linux-kernel-mentees] " Vaibhav Gupta 2020-07-22 8:33 ` [PATCH v3 1/3] mtip32xx: " Vaibhav Gupta 2020-07-22 8:33 ` [Linux-kernel-mentees] " Vaibhav Gupta 2020-07-22 8:33 ` [PATCH v3 2/3] rsxx: " Vaibhav Gupta 2020-07-22 8:33 ` [Linux-kernel-mentees] " Vaibhav Gupta 2020-07-22 8:33 ` [PATCH v3 3/3] skd: " Vaibhav Gupta 2020-07-22 8:33 ` [Linux-kernel-mentees] " Vaibhav Gupta 2020-07-27 2:14 ` Damien Le Moal 2020-07-27 2:14 ` [Linux-kernel-mentees] " Damien Le Moal 2020-08-17 7:55 ` [PATCH v3 0/3] block: " Vaibhav Gupta 2020-08-17 7:55 ` [Linux-kernel-mentees] " Vaibhav Gupta 2021-01-14 11:54 ` [PATCH v4 " Vaibhav Gupta 2021-01-14 11:54 ` [Linux-kernel-mentees] " Vaibhav Gupta 2021-01-14 11:54 ` [PATCH v4 1/3] mtip32xx: " Vaibhav Gupta 2021-01-14 11:54 ` [Linux-kernel-mentees] " Vaibhav Gupta 2021-01-14 11:54 ` Vaibhav Gupta [this message] 2021-01-14 11:54 ` [Linux-kernel-mentees] [PATCH v4 2/3] rsxx: " Vaibhav Gupta 2021-01-14 11:54 ` [PATCH v4 3/3] skd: " Vaibhav Gupta 2021-01-14 11:54 ` [Linux-kernel-mentees] " Vaibhav Gupta 2020-07-22 17:52 ` [PATCH v2 " Bjorn Helgaas 2020-07-22 17:52 ` [Linux-kernel-mentees] " Bjorn Helgaas 2020-07-22 18:07 ` Vaibhav Gupta 2020-07-22 18:07 ` [Linux-kernel-mentees] " Vaibhav Gupta
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210114115423.52414-3-vaibhavgupta40@gmail.com \ --to=vaibhavgupta40@gmail.com \ --cc=Damien.LeMoal@wdc.com \ --cc=axboe@kernel.dk \ --cc=bhelgaas@google.com \ --cc=bjorn@helgaas.com \ --cc=helgaas@kernel.org \ --cc=josh.h.morris@us.ibm.com \ --cc=linux-block@vger.kernel.org \ --cc=linux-kernel-mentees@lists.linuxfoundation.org \ --cc=linux-kernel@vger.kernel.org \ --cc=pjk1939@linux.ibm.com \ --cc=skhan@linuxfoundation.org \ --cc=vaibhav.varodek@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.