All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Chia-Wei, Wang" <chiawei_wang@aspeedtech.com>
To: <robh+dt@kernel.org>, <lee.jones@linaro.org>, <joel@jms.id.au>,
	<andrew@aj.id.au>, <linus.walleij@linaro.org>, <minyard@acm.org>,
	<devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-aspeed@lists.ozlabs.org>, <linux-kernel@vger.kernel.org>,
	<openbmc@lists.ozlabs.org>
Cc: <BMC-SW@aspeedtech.com>, <haiyue.wang@linux.intel.com>,
	<cyrilbur@gmail.com>, <rlippert@google.com>
Subject: [PATCH v5 0/5] Remove LPC register partitioning
Date: Thu, 14 Jan 2021 21:16:17 +0800	[thread overview]
Message-ID: <20210114131622.8951-1-chiawei_wang@aspeedtech.com> (raw)

The LPC controller has no concept of the BMC and the Host partitions.
The incorrect partitioning can impose unnecessary range restrictions
on register access through the syscon regmap interface.

For instance, HICRB contains the I/O port address configuration
of KCS channel 1/2. However, the KCS#1/#2 drivers cannot access
HICRB as it is located at the other LPC partition.

In addition, to be backward compatible, the newly added HW control
bits could be located at any reserved bits over the LPC addressing
space.

Thereby, this patch series aims to remove the LPC partitioning for
better driver development and maintenance. This requires the change
to both the device tree and the driver implementation. To ensure
both sides are synchronously updated, a v2 binding check is added.

Chagnes since v4:
	- Add child node example in dt-bindings.

Chagnes since v3:
	- Revise binding check as suggested by Haiyue Wang.

Changes since v2:
	- Add v2 binding check to ensure the synchronization between the
	  device tree change and the driver register offset fix.

Changes since v1:
	- Add the fix to the aspeed-lpc binding documentation.

Chia-Wei, Wang (5):
  dt-bindings: aspeed-lpc: Remove LPC partitioning
  ARM: dts: Remove LPC BMC and Host partitions
  ipmi: kcs: aspeed: Adapt to new LPC DTS layout
  pinctrl: aspeed-g5: Adapt to new LPC device tree layout
  soc: aspeed: Adapt to new LPC device tree layout

 .../devicetree/bindings/mfd/aspeed-lpc.txt    | 100 ++++---------
 arch/arm/boot/dts/aspeed-g4.dtsi              |  74 ++++------
 arch/arm/boot/dts/aspeed-g5.dtsi              | 135 ++++++++----------
 arch/arm/boot/dts/aspeed-g6.dtsi              | 135 ++++++++----------
 drivers/char/ipmi/kcs_bmc_aspeed.c            |  27 ++--
 drivers/pinctrl/aspeed/pinctrl-aspeed-g5.c    |  17 ++-
 drivers/soc/aspeed/aspeed-lpc-ctrl.c          |  20 ++-
 drivers/soc/aspeed/aspeed-lpc-snoop.c         |  23 +--
 8 files changed, 229 insertions(+), 302 deletions(-)

-- 
2.17.1


WARNING: multiple messages have this Message-ID (diff)
From: "Chia-Wei, Wang" <chiawei_wang@aspeedtech.com>
To: <robh+dt@kernel.org>, <lee.jones@linaro.org>, <joel@jms.id.au>,
	<andrew@aj.id.au>, <linus.walleij@linaro.org>, <minyard@acm.org>,
	<devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-aspeed@lists.ozlabs.org>, <linux-kernel@vger.kernel.org>,
	<openbmc@lists.ozlabs.org>
Cc: BMC-SW@aspeedtech.com, cyrilbur@gmail.com, haiyue.wang@linux.intel.com
Subject: [PATCH v5 0/5] Remove LPC register partitioning
Date: Thu, 14 Jan 2021 21:16:17 +0800	[thread overview]
Message-ID: <20210114131622.8951-1-chiawei_wang@aspeedtech.com> (raw)

The LPC controller has no concept of the BMC and the Host partitions.
The incorrect partitioning can impose unnecessary range restrictions
on register access through the syscon regmap interface.

For instance, HICRB contains the I/O port address configuration
of KCS channel 1/2. However, the KCS#1/#2 drivers cannot access
HICRB as it is located at the other LPC partition.

In addition, to be backward compatible, the newly added HW control
bits could be located at any reserved bits over the LPC addressing
space.

Thereby, this patch series aims to remove the LPC partitioning for
better driver development and maintenance. This requires the change
to both the device tree and the driver implementation. To ensure
both sides are synchronously updated, a v2 binding check is added.

Chagnes since v4:
	- Add child node example in dt-bindings.

Chagnes since v3:
	- Revise binding check as suggested by Haiyue Wang.

Changes since v2:
	- Add v2 binding check to ensure the synchronization between the
	  device tree change and the driver register offset fix.

Changes since v1:
	- Add the fix to the aspeed-lpc binding documentation.

Chia-Wei, Wang (5):
  dt-bindings: aspeed-lpc: Remove LPC partitioning
  ARM: dts: Remove LPC BMC and Host partitions
  ipmi: kcs: aspeed: Adapt to new LPC DTS layout
  pinctrl: aspeed-g5: Adapt to new LPC device tree layout
  soc: aspeed: Adapt to new LPC device tree layout

 .../devicetree/bindings/mfd/aspeed-lpc.txt    | 100 ++++---------
 arch/arm/boot/dts/aspeed-g4.dtsi              |  74 ++++------
 arch/arm/boot/dts/aspeed-g5.dtsi              | 135 ++++++++----------
 arch/arm/boot/dts/aspeed-g6.dtsi              | 135 ++++++++----------
 drivers/char/ipmi/kcs_bmc_aspeed.c            |  27 ++--
 drivers/pinctrl/aspeed/pinctrl-aspeed-g5.c    |  17 ++-
 drivers/soc/aspeed/aspeed-lpc-ctrl.c          |  20 ++-
 drivers/soc/aspeed/aspeed-lpc-snoop.c         |  23 +--
 8 files changed, 229 insertions(+), 302 deletions(-)

-- 
2.17.1


WARNING: multiple messages have this Message-ID (diff)
From: "Chia-Wei, Wang" <chiawei_wang@aspeedtech.com>
To: <robh+dt@kernel.org>, <lee.jones@linaro.org>, <joel@jms.id.au>,
	<andrew@aj.id.au>, <linus.walleij@linaro.org>, <minyard@acm.org>,
	<devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-aspeed@lists.ozlabs.org>, <linux-kernel@vger.kernel.org>,
	<openbmc@lists.ozlabs.org>
Cc: BMC-SW@aspeedtech.com, cyrilbur@gmail.com,
	haiyue.wang@linux.intel.com, rlippert@google.com
Subject: [PATCH v5 0/5] Remove LPC register partitioning
Date: Thu, 14 Jan 2021 21:16:17 +0800	[thread overview]
Message-ID: <20210114131622.8951-1-chiawei_wang@aspeedtech.com> (raw)

The LPC controller has no concept of the BMC and the Host partitions.
The incorrect partitioning can impose unnecessary range restrictions
on register access through the syscon regmap interface.

For instance, HICRB contains the I/O port address configuration
of KCS channel 1/2. However, the KCS#1/#2 drivers cannot access
HICRB as it is located at the other LPC partition.

In addition, to be backward compatible, the newly added HW control
bits could be located at any reserved bits over the LPC addressing
space.

Thereby, this patch series aims to remove the LPC partitioning for
better driver development and maintenance. This requires the change
to both the device tree and the driver implementation. To ensure
both sides are synchronously updated, a v2 binding check is added.

Chagnes since v4:
	- Add child node example in dt-bindings.

Chagnes since v3:
	- Revise binding check as suggested by Haiyue Wang.

Changes since v2:
	- Add v2 binding check to ensure the synchronization between the
	  device tree change and the driver register offset fix.

Changes since v1:
	- Add the fix to the aspeed-lpc binding documentation.

Chia-Wei, Wang (5):
  dt-bindings: aspeed-lpc: Remove LPC partitioning
  ARM: dts: Remove LPC BMC and Host partitions
  ipmi: kcs: aspeed: Adapt to new LPC DTS layout
  pinctrl: aspeed-g5: Adapt to new LPC device tree layout
  soc: aspeed: Adapt to new LPC device tree layout

 .../devicetree/bindings/mfd/aspeed-lpc.txt    | 100 ++++---------
 arch/arm/boot/dts/aspeed-g4.dtsi              |  74 ++++------
 arch/arm/boot/dts/aspeed-g5.dtsi              | 135 ++++++++----------
 arch/arm/boot/dts/aspeed-g6.dtsi              | 135 ++++++++----------
 drivers/char/ipmi/kcs_bmc_aspeed.c            |  27 ++--
 drivers/pinctrl/aspeed/pinctrl-aspeed-g5.c    |  17 ++-
 drivers/soc/aspeed/aspeed-lpc-ctrl.c          |  20 ++-
 drivers/soc/aspeed/aspeed-lpc-snoop.c         |  23 +--
 8 files changed, 229 insertions(+), 302 deletions(-)

-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

             reply	other threads:[~2021-01-14 13:17 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-14 13:16 Chia-Wei, Wang [this message]
2021-01-14 13:16 ` [PATCH v5 0/5] Remove LPC register partitioning Chia-Wei, Wang
2021-01-14 13:16 ` Chia-Wei, Wang
2021-01-14 13:16 ` [PATCH v5 1/5] dt-bindings: aspeed-lpc: Remove LPC partitioning Chia-Wei, Wang
2021-01-14 13:16   ` Chia-Wei, Wang
2021-01-14 13:16   ` Chia-Wei, Wang
2021-01-20  4:57   ` Andrew Jeffery
2021-01-20  4:57     ` Andrew Jeffery
2021-01-20  4:57     ` Andrew Jeffery
2021-01-25 21:25   ` Rob Herring
2021-01-25 21:25     ` Rob Herring
2021-01-25 21:25     ` Rob Herring
2021-01-27  0:24   ` Andrew Jeffery
2021-01-27  0:24     ` Andrew Jeffery
2021-01-27  0:24     ` Andrew Jeffery
2021-02-17  7:40     ` ChiaWei Wang
2021-02-17  7:40       ` ChiaWei Wang
2021-02-17  7:40       ` ChiaWei Wang
2021-02-17  7:44       ` Joel Stanley
2021-02-17  7:44         ` Joel Stanley
2021-02-17  7:44         ` Joel Stanley
2021-02-17  8:04         ` ChiaWei Wang
2021-02-17  8:04           ` ChiaWei Wang
2021-02-17  8:04           ` ChiaWei Wang
2021-02-17  8:04         ` Andrew Jeffery
2021-02-17  8:04           ` Andrew Jeffery
2021-02-17  8:04           ` Andrew Jeffery
2021-01-14 13:16 ` [PATCH v5 2/5] ARM: dts: Remove LPC BMC and Host partitions Chia-Wei, Wang
2021-01-14 13:16   ` Chia-Wei, Wang
2021-01-14 13:16   ` Chia-Wei, Wang
2021-01-20  5:01   ` Andrew Jeffery
2021-01-20  5:01     ` Andrew Jeffery
2021-01-20  5:01     ` Andrew Jeffery
2021-01-25  4:12   ` Andrew Jeffery
2021-01-25  4:12     ` Andrew Jeffery
2021-01-25  4:12     ` Andrew Jeffery
2021-01-14 13:16 ` [PATCH v5 3/5] ipmi: kcs: aspeed: Adapt to new LPC DTS layout Chia-Wei, Wang
2021-01-14 13:16   ` Chia-Wei, Wang
2021-01-14 13:16   ` Chia-Wei, Wang
2021-01-20  5:02   ` Andrew Jeffery
2021-01-20  5:02     ` Andrew Jeffery
2021-01-20  5:02     ` Andrew Jeffery
2021-01-22  9:55     ` ChiaWei Wang
2021-01-22  9:55       ` ChiaWei Wang
2021-01-22  9:55       ` ChiaWei Wang
2021-01-22 15:31       ` Corey Minyard
2021-01-22 15:31         ` Corey Minyard
2021-01-22 15:31         ` Corey Minyard
2021-01-14 13:16 ` [PATCH v5 4/5] pinctrl: aspeed-g5: Adapt to new LPC device tree layout Chia-Wei, Wang
2021-01-14 13:16   ` Chia-Wei, Wang
2021-01-14 13:16   ` Chia-Wei, Wang
2021-01-18 14:59   ` Linus Walleij
2021-01-18 14:59     ` Linus Walleij
2021-01-18 14:59     ` Linus Walleij
2021-01-20  5:03   ` Andrew Jeffery
2021-01-20  5:03     ` Andrew Jeffery
2021-01-20  5:03     ` Andrew Jeffery
2021-01-25  4:14   ` Andrew Jeffery
2021-01-25  4:14     ` Andrew Jeffery
2021-01-25  4:14     ` Andrew Jeffery
2021-01-14 13:16 ` [PATCH v5 5/5] soc: aspeed: " Chia-Wei, Wang
2021-01-14 13:16   ` Chia-Wei, Wang
2021-01-14 13:16   ` Chia-Wei, Wang
2021-01-20  5:10   ` Andrew Jeffery
2021-01-20  5:10     ` Andrew Jeffery
2021-01-20  5:10     ` Andrew Jeffery
2021-01-25  4:15   ` Andrew Jeffery
2021-01-25  4:15     ` Andrew Jeffery
2021-01-25  4:15     ` Andrew Jeffery
2021-01-26  5:51 ` [PATCH v5 0/5] Remove LPC register partitioning ChiaWei Wang
2021-01-26  5:51   ` ChiaWei Wang
2021-01-26  5:51   ` ChiaWei Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210114131622.8951-1-chiawei_wang@aspeedtech.com \
    --to=chiawei_wang@aspeedtech.com \
    --cc=BMC-SW@aspeedtech.com \
    --cc=andrew@aj.id.au \
    --cc=cyrilbur@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=haiyue.wang@linux.intel.com \
    --cc=joel@jms.id.au \
    --cc=lee.jones@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=minyard@acm.org \
    --cc=openbmc@lists.ozlabs.org \
    --cc=rlippert@google.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.