All of lore.kernel.org
 help / color / mirror / Atom feed
From: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>
To: ulf.hansson@linaro.org, broonie@kernel.org, lgirdwood@gmail.com,
	robh+dt@kernel.org, devicetree@vger.kernel.org,
	adrian.hunter@intel.com, michal.simek@xilinx.com,
	linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: andriy.shevchenko@intel.com, Rashmi.A@intel.com,
	mahesh.r.vaidya@intel.com, muhammad.husaini.zulkifli@intel.com
Subject: [PATCH v1 2/9] mmc: sdhci-of-arasan: Convert to use np instead of pdev->dev.of_node
Date: Thu, 14 Jan 2021 23:26:53 +0800	[thread overview]
Message-ID: <20210114152700.21916-3-muhammad.husaini.zulkifli@intel.com> (raw)
In-Reply-To: <20210114152700.21916-1-muhammad.husaini.zulkifli@intel.com>

Use np pointer to simplify code and improve readability.

Signed-off-by: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>
Suggested-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
Acked-by: Andy Shevchenko <andriy.shevchenko@intel.com>
---
 drivers/mmc/host/sdhci-of-arasan.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
index 07479019caf9..ecaea4b45367 100644
--- a/drivers/mmc/host/sdhci-of-arasan.c
+++ b/drivers/mmc/host/sdhci-of-arasan.c
@@ -1529,7 +1529,7 @@ static int sdhci_arasan_probe(struct platform_device *pdev)
 	sdhci_arasan->soc_ctl_map = data->soc_ctl_map;
 	sdhci_arasan->clk_ops = data->clk_ops;
 
-	node = of_parse_phandle(pdev->dev.of_node, "arasan,soc-ctl-syscon", 0);
+	node = of_parse_phandle(np, "arasan,soc-ctl-syscon", 0);
 	if (node) {
 		sdhci_arasan->soc_ctl_base = syscon_node_to_regmap(node);
 		of_node_put(node);
@@ -1578,8 +1578,7 @@ static int sdhci_arasan_probe(struct platform_device *pdev)
 
 	pltfm_host->clk = clk_xin;
 
-	if (of_device_is_compatible(pdev->dev.of_node,
-				    "rockchip,rk3399-sdhci-5.1"))
+	if (of_device_is_compatible(np, "rockchip,rk3399-sdhci-5.1"))
 		sdhci_arasan_update_clockmultiplier(host, 0x0);
 
 	if (of_device_is_compatible(np, "intel,keembay-sdhci-5.1-emmc") ||
@@ -1612,8 +1611,7 @@ static int sdhci_arasan_probe(struct platform_device *pdev)
 	}
 
 	sdhci_arasan->phy = ERR_PTR(-ENODEV);
-	if (of_device_is_compatible(pdev->dev.of_node,
-				    "arasan,sdhci-5.1")) {
+	if (of_device_is_compatible(np, "arasan,sdhci-5.1")) {
 		sdhci_arasan->phy = devm_phy_get(&pdev->dev,
 						 "phy_arasan");
 		if (IS_ERR(sdhci_arasan->phy)) {
-- 
2.17.1


  parent reply	other threads:[~2021-01-14 15:29 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-14 15:26 [PATCH v1 0/9] mmc: sdhci-of-arasan: Add UHS-1 support for Keem Bay SOC Muhammad Husaini Zulkifli
2021-01-14 15:26 ` [PATCH v1 1/9] mmc: sdhci-of-arasan: use of_device_get_match_data() Muhammad Husaini Zulkifli
2021-01-14 15:26 ` Muhammad Husaini Zulkifli [this message]
2021-01-14 15:26 ` [PATCH v1 3/9] mmc: sdhci-of-arasan: Add structure device pointer in probe function Muhammad Husaini Zulkifli
2021-01-14 15:26 ` [PATCH v1 4/9] mmc: sdhci-of-arasan: Use dev_err_probe() to avoid spamming logs Muhammad Husaini Zulkifli
2021-01-14 15:26 ` [PATCH v1 5/9] firmware: keembay: Add support for Trusted Firmware Service call Muhammad Husaini Zulkifli
2021-01-14 16:48   ` Mark Brown
2021-01-15 18:58     ` Sudeep Holla
2021-01-18 10:28       ` Zulkifli, Muhammad Husaini
2021-01-18 11:19         ` Mark Brown
2021-01-18 11:55         ` Sudeep Holla
2021-01-18 12:01         ` Cristian Marussi
2021-01-19  2:38           ` Zulkifli, Muhammad Husaini
2021-01-19 17:20             ` Sudeep Holla
2021-01-14 15:26 ` [PATCH v1 6/9] dt-bindings: mmc: Update phy and regulator supply for Keem Bay SOC Muhammad Husaini Zulkifli
2021-01-14 15:26 ` [PATCH v1 7/9] dt-bindings: regulator: keembay: Add DT binding documentation Muhammad Husaini Zulkifli
2021-01-14 16:52   ` Mark Brown
2021-01-14 15:26 ` [PATCH v1 8/9] regulator: keembay: Add regulator for Keem Bay SoC Muhammad Husaini Zulkifli
2021-01-14 17:14   ` Mark Brown
2021-01-15 19:14     ` Sudeep Holla
2021-01-14 15:27 ` [PATCH v1 9/9] mmc: sdhci-of-arasan: Add UHS-1 support for Keem Bay SOC Muhammad Husaini Zulkifli
2021-01-25 21:37   ` Rob Herring
2021-01-19 13:42 ` [PATCH v1 0/9] " Ulf Hansson
2021-01-20  4:24   ` Zulkifli, Muhammad Husaini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210114152700.21916-3-muhammad.husaini.zulkifli@intel.com \
    --to=muhammad.husaini.zulkifli@intel.com \
    --cc=Rashmi.A@intel.com \
    --cc=adrian.hunter@intel.com \
    --cc=andriy.shevchenko@intel.com \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=mahesh.r.vaidya@intel.com \
    --cc=michal.simek@xilinx.com \
    --cc=robh+dt@kernel.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.