All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leo Yan <leo.yan@linaro.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>,
	Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Joe Mario <jmario@redhat.com>, David Ahern <dsahern@gmail.com>,
	Don Zickus <dzickus@redhat.com>, Joe Perches <joe@perches.com>,
	linux-kernel@vger.kernel.org
Cc: Leo Yan <leo.yan@linaro.org>
Subject: [PATCH v4 4/6] perf c2c: Fix argument type for percent()
Date: Thu, 14 Jan 2021 23:46:44 +0800	[thread overview]
Message-ID: <20210114154646.209024-5-leo.yan@linaro.org> (raw)
In-Reply-To: <20210114154646.209024-1-leo.yan@linaro.org>

For percent(), its arguments are defined as integer type; this is not
consistent with its consumers which pass arguments with u32 type.

Thus this patch makes argument type as u32 for percent().

Signed-off-by: Leo Yan <leo.yan@linaro.org>
---
 tools/perf/builtin-c2c.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/builtin-c2c.c b/tools/perf/builtin-c2c.c
index 7aaccea00883..7702f9599162 100644
--- a/tools/perf/builtin-c2c.c
+++ b/tools/perf/builtin-c2c.c
@@ -876,7 +876,7 @@ static struct c2c_stats *total_stats(struct hist_entry *he)
 	return &hists->stats;
 }
 
-static double percent(int st, int tot)
+static double percent(u32 st, u32 tot)
 {
 	return tot ? 100. * (double) st / (double) tot : 0;
 }
-- 
2.25.1


  parent reply	other threads:[~2021-01-14 15:47 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-14 15:46 [PATCH v4 0/6] perf c2c: Code refactoring Leo Yan
2021-01-14 15:46 ` [PATCH v4 1/6] perf c2c: Rename for shared cache line stats Leo Yan
2021-01-14 15:46 ` [PATCH v4 2/6] perf c2c: Refactor hist entry validation Leo Yan
2021-01-14 15:46 ` [PATCH v4 3/6] perf c2c: Refactor display filter Leo Yan
2021-01-14 15:46 ` Leo Yan [this message]
2021-01-14 15:46 ` [PATCH v4 5/6] perf c2c: Refactor node display Leo Yan
2021-01-14 15:46 ` [PATCH v4 6/6] perf c2c: Add local variables for output metrics Leo Yan
2021-01-15  7:30 ` [PATCH v4 0/6] perf c2c: Code refactoring Namhyung Kim
2021-01-15  8:44 ` Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210114154646.209024-5-leo.yan@linaro.org \
    --to=leo.yan@linaro.org \
    --cc=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=dsahern@gmail.com \
    --cc=dzickus@redhat.com \
    --cc=jmario@redhat.com \
    --cc=joe@perches.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.