All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH 3/7] drm/i915: Remove dead signal level debugs
Date: Thu, 14 Jan 2021 22:50:42 +0200	[thread overview]
Message-ID: <20210114205046.8247-4-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20210114205046.8247-1-ville.syrjala@linux.intel.com>

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

If we ever get here with bogus signal levels we've messed
up somewhere earlier. Just use MISSIN_CASE().

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_dp.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index 10930884ce42..2b276549cecd 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -3955,8 +3955,7 @@ static u32 snb_cpu_edp_signal_levels(u8 train_set)
 	case DP_TRAIN_VOLTAGE_SWING_LEVEL_3 | DP_TRAIN_PRE_EMPH_LEVEL_0:
 		return EDP_LINK_TRAIN_800_1200MV_0DB_SNB_B;
 	default:
-		DRM_DEBUG_KMS("Unsupported voltage swing/pre-emphasis level:"
-			      "0x%x\n", signal_levels);
+		MISSING_CASE(signal_levels);
 		return EDP_LINK_TRAIN_400_600MV_0DB_SNB_B;
 	}
 }
@@ -4007,8 +4006,7 @@ static u32 ivb_cpu_edp_signal_levels(u8 train_set)
 		return EDP_LINK_TRAIN_800MV_3_5DB_IVB;
 
 	default:
-		DRM_DEBUG_KMS("Unsupported voltage swing/pre-emphasis level:"
-			      "0x%x\n", signal_levels);
+		MISSING_CASE(signal_levels);
 		return EDP_LINK_TRAIN_500MV_0DB_IVB;
 	}
 }
-- 
2.26.2

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2021-01-14 20:51 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-14 20:50 [Intel-gfx] [PATCH 0/7] drm/i915: Shuffle DP code around Ville Syrjala
2021-01-14 20:50 ` [Intel-gfx] [PATCH 1/7] drm/i915: Fix the training pattern debug print Ville Syrjala
2021-01-14 20:50 ` [Intel-gfx] [PATCH 2/7] drm/i915: Remove dead TPS3->TPS2 fallback code Ville Syrjala
2021-01-14 20:50 ` Ville Syrjala [this message]
2021-01-14 20:50 ` [Intel-gfx] [PATCH 4/7] drm/i915: Relocate intel_dp_program_link_training_pattern() Ville Syrjala
2021-01-14 20:50 ` [Intel-gfx] [PATCH 5/7] drm/i915: Split intel_ddi_encoder_reset() from intel_dp_encoder_reset() Ville Syrjala
2021-01-14 20:50 ` [Intel-gfx] [PATCH 6/7] drm/i915: Fix the PHY compliance test vs. hotplug mishap Ville Syrjala
2021-01-18 15:15   ` Imre Deak
2021-01-14 20:50 ` [Intel-gfx] [PATCH 7/7] drm/i915: Introduce g4x_dp.c Ville Syrjala
2021-01-14 22:13 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Shuffle DP code around Patchwork
2021-01-14 22:44 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-01-15 10:13 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210114205046.8247-4-ville.syrjala@linux.intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.