From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Laurent Vivier" <laurent@vivier.eu>
Subject: [RFC PATCH] meson: Only install ROMs when building system emulation binaries
Date: Fri, 15 Jan 2021 18:51:34 +0100 [thread overview]
Message-ID: <20210115175135.3402714-1-philmd@redhat.com> (raw)
It is pointless to install ROM blobs for user emulation.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
RFC because I think it would be better to make the 'blobs'
option a 'feature' instead of a boolean so we can set it
as 'auto' and then in that case we could do something
blobs = have_system
because currently ./configure still displays:
Install blobs: YES
which is confusing.
---
meson.build | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/meson.build b/meson.build
index 954152c90fe..273b8e6baa9 100644
--- a/meson.build
+++ b/meson.build
@@ -2254,7 +2254,9 @@
subdir('scripts')
subdir('tools')
-subdir('pc-bios')
+if have_system
+ subdir('pc-bios')
+endif
subdir('docs')
subdir('tests')
if gtk.found()
--
2.26.2
next reply other threads:[~2021-01-15 17:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-15 17:51 Philippe Mathieu-Daudé [this message]
2021-01-15 18:53 ` [RFC PATCH] meson: Only install ROMs when building system emulation binaries Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210115175135.3402714-1-philmd@redhat.com \
--to=philmd@redhat.com \
--cc=laurent@vivier.eu \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.