All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, vsementsov@virtuozzo.com, berto@igalia.com,
	pavel.dovgaluk@ispras.ru, qemu-devel@nongnu.org,
	armbru@redhat.com, Greg Kurz <groug@kaod.org>,
	stefanha@redhat.com, pbonzini@redhat.com, mreitz@redhat.com,
	jsnow@redhat.com, ari@tuxera.com
Subject: [PATCH v6 05/14] block: drop extra error propagation for bdrv_set_backing_hd
Date: Sun, 17 Jan 2021 00:52:00 +0300	[thread overview]
Message-ID: <20210116215209.823266-6-vsementsov@virtuozzo.com> (raw)
In-Reply-To: <20210116215209.823266-1-vsementsov@virtuozzo.com>

bdrv_set_backing_hd now returns status, let's use it.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Alberto Garcia <berto@igalia.com>
---
 block.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/block.c b/block.c
index 0951d3b2c1..9483edb500 100644
--- a/block.c
+++ b/block.c
@@ -2973,11 +2973,9 @@ int bdrv_open_backing_file(BlockDriverState *bs, QDict *parent_options,
 
     /* Hook up the backing file link; drop our reference, bs owns the
      * backing_hd reference now */
-    bdrv_set_backing_hd(bs, backing_hd, &local_err);
+    ret = bdrv_set_backing_hd(bs, backing_hd, errp);
     bdrv_unref(backing_hd);
-    if (local_err) {
-        error_propagate(errp, local_err);
-        ret = -EINVAL;
+    if (ret < 0) {
         goto free_exit;
     }
 
-- 
2.29.2



  parent reply	other threads:[~2021-01-16 22:02 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-16 21:51 [PATCH v6 00/14] block: deal with errp: part I Vladimir Sementsov-Ogievskiy
2021-01-16 21:51 ` [PATCH v6 01/14] block: return status from bdrv_append and friends Vladimir Sementsov-Ogievskiy
2021-01-27 15:54   ` Alberto Garcia
2021-01-16 21:51 ` [PATCH v6 02/14] block: use return status of bdrv_append() Vladimir Sementsov-Ogievskiy
2021-01-16 21:51 ` [PATCH v6 03/14] block: check return value of bdrv_open_child and drop error propagation Vladimir Sementsov-Ogievskiy
2021-01-16 21:51 ` [PATCH v6 04/14] blockdev: fix drive_backup_prepare() missed error Vladimir Sementsov-Ogievskiy
2021-01-16 21:52 ` Vladimir Sementsov-Ogievskiy [this message]
2021-01-16 21:52 ` [PATCH v6 06/14] block/mirror: drop extra error propagation in commit_active_start() Vladimir Sementsov-Ogievskiy
2021-01-16 21:52 ` [PATCH v6 07/14] blockjob: return status from block_job_set_speed() Vladimir Sementsov-Ogievskiy
2021-01-16 21:52 ` [PATCH v6 08/14] block/qcow2: qcow2_get_specific_info(): drop error propagation Vladimir Sementsov-Ogievskiy
2021-01-16 21:52 ` [PATCH v6 09/14] block/qcow2-bitmap: improve qcow2_load_dirty_bitmaps() interface Vladimir Sementsov-Ogievskiy
2021-01-16 21:52 ` [PATCH v6 10/14] block/qcow2-bitmap: return status from qcow2_store_persistent_dirty_bitmaps Vladimir Sementsov-Ogievskiy
2021-01-16 21:52 ` [PATCH v6 11/14] block/qcow2: read_cache_sizes: return status value Vladimir Sementsov-Ogievskiy
2021-01-16 21:52 ` [PATCH v6 12/14] block/qcow2: simplify qcow2_co_invalidate_cache() Vladimir Sementsov-Ogievskiy
2021-01-16 21:52 ` [PATCH v6 13/14] block/qed: bdrv_qed_do_open: deal with errp Vladimir Sementsov-Ogievskiy
2021-01-16 21:52 ` [PATCH v6 14/14] block/qcow2: refactor qcow2_update_options_prepare error paths Vladimir Sementsov-Ogievskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210116215209.823266-6-vsementsov@virtuozzo.com \
    --to=vsementsov@virtuozzo.com \
    --cc=ari@tuxera.com \
    --cc=armbru@redhat.com \
    --cc=berto@igalia.com \
    --cc=groug@kaod.org \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=pavel.dovgaluk@ispras.ru \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.