All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chandan Babu R <chandanrlinux@gmail.com>
To: fstests@vger.kernel.org
Cc: Chandan Babu R <chandanrlinux@gmail.com>,
	linux-xfs@vger.kernel.org, darrick.wong@oracle.com,
	djwong@kernel.org
Subject: [PATCH V4 07/11] xfs: Check for extent overflow when writing to unwritten extent
Date: Mon, 18 Jan 2021 11:50:18 +0530	[thread overview]
Message-ID: <20210118062022.15069-8-chandanrlinux@gmail.com> (raw)
In-Reply-To: <20210118062022.15069-1-chandanrlinux@gmail.com>

This test verifies that XFS does not cause inode fork's extent count to
overflow when writing to an unwritten extent.

Signed-off-by: Chandan Babu R <chandanrlinux@gmail.com>
---
 tests/xfs/527     | 89 +++++++++++++++++++++++++++++++++++++++++++++++
 tests/xfs/527.out | 11 ++++++
 tests/xfs/group   |  1 +
 3 files changed, 101 insertions(+)
 create mode 100755 tests/xfs/527
 create mode 100644 tests/xfs/527.out

diff --git a/tests/xfs/527 b/tests/xfs/527
new file mode 100755
index 00000000..cd67bce4
--- /dev/null
+++ b/tests/xfs/527
@@ -0,0 +1,89 @@
+#! /bin/bash
+# SPDX-License-Identifier: GPL-2.0
+# Copyright (c) 2020 Chandan Babu R.  All Rights Reserved.
+#
+# FS QA Test 527
+#
+# Verify that XFS does not cause inode fork's extent count to overflow when
+# writing to an unwritten extent.
+seq=`basename $0`
+seqres=$RESULT_DIR/$seq
+echo "QA output created by $seq"
+
+here=`pwd`
+tmp=/tmp/$$
+status=1	# failure is the default!
+trap "_cleanup; exit \$status" 0 1 2 3 15
+
+_cleanup()
+{
+	cd /
+	rm -f $tmp.*
+}
+
+# get standard environment, filters and checks
+. ./common/rc
+. ./common/filter
+. ./common/inject
+
+# remove previous $seqres.full before test
+rm -f $seqres.full
+
+# real QA test starts here
+
+_supported_fs xfs
+_require_scratch
+_require_xfs_debug
+_require_xfs_io_command "falloc"
+_require_xfs_io_error_injection "reduce_max_iextents"
+
+echo "Format and mount fs"
+_scratch_mkfs_sized $((1024 * 1024 * 1024)) >> $seqres.full
+_scratch_mount >> $seqres.full
+
+bsize=$(_get_file_block_size $SCRATCH_MNT)
+
+testfile=${SCRATCH_MNT}/testfile
+
+echo "Inject reduce_max_iextents error tag"
+_scratch_inject_error reduce_max_iextents 1
+
+nr_blks=15
+
+for io in Buffered Direct; do
+	echo "* $io write to unwritten extent"
+
+	echo "Fallocate $nr_blks blocks"
+	$XFS_IO_PROG -f -c "falloc 0 $((nr_blks * bsize))" $testfile >> $seqres.full
+
+	if [[ $io == "Buffered" ]]; then
+		xfs_io_flag=""
+	else
+		xfs_io_flag="-d"
+	fi
+
+	echo "$io write to every other block of fallocated space"
+	for i in $(seq 1 2 $((nr_blks - 1))); do
+		$XFS_IO_PROG -f -s $xfs_io_flag -c "pwrite $((i * bsize)) $bsize" \
+		       $testfile >> $seqres.full 2>&1
+		[[ $? != 0 ]] && break
+	done
+
+	echo "Verify \$testfile's extent count"
+	nextents=$($XFS_IO_PROG -c 'stat' $testfile | grep nextents)
+	nextents=${nextents##fsxattr.nextents = }
+	if (( $nextents > 10 )); then
+		echo "Extent count overflow check failed: nextents = $nextents"
+		exit 1
+	fi
+
+	rm $testfile
+done
+
+# super_block->s_wb_err will have a newer seq value when compared to "/"'s
+# file->f_sb_err. Consume it here so that xfs_scrub can does not error out.
+$XFS_IO_PROG -c syncfs $SCRATCH_MNT >> $seqres.full 2>&1
+
+# success, all done
+status=0
+exit
diff --git a/tests/xfs/527.out b/tests/xfs/527.out
new file mode 100644
index 00000000..3597ad92
--- /dev/null
+++ b/tests/xfs/527.out
@@ -0,0 +1,11 @@
+QA output created by 527
+Format and mount fs
+Inject reduce_max_iextents error tag
+* Buffered write to unwritten extent
+Fallocate 15 blocks
+Buffered write to every other block of fallocated space
+Verify $testfile's extent count
+* Direct write to unwritten extent
+Fallocate 15 blocks
+Direct write to every other block of fallocated space
+Verify $testfile's extent count
diff --git a/tests/xfs/group b/tests/xfs/group
index d089797b..627813fe 100644
--- a/tests/xfs/group
+++ b/tests/xfs/group
@@ -524,3 +524,4 @@
 524 auto quick punch zero insert collapse
 525 auto quick attr
 526 auto quick dir hardlink symlink
+527 auto quick
-- 
2.29.2


  parent reply	other threads:[~2021-01-18  6:23 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-18  6:20 [PATCH V4 00/11] xfs: Tests to verify inode fork extent count overflow detection Chandan Babu R
2021-01-18  6:20 ` [PATCH V4 01/11] common/xfs: Add a helper to get an inode fork's extent count Chandan Babu R
2021-03-03 17:30   ` Darrick J. Wong
2021-03-05 14:41     ` Chandan Babu R
2021-01-18  6:20 ` [PATCH V4 02/11] xfs: Check for extent overflow when trivally adding a new extent Chandan Babu R
2021-03-03 17:38   ` Darrick J. Wong
2021-03-05 14:42     ` Chandan Babu R
2021-01-18  6:20 ` [PATCH V4 03/11] xfs: Check for extent overflow when growing realtime bitmap/summary inodes Chandan Babu R
2021-03-03 17:45   ` Darrick J. Wong
2021-03-04 11:58     ` Chandan Babu R
2021-03-04 16:17       ` Darrick J. Wong
2021-01-18  6:20 ` [PATCH V4 04/11] xfs: Check for extent overflow when punching a hole Chandan Babu R
2021-03-03 17:54   ` Darrick J. Wong
2021-01-18  6:20 ` [PATCH V4 05/11] xfs: Check for extent overflow when adding/removing xattrs Chandan Babu R
2021-03-03 17:56   ` Darrick J. Wong
2021-01-18  6:20 ` [PATCH V4 06/11] xfs: Check for extent overflow when adding/removing dir entries Chandan Babu R
2021-03-03 18:01   ` Darrick J. Wong
2021-03-04 12:22     ` Chandan Babu R
2021-01-18  6:20 ` Chandan Babu R [this message]
2021-03-03 18:05   ` [PATCH V4 07/11] xfs: Check for extent overflow when writing to unwritten extent Darrick J. Wong
2021-03-05 14:43     ` Chandan Babu R
2021-01-18  6:20 ` [PATCH V4 08/11] xfs: Check for extent overflow when moving extent from cow to data fork Chandan Babu R
2021-03-03 18:07   ` Darrick J. Wong
2021-01-18  6:20 ` [PATCH V4 09/11] xfs: Check for extent overflow when remapping an extent Chandan Babu R
2021-03-03 18:09   ` Darrick J. Wong
2021-01-18  6:20 ` [PATCH V4 10/11] xfs: Check for extent overflow when swapping extents Chandan Babu R
2021-03-03 18:10   ` Darrick J. Wong
2021-01-18  6:20 ` [PATCH V4 11/11] xfs: Stress test with bmap_alloc_minlen_extent error tag enabled Chandan Babu R
2021-03-03 18:12   ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210118062022.15069-8-chandanrlinux@gmail.com \
    --to=chandanrlinux@gmail.com \
    --cc=darrick.wong@oracle.com \
    --cc=djwong@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.