From: Heiko Stuebner <heiko@sntech.de> To: dafna.hirschfeld@collabora.com, helen.koike@collabora.com, linux-media@vger.kernel.org, mchehab@kernel.org, Laurent.pinchart@ideasonboard.com, hverkuil@xs4all.nl Cc: linux-rockchip@lists.infradead.org, ezequiel@collabora.com, christoph.muellner@theobroma-systems.com, heiko@sntech.de, tfiga@chromium.org Subject: [PATCH v6 0/4] Fix the rkisp1 userspace API for later IP versions Date: Mon, 18 Jan 2021 12:04:44 +0100 [thread overview] Message-ID: <20210118110448.275389-1-heiko@sntech.de> (raw) This NEEDs to go into 5.11 while we can still adapt the uapi during its RC-cycle. When looking into supporting the rkisp1 of the px30 I noticed that some fields got bigger in the uapi, caused by bigger number of samples for example for histograms or gamma values. The rkisp1 was destaged with 5.11-rc1 so we have still time during the 5.11 cycle to fix that without big hassles. This was discussed previously in a mail [0] and a rfc series [1] and this two-part series now splits out the important parts that really should become part of a 5.11-rc and thus the final 5.11. changes since v5: - move grid reduction for V10 to separate patch (Hans) - fix commit message (histogram size 28 -> 25) in patch4 (Hans) changes since v4: - set GAMMA_OUT to the real 25 instead of the 28 with 3 spares (Dafna) - start RKISP_Vxx enum with 10 for RKISP_V10 to make output easier and also allow userspace to differentiate between old (= 0) and newer driver variants (Dafna, Laurent) changes since v3: - add patch fixing the original histogram size comment - make comments in uapi more verbose (Hans) - fix wording in admin guide (Hans) - document version <-> soc in uapi as well (easier for people) (Dafna) changes since v2: - actually zero the correct sizes for u16 values (hist-bins) (kernel-test-robot) changes since v1: - drop duplicate isp_ver storage, hw_revision is enough (Dafna) - document multiple maximum sizes in uapi (Hans) - document usage of hw_revision field (Hans) - zero fields transmitted to userspace before adding data (Hans) - use _V10 field sizes when filling fields, as there is only v10 for now changes since rfc: - move rkisp1_version enum into uapo - show version in media-api hw_revision - introduce constants for versions and make max use the biggest Heiko Stuebner (4): media: rockchip: rkisp1: fix comment about number of histogram sub-windows media: rockchip: rkisp1: reduce number of histogram grid elements in uapi media: rockchip: rkisp1: carry ip version information media: rockchip: rkisp1: extend uapi array sizes Documentation/admin-guide/media/rkisp1.rst | 16 ++++ .../platform/rockchip/rkisp1/rkisp1-dev.c | 21 +++--- .../platform/rockchip/rkisp1/rkisp1-params.c | 2 +- .../platform/rockchip/rkisp1/rkisp1-stats.c | 12 ++- include/uapi/linux/rkisp1-config.h | 75 +++++++++++++++++-- 5 files changed, 106 insertions(+), 20 deletions(-) -- 2.29.2
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de> To: dafna.hirschfeld@collabora.com, helen.koike@collabora.com, linux-media@vger.kernel.org, mchehab@kernel.org, Laurent.pinchart@ideasonboard.com, hverkuil@xs4all.nl Cc: linux-rockchip@lists.infradead.org, tfiga@chromium.org, ezequiel@collabora.com, heiko@sntech.de, christoph.muellner@theobroma-systems.com Subject: [PATCH v6 0/4] Fix the rkisp1 userspace API for later IP versions Date: Mon, 18 Jan 2021 12:04:44 +0100 [thread overview] Message-ID: <20210118110448.275389-1-heiko@sntech.de> (raw) This NEEDs to go into 5.11 while we can still adapt the uapi during its RC-cycle. When looking into supporting the rkisp1 of the px30 I noticed that some fields got bigger in the uapi, caused by bigger number of samples for example for histograms or gamma values. The rkisp1 was destaged with 5.11-rc1 so we have still time during the 5.11 cycle to fix that without big hassles. This was discussed previously in a mail [0] and a rfc series [1] and this two-part series now splits out the important parts that really should become part of a 5.11-rc and thus the final 5.11. changes since v5: - move grid reduction for V10 to separate patch (Hans) - fix commit message (histogram size 28 -> 25) in patch4 (Hans) changes since v4: - set GAMMA_OUT to the real 25 instead of the 28 with 3 spares (Dafna) - start RKISP_Vxx enum with 10 for RKISP_V10 to make output easier and also allow userspace to differentiate between old (= 0) and newer driver variants (Dafna, Laurent) changes since v3: - add patch fixing the original histogram size comment - make comments in uapi more verbose (Hans) - fix wording in admin guide (Hans) - document version <-> soc in uapi as well (easier for people) (Dafna) changes since v2: - actually zero the correct sizes for u16 values (hist-bins) (kernel-test-robot) changes since v1: - drop duplicate isp_ver storage, hw_revision is enough (Dafna) - document multiple maximum sizes in uapi (Hans) - document usage of hw_revision field (Hans) - zero fields transmitted to userspace before adding data (Hans) - use _V10 field sizes when filling fields, as there is only v10 for now changes since rfc: - move rkisp1_version enum into uapo - show version in media-api hw_revision - introduce constants for versions and make max use the biggest Heiko Stuebner (4): media: rockchip: rkisp1: fix comment about number of histogram sub-windows media: rockchip: rkisp1: reduce number of histogram grid elements in uapi media: rockchip: rkisp1: carry ip version information media: rockchip: rkisp1: extend uapi array sizes Documentation/admin-guide/media/rkisp1.rst | 16 ++++ .../platform/rockchip/rkisp1/rkisp1-dev.c | 21 +++--- .../platform/rockchip/rkisp1/rkisp1-params.c | 2 +- .../platform/rockchip/rkisp1/rkisp1-stats.c | 12 ++- include/uapi/linux/rkisp1-config.h | 75 +++++++++++++++++-- 5 files changed, 106 insertions(+), 20 deletions(-) -- 2.29.2 _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip
next reply other threads:[~2021-01-18 11:06 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-18 11:04 Heiko Stuebner [this message] 2021-01-18 11:04 ` [PATCH v6 0/4] Fix the rkisp1 userspace API for later IP versions Heiko Stuebner 2021-01-18 11:04 ` [PATCH v6 1/4] media: rockchip: rkisp1: fix comment about number of histogram sub-windows Heiko Stuebner 2021-01-18 11:04 ` Heiko Stuebner 2021-01-18 18:03 ` Helen Koike 2021-01-18 18:03 ` Helen Koike 2021-01-18 11:04 ` [PATCH v6 2/4] media: rockchip: rkisp1: reduce number of histogram grid elements in uapi Heiko Stuebner 2021-01-18 11:04 ` Heiko Stuebner 2021-01-18 18:04 ` Helen Koike 2021-01-18 18:04 ` Helen Koike 2021-01-18 11:04 ` [PATCH v6 3/4] media: rockchip: rkisp1: carry ip version information Heiko Stuebner 2021-01-18 11:04 ` Heiko Stuebner 2021-01-18 18:04 ` Helen Koike 2021-01-18 18:04 ` Helen Koike 2021-01-18 11:04 ` [PATCH v6 4/4] media: rockchip: rkisp1: extend uapi array sizes Heiko Stuebner 2021-01-18 11:04 ` Heiko Stuebner 2021-01-18 18:04 ` Helen Koike 2021-01-18 18:04 ` Helen Koike 2021-01-18 11:08 ` [PATCH v6 0/4] Fix the rkisp1 userspace API for later IP versions Hans Verkuil 2021-01-18 11:08 ` Hans Verkuil
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210118110448.275389-1-heiko@sntech.de \ --to=heiko@sntech.de \ --cc=Laurent.pinchart@ideasonboard.com \ --cc=christoph.muellner@theobroma-systems.com \ --cc=dafna.hirschfeld@collabora.com \ --cc=ezequiel@collabora.com \ --cc=helen.koike@collabora.com \ --cc=hverkuil@xs4all.nl \ --cc=linux-media@vger.kernel.org \ --cc=linux-rockchip@lists.infradead.org \ --cc=mchehab@kernel.org \ --cc=tfiga@chromium.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.