All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Stuebner <heiko@sntech.de>
To: dafna.hirschfeld@collabora.com, helen.koike@collabora.com,
	linux-media@vger.kernel.org, mchehab@kernel.org,
	Laurent.pinchart@ideasonboard.com, hverkuil@xs4all.nl
Cc: linux-rockchip@lists.infradead.org, ezequiel@collabora.com,
	christoph.muellner@theobroma-systems.com, heiko@sntech.de,
	tfiga@chromium.org,
	Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
Subject: [PATCH v6 2/4] media: rockchip: rkisp1: reduce number of histogram grid elements in uapi
Date: Mon, 18 Jan 2021 12:04:46 +0100	[thread overview]
Message-ID: <20210118110448.275389-3-heiko@sntech.de> (raw)
In-Reply-To: <20210118110448.275389-1-heiko@sntech.de>

From: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>

The uapi right now specifies an array size of 28 but the actual number
of elements is only 25 with the last 3 being unused.

Reduce the array size to the correct number of elements.

Signed-off-by: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
---
 include/uapi/linux/rkisp1-config.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/include/uapi/linux/rkisp1-config.h b/include/uapi/linux/rkisp1-config.h
index ba443771cc0b..ecfb8f7a6c70 100644
--- a/include/uapi/linux/rkisp1-config.h
+++ b/include/uapi/linux/rkisp1-config.h
@@ -102,8 +102,7 @@
 /*
  * Histogram calculation
  */
-/* Last 3 values unused. */
-#define RKISP1_CIF_ISP_HISTOGRAM_WEIGHT_GRIDS_SIZE 28
+#define RKISP1_CIF_ISP_HISTOGRAM_WEIGHT_GRIDS_SIZE 25
 
 /*
  * Defect Pixel Cluster Correction
-- 
2.29.2


WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: dafna.hirschfeld@collabora.com, helen.koike@collabora.com,
	linux-media@vger.kernel.org, mchehab@kernel.org,
	Laurent.pinchart@ideasonboard.com, hverkuil@xs4all.nl
Cc: heiko@sntech.de,
	Heiko Stuebner <heiko.stuebner@theobroma-systems.com>,
	tfiga@chromium.org, linux-rockchip@lists.infradead.org,
	ezequiel@collabora.com, christoph.muellner@theobroma-systems.com
Subject: [PATCH v6 2/4] media: rockchip: rkisp1: reduce number of histogram grid elements in uapi
Date: Mon, 18 Jan 2021 12:04:46 +0100	[thread overview]
Message-ID: <20210118110448.275389-3-heiko@sntech.de> (raw)
In-Reply-To: <20210118110448.275389-1-heiko@sntech.de>

From: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>

The uapi right now specifies an array size of 28 but the actual number
of elements is only 25 with the last 3 being unused.

Reduce the array size to the correct number of elements.

Signed-off-by: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
---
 include/uapi/linux/rkisp1-config.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/include/uapi/linux/rkisp1-config.h b/include/uapi/linux/rkisp1-config.h
index ba443771cc0b..ecfb8f7a6c70 100644
--- a/include/uapi/linux/rkisp1-config.h
+++ b/include/uapi/linux/rkisp1-config.h
@@ -102,8 +102,7 @@
 /*
  * Histogram calculation
  */
-/* Last 3 values unused. */
-#define RKISP1_CIF_ISP_HISTOGRAM_WEIGHT_GRIDS_SIZE 28
+#define RKISP1_CIF_ISP_HISTOGRAM_WEIGHT_GRIDS_SIZE 25
 
 /*
  * Defect Pixel Cluster Correction
-- 
2.29.2


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  parent reply	other threads:[~2021-01-18 11:06 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-18 11:04 [PATCH v6 0/4] Fix the rkisp1 userspace API for later IP versions Heiko Stuebner
2021-01-18 11:04 ` Heiko Stuebner
2021-01-18 11:04 ` [PATCH v6 1/4] media: rockchip: rkisp1: fix comment about number of histogram sub-windows Heiko Stuebner
2021-01-18 11:04   ` Heiko Stuebner
2021-01-18 18:03   ` Helen Koike
2021-01-18 18:03     ` Helen Koike
2021-01-18 11:04 ` Heiko Stuebner [this message]
2021-01-18 11:04   ` [PATCH v6 2/4] media: rockchip: rkisp1: reduce number of histogram grid elements in uapi Heiko Stuebner
2021-01-18 18:04   ` Helen Koike
2021-01-18 18:04     ` Helen Koike
2021-01-18 11:04 ` [PATCH v6 3/4] media: rockchip: rkisp1: carry ip version information Heiko Stuebner
2021-01-18 11:04   ` Heiko Stuebner
2021-01-18 18:04   ` Helen Koike
2021-01-18 18:04     ` Helen Koike
2021-01-18 11:04 ` [PATCH v6 4/4] media: rockchip: rkisp1: extend uapi array sizes Heiko Stuebner
2021-01-18 11:04   ` Heiko Stuebner
2021-01-18 18:04   ` Helen Koike
2021-01-18 18:04     ` Helen Koike
2021-01-18 11:08 ` [PATCH v6 0/4] Fix the rkisp1 userspace API for later IP versions Hans Verkuil
2021-01-18 11:08   ` Hans Verkuil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210118110448.275389-3-heiko@sntech.de \
    --to=heiko@sntech.de \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=christoph.muellner@theobroma-systems.com \
    --cc=dafna.hirschfeld@collabora.com \
    --cc=ezequiel@collabora.com \
    --cc=heiko.stuebner@theobroma-systems.com \
    --cc=helen.koike@collabora.com \
    --cc=hverkuil@xs4all.nl \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mchehab@kernel.org \
    --cc=tfiga@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.