From: roger.pau--- via <qemu-devel@nongnu.org> To: <qemu-devel@nongnu.org> Cc: Kevin Wolf <kwolf@redhat.com>, Stefano Stabellini <sstabellini@kernel.org>, qemu-block@nongnu.org, Paul Durrant <paul@xen.org>, Arthur Borsboom <arthurborsboom@gmail.com>, Max Reitz <mreitz@redhat.com>, Anthony Perard <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org, Roger Pau Monne <roger.pau@citrix.com> Subject: [PATCH] xen-block: fix reporting of discard feature Date: Mon, 18 Jan 2021 16:33:30 +0100 [thread overview] Message-ID: <20210118153330.82324-1-roger.pau@citrix.com> (raw) Linux blkfront expects both "discard-granularity" and "discard-alignment" present on xenbus in order to properly enable the feature, not exposing "discard-alignment" left some Linux blkfront versions with a broken discard setup. This has also been addressed in Linux with: https://lore.kernel.org/lkml/20210118151528.81668-1-roger.pau@citrix.com/T/#u Fix QEMU to report a "discard-alignment" of 0, in order for it to work with older Linux frontends. Reported-by: Arthur Borsboom <arthurborsboom@gmail.com> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com> --- Cc: Stefano Stabellini <sstabellini@kernel.org> Cc: Anthony Perard <anthony.perard@citrix.com> Cc: Paul Durrant <paul@xen.org> Cc: Kevin Wolf <kwolf@redhat.com> Cc: Max Reitz <mreitz@redhat.com> Cc: xen-devel@lists.xenproject.org Cc: qemu-block@nongnu.org --- hw/block/xen-block.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/block/xen-block.c b/hw/block/xen-block.c index 718d886e5c..246d9c23a2 100644 --- a/hw/block/xen-block.c +++ b/hw/block/xen-block.c @@ -253,6 +253,7 @@ static void xen_block_realize(XenDevice *xendev, Error **errp) xen_device_backend_printf(xendev, "feature-discard", "%u", 1); xen_device_backend_printf(xendev, "discard-granularity", "%u", conf->discard_granularity); + xen_device_backend_printf(xendev, "discard-alignment", "%u", 0); } xen_device_backend_printf(xendev, "feature-flush-cache", "%u", 1); -- 2.29.2
WARNING: multiple messages have this Message-ID (diff)
From: Roger Pau Monne <roger.pau@citrix.com> To: <qemu-devel@nongnu.org> Cc: Roger Pau Monne <roger.pau@citrix.com>, Arthur Borsboom <arthurborsboom@gmail.com>, Stefano Stabellini <sstabellini@kernel.org>, Anthony Perard <anthony.perard@citrix.com>, Paul Durrant <paul@xen.org>, Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>, <xen-devel@lists.xenproject.org>, <qemu-block@nongnu.org> Subject: [PATCH] xen-block: fix reporting of discard feature Date: Mon, 18 Jan 2021 16:33:30 +0100 [thread overview] Message-ID: <20210118153330.82324-1-roger.pau@citrix.com> (raw) Linux blkfront expects both "discard-granularity" and "discard-alignment" present on xenbus in order to properly enable the feature, not exposing "discard-alignment" left some Linux blkfront versions with a broken discard setup. This has also been addressed in Linux with: https://lore.kernel.org/lkml/20210118151528.81668-1-roger.pau@citrix.com/T/#u Fix QEMU to report a "discard-alignment" of 0, in order for it to work with older Linux frontends. Reported-by: Arthur Borsboom <arthurborsboom@gmail.com> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com> --- Cc: Stefano Stabellini <sstabellini@kernel.org> Cc: Anthony Perard <anthony.perard@citrix.com> Cc: Paul Durrant <paul@xen.org> Cc: Kevin Wolf <kwolf@redhat.com> Cc: Max Reitz <mreitz@redhat.com> Cc: xen-devel@lists.xenproject.org Cc: qemu-block@nongnu.org --- hw/block/xen-block.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/block/xen-block.c b/hw/block/xen-block.c index 718d886e5c..246d9c23a2 100644 --- a/hw/block/xen-block.c +++ b/hw/block/xen-block.c @@ -253,6 +253,7 @@ static void xen_block_realize(XenDevice *xendev, Error **errp) xen_device_backend_printf(xendev, "feature-discard", "%u", 1); xen_device_backend_printf(xendev, "discard-granularity", "%u", conf->discard_granularity); + xen_device_backend_printf(xendev, "discard-alignment", "%u", 0); } xen_device_backend_printf(xendev, "feature-flush-cache", "%u", 1); -- 2.29.2
next reply other threads:[~2021-01-18 15:35 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-18 15:33 roger.pau--- via [this message] 2021-01-18 15:33 ` [PATCH] xen-block: fix reporting of discard feature Roger Pau Monne 2021-01-18 15:49 ` Paul Durrant 2021-01-18 15:49 ` Paul Durrant 2021-02-15 10:51 ` Kevin Wolf 2021-02-15 10:51 ` Kevin Wolf
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210118153330.82324-1-roger.pau@citrix.com \ --to=qemu-devel@nongnu.org \ --cc=anthony.perard@citrix.com \ --cc=arthurborsboom@gmail.com \ --cc=kwolf@redhat.com \ --cc=mreitz@redhat.com \ --cc=paul@xen.org \ --cc=qemu-block@nongnu.org \ --cc=roger.pau@citrix.com \ --cc=sstabellini@kernel.org \ --cc=xen-devel@lists.xenproject.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.