From: Vincenzo Frascino <vincenzo.frascino@arm.com> To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com Cc: Vincenzo Frascino <vincenzo.frascino@arm.com>, Andrey Ryabinin <aryabinin@virtuozzo.com>, Alexander Potapenko <glider@google.com>, Dmitry Vyukov <dvyukov@google.com>, Leon Romanovsky <leonro@mellanox.com>, Andrey Konovalov <andreyknvl@google.com>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org> Subject: [PATCH v2 2/2] kasan: Add explicit preconditions to kasan_report() Date: Thu, 21 Jan 2021 13:19:56 +0000 [thread overview] Message-ID: <20210121131956.23246-3-vincenzo.frascino@arm.com> (raw) In-Reply-To: <20210121131956.23246-1-vincenzo.frascino@arm.com> With the introduction of KASAN_HW_TAGS, kasan_report() dereferences the address passed as a parameter. Add a comment to make sure that the preconditions to the function are explicitly clarified. Note: An invalid address (e.g. NULL) passed to the function when, KASAN_HW_TAGS is enabled, leads to a kernel panic. Cc: Andrey Ryabinin <aryabinin@virtuozzo.com> Cc: Alexander Potapenko <glider@google.com> Cc: Dmitry Vyukov <dvyukov@google.com> Cc: Leon Romanovsky <leonro@mellanox.com> Cc: Andrey Konovalov <andreyknvl@google.com> Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com> --- mm/kasan/kasan.h | 2 +- mm/kasan/report.c | 7 +++++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/mm/kasan/kasan.h b/mm/kasan/kasan.h index cc4d9e1d49b1..8c706e7652f2 100644 --- a/mm/kasan/kasan.h +++ b/mm/kasan/kasan.h @@ -209,7 +209,7 @@ bool check_memory_region(unsigned long addr, size_t size, bool write, static inline bool addr_has_metadata(const void *addr) { - return true; + return (is_vmalloc_addr(addr) || virt_addr_valid(addr)); } #endif /* CONFIG_KASAN_GENERIC || CONFIG_KASAN_SW_TAGS */ diff --git a/mm/kasan/report.c b/mm/kasan/report.c index c0fb21797550..8b690091cb37 100644 --- a/mm/kasan/report.c +++ b/mm/kasan/report.c @@ -403,6 +403,13 @@ static void __kasan_report(unsigned long addr, size_t size, bool is_write, end_report(&flags); } +/** + * kasan_report - report kasan fault details + * @addr: valid address of the allocation where the tag fault was detected + * @size: size of the allocation where the tag fault was detected + * @is_write: the instruction that caused the fault was a read or write? + * @ip: pointer to the instruction that cause the fault + */ bool kasan_report(unsigned long addr, size_t size, bool is_write, unsigned long ip) { -- 2.30.0
WARNING: multiple messages have this Message-ID (diff)
From: Vincenzo Frascino <vincenzo.frascino@arm.com> To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com Cc: Andrey Konovalov <andreyknvl@google.com>, Leon Romanovsky <leonro@mellanox.com>, Alexander Potapenko <glider@google.com>, Catalin Marinas <catalin.marinas@arm.com>, Andrey Ryabinin <aryabinin@virtuozzo.com>, Vincenzo Frascino <vincenzo.frascino@arm.com>, Will Deacon <will@kernel.org>, Dmitry Vyukov <dvyukov@google.com> Subject: [PATCH v2 2/2] kasan: Add explicit preconditions to kasan_report() Date: Thu, 21 Jan 2021 13:19:56 +0000 [thread overview] Message-ID: <20210121131956.23246-3-vincenzo.frascino@arm.com> (raw) In-Reply-To: <20210121131956.23246-1-vincenzo.frascino@arm.com> With the introduction of KASAN_HW_TAGS, kasan_report() dereferences the address passed as a parameter. Add a comment to make sure that the preconditions to the function are explicitly clarified. Note: An invalid address (e.g. NULL) passed to the function when, KASAN_HW_TAGS is enabled, leads to a kernel panic. Cc: Andrey Ryabinin <aryabinin@virtuozzo.com> Cc: Alexander Potapenko <glider@google.com> Cc: Dmitry Vyukov <dvyukov@google.com> Cc: Leon Romanovsky <leonro@mellanox.com> Cc: Andrey Konovalov <andreyknvl@google.com> Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com> --- mm/kasan/kasan.h | 2 +- mm/kasan/report.c | 7 +++++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/mm/kasan/kasan.h b/mm/kasan/kasan.h index cc4d9e1d49b1..8c706e7652f2 100644 --- a/mm/kasan/kasan.h +++ b/mm/kasan/kasan.h @@ -209,7 +209,7 @@ bool check_memory_region(unsigned long addr, size_t size, bool write, static inline bool addr_has_metadata(const void *addr) { - return true; + return (is_vmalloc_addr(addr) || virt_addr_valid(addr)); } #endif /* CONFIG_KASAN_GENERIC || CONFIG_KASAN_SW_TAGS */ diff --git a/mm/kasan/report.c b/mm/kasan/report.c index c0fb21797550..8b690091cb37 100644 --- a/mm/kasan/report.c +++ b/mm/kasan/report.c @@ -403,6 +403,13 @@ static void __kasan_report(unsigned long addr, size_t size, bool is_write, end_report(&flags); } +/** + * kasan_report - report kasan fault details + * @addr: valid address of the allocation where the tag fault was detected + * @size: size of the allocation where the tag fault was detected + * @is_write: the instruction that caused the fault was a read or write? + * @ip: pointer to the instruction that cause the fault + */ bool kasan_report(unsigned long addr, size_t size, bool is_write, unsigned long ip) { -- 2.30.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-01-21 13:23 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-21 13:19 [PATCH v2 0/2] kasan: Fix metadata detection for KASAN_HW_TAGS Vincenzo Frascino 2021-01-21 13:19 ` Vincenzo Frascino 2021-01-21 13:19 ` [PATCH v2 1/2] arm64: Fix kernel address detection of __is_lm_address() Vincenzo Frascino 2021-01-21 13:19 ` Vincenzo Frascino 2021-01-21 15:12 ` Mark Rutland 2021-01-21 15:12 ` Mark Rutland 2021-01-21 15:30 ` Vincenzo Frascino 2021-01-21 15:30 ` Vincenzo Frascino 2021-01-21 15:49 ` Mark Rutland 2021-01-21 15:49 ` Mark Rutland 2021-01-21 16:02 ` Vincenzo Frascino 2021-01-21 16:02 ` Vincenzo Frascino 2021-01-21 17:43 ` Vincenzo Frascino 2021-01-21 17:43 ` Vincenzo Frascino 2021-01-21 13:19 ` Vincenzo Frascino [this message] 2021-01-21 13:19 ` [PATCH v2 2/2] kasan: Add explicit preconditions to kasan_report() Vincenzo Frascino 2021-01-21 17:20 ` Andrey Konovalov 2021-01-21 17:20 ` Andrey Konovalov 2021-01-22 14:32 ` Vincenzo Frascino 2021-01-22 14:32 ` Vincenzo Frascino
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210121131956.23246-3-vincenzo.frascino@arm.com \ --to=vincenzo.frascino@arm.com \ --cc=andreyknvl@google.com \ --cc=aryabinin@virtuozzo.com \ --cc=catalin.marinas@arm.com \ --cc=dvyukov@google.com \ --cc=glider@google.com \ --cc=kasan-dev@googlegroups.com \ --cc=leonro@mellanox.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.