All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [CI 10/10] drm/i915/gt: Replace 'return' with a fall-through
Date: Fri, 22 Jan 2021 19:29:13 +0000	[thread overview]
Message-ID: <20210122192913.4518-10-chris@chris-wilson.co.uk> (raw)
In-Reply-To: <20210122192913.4518-1-chris@chris-wilson.co.uk>

Checkpatch worries that the 'return' before an else clause might be
redundant. In this case, it is avoiding hitting the MISSING_CASE()
warning. Let us appease checkpatch by falling through to the end of the
function, which typically means that we then clean up the unused
wa_list.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
---
 drivers/gpu/drm/i915/gt/intel_workarounds.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c
index 96edc76f5dcd..82e15c8c7a97 100644
--- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
+++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
@@ -756,7 +756,7 @@ __intel_engine_init_ctx_wa(struct intel_engine_cs *engine,
 	else if (IS_GEN(i915, 6))
 		gen6_ctx_workarounds_init(engine, wal);
 	else if (INTEL_GEN(i915) < 8)
-		return;
+		;
 	else
 		MISSING_CASE(INTEL_GEN(i915));
 
@@ -1208,7 +1208,7 @@ gt_init_workarounds(struct drm_i915_private *i915, struct i915_wa_list *wal)
 	else if (IS_GEN(i915, 4))
 		gen4_gt_workarounds_init(i915, wal);
 	else if (INTEL_GEN(i915) <= 8)
-		return;
+		;
 	else
 		MISSING_CASE(INTEL_GEN(i915));
 }
@@ -1583,7 +1583,7 @@ void intel_engine_init_whitelist(struct intel_engine_cs *engine)
 	else if (IS_SKYLAKE(i915))
 		skl_whitelist_build(engine);
 	else if (INTEL_GEN(i915) <= 8)
-		return;
+		;
 	else
 		MISSING_CASE(INTEL_GEN(i915));
 
-- 
2.20.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2021-01-22 19:29 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-22 19:29 [Intel-gfx] [CI 01/10] drm/i915/gt: SPDX cleanup Chris Wilson
2021-01-22 19:29 ` [Intel-gfx] [CI 02/10] drm/i915/gt: Add some missing blank lines after declaration Chris Wilson
2021-01-22 19:29 ` [Intel-gfx] [CI 03/10] drm/i915/gt: Remove repeated words from comments Chris Wilson
2021-01-22 19:29 ` [Intel-gfx] [CI 04/10] drm/i915/gt: Fixup misaligned function parameters Chris Wilson
2021-01-22 19:29 ` [Intel-gfx] [CI 05/10] drm/i915/gt: Remove a bonus newline Chris Wilson
2021-01-22 19:29 ` [Intel-gfx] [CI 06/10] drm/i915/gt: Wrap macro arg in () Chris Wilson
2021-01-22 19:29 ` [Intel-gfx] [CI 07/10] drm/i915/gt: Insert spaces into GEN3_L3LOG_SIZE/4 Chris Wilson
2021-01-22 19:29 ` [Intel-gfx] [CI 08/10] drm/i915/gt: Replace unnecessary ',' with '; ' Chris Wilson
2021-01-22 19:29 ` [Intel-gfx] [CI 09/10] drm/i915/gt: Add a space before '(' Chris Wilson
2021-01-22 19:29 ` Chris Wilson [this message]
2021-01-22 23:18 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [CI,01/10] drm/i915/gt: SPDX cleanup Patchwork
2021-01-22 23:45 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-01-23  8:55 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210122192913.4518-10-chris@chris-wilson.co.uk \
    --to=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.